Skip to contentSkip to conversation

arm: dts: at91: Fix boolean properties with values

PATCH RESEND Applied Rob Herring 4 participants 4 messages Apr 6, 2022 – Apr 13, 2022

Subsystems (2)
Device tree bindings Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH RESEND 1/1 arm: dts: at91: Fix boolean properties with values

Boolean properties in DT are present or not present and don't take a value. A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't matter.

It may have been intended that 0 values are false, but there is no change in behavior with this patch.

Signed-off-by Rob Herring <[email protected]>

---
Can someone apply this for 5.18 please.

 arch/arm/boot/dts/at91-kizbox3-hs.dts      | 2 +-
 arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/at91-kizbox3-hs.dts +1 -1
index 2799b2a1f4d2..f7d90cf1bb77 100644
@@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst {
 		pinctrl_pio_io_reset: gpio_io_reset {
 			pinmux = <PIN_PB30__GPIO>;
 			bias-disable;
-			drive-open-drain = <1>;
+			drive-open-drain;
 			output-low;
 		};
 		pinctrl_pio_input: gpio_input {
arch/arm/boot/dts/at91-kizbox3_common.dtsi +1 -1
index abe27adfa4d6..465664628419 100644
@@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default {
 		pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA
 		<PIN_PD13__FLEXCOM4_IO1>; //CLK
 		bias-disable;
-		drive-open-drain = <1>;
+		drive-open-drain;
 	};
 
 	pinctrl_pwm0 {
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Rob Herring

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Boolean properties in DT are present or not present and don't take a value. A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't matter.

It may have been intended that 0 values are false, but there is no change in behavior with this patch.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Claudiu Beznea <[email protected]>
Quoted 41 lines

---
Can someone apply this for 5.18 please.

 arch/arm/boot/dts/at91-kizbox3-hs.dts      | 2 +-
 arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/at91-kizbox3-hs.dts +1 -1
index 2799b2a1f4d2..f7d90cf1bb77 100644
@@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst {
                pinctrl_pio_io_reset: gpio_io_reset {
                        pinmux = <PIN_PB30__GPIO>;
                        bias-disable;
-                       drive-open-drain = <1>;
+                       drive-open-drain;
                        output-low;
                };
                pinctrl_pio_input: gpio_input {
arch/arm/boot/dts/at91-kizbox3_common.dtsi +1 -2
index abe27adfa4d6..465664628419 100644
@@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default {
                pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA
                <PIN_PD13__FLEXCOM4_IO1>; //CLK
                bias-disable;
-               drive-open-drain = <1>;
+               drive-open-drain;
        };
 
        pinctrl_pwm0 {
--

2.32.0

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

CI Applied
#2 lore raw
In reply to Rob Herring
This patch was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <[email protected]>:

Quoted 8 lines · On Wed, 6 Apr 2022 14:09:47 -0500 you wrote:

Boolean properties in DT are present or not present and don't take a value. A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't matter.

It may have been intended that 0 values are false, but there is no change in behavior with this patch.

[...]

Here is the summary with links:
- [RESEND] arm: dts: at91: Fix boolean properties with values

    https://git.kernel.org/soc/soc/c/0dc23d1a8e17

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Rob Herring
Quoted 10 lines · Rob Herring

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Boolean properties in DT are present or not present and don't take a value. A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't matter.

It may have been intended that 0 values are false, but there is no change in behavior with this patch.

Signed-off-by Rob Herring <[email protected]>
Acked-by Nicolas Ferre <[email protected]>
Quoted 2 lines

---
Can someone apply this for 5.18 please.

Yes, sure, it's now queued in the fixes branch for 5.18.

Thanks for your help Rob. Best regards,
Nicolas

Quoted 34 lines
  arch/arm/boot/dts/at91-kizbox3-hs.dts      | 2 +-
  arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/at91-kizbox3-hs.dts +1 -1
index 2799b2a1f4d2..f7d90cf1bb77 100644
@@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst {
                 pinctrl_pio_io_reset: gpio_io_reset {
                         pinmux = <PIN_PB30__GPIO>;
                         bias-disable;
-                       drive-open-drain = <1>;
+                       drive-open-drain;
                         output-low;
                 };
                 pinctrl_pio_input: gpio_input {
arch/arm/boot/dts/at91-kizbox3_common.dtsi +1 -2
index abe27adfa4d6..465664628419 100644
@@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default {
                 pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA
                 <PIN_PD13__FLEXCOM4_IO1>; //CLK
                 bias-disable;
-               drive-open-drain = <1>;
+               drive-open-drain;
         };
 
         pinctrl_pwm0 {
--

2.32.0

Signature · 1 line
Nicolas Ferre