Skip to contentSkip to conversation

tests/kms: Skip kms test cases for DCC and DCC_RETILE

PATCH Superseded Alex Hung 4 participants 8 messages Apr 7, 2022 – Apr 15, 2022

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Alex Hung

author
#0 lore raw

PATCH v2 1/1 tests/kms: Skip kms test cases for DCC and DCC_RETILE

Skip the KMS test cases for planes that has modifiers with DCC and DCC_RETILE on AMDGPU.

Current pixel-format and pixel-format-source-clamping subtests do not support modifers with DCC or DCC_RETILE in kernel.

1. dcc_formats's cpp[1] is set to 0 and this triggers kernel errors "Format requires non-linear modifier for plane 1" because block_size (i.e. cpp[1]) == 0. See kernel commits 816853f9dc40 and 8db2dc852941.

2. the subtests cause kernel's amdgpu_display_verify_sizes to fail because they do not provide an extra plane with compression metadata. See kernel commit 234055fd9728 for details.

---

v2: update comments in commit messages

 tests/kms_plane.c | 8 ++++++++
 1 file changed, 8 insertions(+)
tests/kms_plane.c +8 -0
index 137f23a8..1a71822a 100644
@@ -1004,6 +1004,14 @@ static bool skip_plane(data_t *data, igt_plane_t *plane)
 {
 	int index = plane->index;
 
+	for (int i = 0; i < plane->format_mod_count; i++) {
+		if (AMD_FMT_MOD_GET(DCC, plane->modifiers[i]) ||
+		    AMD_FMT_MOD_GET(DCC_RETILE, plane->modifiers[i])) {
+			igt_debug("Skipping planes with DCC or DCC_RETILE\n");
+			return true;
+		}
+	}
+
 	if (data->extended)
 		return false;
 
Signature · 1 line
2.35.1
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms: Skip kms test cases for DCC and DCC_RETILE

== Series Details ==

== Series Details ==

Series: tests/kms: Skip kms test cases for DCC and DCC_RETILE
URL : https://patchwork.freedesktop.org/series/102357/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11472 -> IGTPW_6895
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6895 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6895, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/index.html

Participating hosts (48 -> 45)
------------------------------

Additional (3): bat-hsw-1 bat-adlm-1 bat-adlp-4
Missing (6): shard-tglu shard-rkl fi-bsw-cyan fi-elk-e7500 fi-blb-e6850 fi-bdw-samus

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6895:

### IGT changes ###

#### Possible regressions ####

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-bsw-nick: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-bsw-nick/igt@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][2] +146 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/bat-adlp-4/igt@[email protected]

#### Warnings ####

* igt@runner@aborted:
- fi-kbl-x1275: [FAIL][3] ([i915#4312]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-kbl-x1275/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-kbl-x1275/igt@[email protected]
- fi-kbl-7500u: [FAIL][5] ([i915#4312]) -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-kbl-7500u/igt@[email protected]
- fi-kbl-7567u: [FAIL][7] ([i915#4312]) -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-kbl-7567u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-kbl-7567u/igt@[email protected]
- fi-skl-guc: [FAIL][9] ([i915#4312] / [i915#5257]) -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-skl-guc/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-skl-guc/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_lmem_swapping@basic:
- {fi-jsl-1}: [FAIL][11] -> [SKIP][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-jsl-1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-jsl-1/igt@[email protected]
- {bat-dg2-9}: NOTRUN -> [SKIP][13]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/bat-dg2-9/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- {fi-jsl-1}: NOTRUN -> [FAIL][14]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-jsl-1/igt@[email protected]

* igt@runner@aborted:
- {bat-adlm-1}: NOTRUN -> [FAIL][15]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/bat-adlm-1/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6895 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@core_auth@basic-auth:
- fi-kbl-8809g: NOTRUN -> [SKIP][16] ([fdo#109271]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-kbl-8809g/igt@[email protected]

* igt@fbdev@eof:
- fi-kbl-8809g: NOTRUN -> [INCOMPLETE][17] ([i915#5557])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-kbl-8809g/igt@[email protected]

* igt@gem_exec_fence@basic-await:
- fi-bsw-nick: NOTRUN -> [SKIP][18] ([fdo#109271]) +151 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-bsw-nick/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms:
- fi-kbl-soraka: NOTRUN -> [SKIP][19] ([fdo#109271]) +146 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-kbl-soraka/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- bat-adlp-4: NOTRUN -> [SKIP][20] ([i915#5341])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/bat-adlp-4/igt@[email protected]
- fi-bsw-nick: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#5341])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-bsw-nick/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#5341])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-kbl-soraka/igt@[email protected]

* igt@runner@aborted:
- bat-adlp-4: NOTRUN -> [FAIL][23] ([i915#4312])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/bat-adlp-4/igt@[email protected]

#### Warnings ####

* igt@runner@aborted:
- fi-bsw-nick: [FAIL][24] ([i915#3690]) -> [FAIL][25] ([i915#4312])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-bsw-nick/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-bsw-nick/igt@[email protected]
- fi-kbl-8809g: [FAIL][26] -> [FAIL][27] ([i915#2722])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-kbl-8809g/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-kbl-8809g/igt@[email protected]
- fi-kbl-soraka: [FAIL][28] -> [FAIL][29] ([i915#4312])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-kbl-soraka/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-kbl-soraka/igt@[email protected]
- fi-hsw-4770: [FAIL][30] ([i915#4312]) -> [FAIL][31] ([i915#5594])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-hsw-4770/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-hsw-4770/igt@[email protected]
- fi-tgl-1115g4: [FAIL][32] ([i915#4312] / [i915#5257]) -> [FAIL][33] ([i915#3690] / [i915#4312])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-tgl-1115g4/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/fi-tgl-1115g4/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#3690]: https://gitlab.freedesktop.org/drm/intel/issues/3690
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#5171]: https://gitlab.freedesktop.org/drm/intel/issues/5171
[i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[i915#5557]: https://gitlab.freedesktop.org/drm/intel/issues/5557
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6415 -> IGTPW_6895

CI-20190529: 20190529
CI_DRM_11472: 85882df13168c5f46b41401b96975de857e3ccac @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6895: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/index.html
IGT_6415: c3b690bd5f7fb1fb7ed786ab0f3b815930a6a55f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6895/index.html

#2 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms: Skip kms test cases for DCC and DCC_RETILE (rev2)

In reply to Alex Hung
== Series Details ==

== Series Details ==

Series: tests/kms: Skip kms test cases for DCC and DCC_RETILE (rev2)
URL : https://patchwork.freedesktop.org/series/102357/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11472 -> IGTPW_6897
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6897 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6897, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/index.html

Participating hosts (48 -> 33)
------------------------------

Missing (15): fi-bdw-samus shard-tglu bat-adls-5 bat-dg1-6 bat-dg1-5 bat-dg2-8 shard-rkl bat-dg2-9 fi-bsw-cyan bat-adlp-6 fi-elk-e7500 bat-rpls-1 fi-blb-e6850 bat-jsl-2 bat-jsl-1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6897:

### IGT changes ###

#### Possible regressions ####

* igt@gem_lmem_swapping@basic:
- fi-cfl-8109u: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-cfl-8109u/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-hsw-4770: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-hsw-4770/igt@[email protected]

#### Warnings ####

* igt@gem_lmem_swapping@basic:
- fi-skl-guc: [FAIL][3] ([i915#4547]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-skl-guc/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-skl-guc/igt@[email protected]

* igt@runner@aborted:
- fi-kbl-7567u: [FAIL][5] ([i915#4312]) -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-kbl-7567u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-kbl-7567u/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_lmem_swapping@basic:
- {fi-tgl-dsi}: NOTRUN -> [SKIP][7] +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-tgl-dsi/igt@[email protected]

* igt@runner@aborted:
- {fi-jsl-1}: [FAIL][8] ([i915#4312]) -> [FAIL][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-jsl-1/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-jsl-1/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6897 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_flip@basic-flip-vs-dpms:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271]) +146 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-kbl-soraka/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: NOTRUN -> [SKIP][11] ([fdo#109271]) +145 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-cfl-8109u/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-cfl-8109u: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#5341])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-cfl-8109u/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#5341])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-kbl-soraka/igt@[email protected]

#### Warnings ####

* igt@gem_lmem_swapping@basic:
- fi-glk-j4005: [FAIL][14] -> [SKIP][15] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-glk-j4005/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-glk-j4005/igt@[email protected]
- fi-hsw-4770: [FAIL][16] -> [SKIP][17] ([fdo#109271])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-hsw-4770/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-hsw-4770/igt@[email protected]

* igt@runner@aborted:
- fi-cfl-8109u: [FAIL][18] -> [FAIL][19] ([i915#4312])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-cfl-8109u/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-cfl-8109u/igt@[email protected]
- fi-kbl-soraka: [FAIL][20] -> [FAIL][21] ([i915#4312])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-kbl-soraka/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-kbl-soraka/igt@[email protected]
- fi-hsw-4770: [FAIL][22] ([i915#4312]) -> [FAIL][23] ([i915#4312] / [i915#5594])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-hsw-4770/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-hsw-4770/igt@[email protected]
- fi-kbl-7500u: [FAIL][24] ([i915#4312]) -> [FAIL][25] ([i915#4312] / [i915#5257])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-kbl-7500u/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-kbl-7500u/igt@[email protected]
- fi-kbl-guc: [FAIL][26] ([i915#4312] / [i915#5257]) -> [FAIL][27] ([i915#4312])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-kbl-guc/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-kbl-guc/igt@[email protected]
- fi-tgl-1115g4: [FAIL][28] ([i915#4312] / [i915#5257]) -> [FAIL][29] ([i915#3690] / [i915#4312])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-tgl-1115g4/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-tgl-1115g4/igt@[email protected]
- fi-skl-guc: [FAIL][30] ([i915#4312] / [i915#5257]) -> [FAIL][31] ([i915#4312])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11472/fi-skl-guc/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/fi-skl-guc/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#3690]: https://gitlab.freedesktop.org/drm/intel/issues/3690
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6415 -> IGTPW_6897

CI-20190529: 20190529
CI_DRM_11472: 85882df13168c5f46b41401b96975de857e3ccac @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6897: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/index.html
IGT_6415: c3b690bd5f7fb1fb7ed786ab0f3b815930a6a55f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6897/index.html

#3 lore raw
In reply to Alex Hung

On Thu, Apr 7, 2022 at 1:42 PM Alex Hung <[email protected]> wrote:
title of commit message should include the test name if you're fixing only 1 text. so it would be tests/kms_plane

Quoted 2 lines

Skip the KMS test cases for planes that has modifiers with

nit: s/has/have.

Quoted 4 lines

DCC and DCC_RETILE on AMDGPU.

Current pixel-format and pixel-format-source-clamping subtests do not support modifers with DCC or DCC_RETILE in kernel.

nit: s/modifers/modifiers

Quoted 2 lines

1. dcc_formats's cpp[1] is set to 0 and this triggers kernel errors

is [1] referring to a url? i dont see it.

Quoted 2 lines

"Format requires non-linear modifier for plane 1" because block_size (i.e. cpp[1]) == 0. See kernel commits 816853f9dc40 and 8db2dc852941.

I would prefer you add links to make it easy to look up.

Quoted 4 lines

2. the subtests cause kernel's amdgpu_display_verify_sizes to fail because they do not provide an extra plane with compression metadata. See kernel commit 234055fd9728 for details.

ditto

if this is affecting a specific subtest, please add it here.

Quoted 14 lines

---

v2: update comments in commit messages

 tests/kms_plane.c | 8 ++++++++
 1 file changed, 8 insertions(+)
tests/kms_plane.c +0 -0
index 137f23a8..1a71822a 100644

tests/kms_plane.c static bool skip_plane(data_t *data, igt_plane_t *plane) · line 1007

Quoted 4 lines
tests/kms_plane.c +1 -0
@@ -1004,6 +1004,14 @@ static bool skip_plane(data_t *data, igt_plane_t *plane)
 {
        int index = plane->index;
 
+       for (int i = 0; i < plane->format_mod_count; i++) {

not sure how it compiled, i think you'll need to move int i to above.

Quoted 13 lines
tests/kms_plane.c +7 -1
+               if (AMD_FMT_MOD_GET(DCC, plane->modifiers[i]) ||
+                   AMD_FMT_MOD_GET(DCC_RETILE, plane->modifiers[i])) {
+                       igt_debug("Skipping planes with DCC or DCC_RETILE\n");
+                       return true;
+               }
+       }
+
        if (data->extended)
                return false;
 
--

2.35.1

author
#4 lore raw

[AMD Official Use Only]

________________________________
From: Mark Yacoub <[email protected]>
Sent: 13 April 2022 13:56
To: Hung, Alex <[email protected]>
Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: [igt-dev] [PATCH i-g-t][V2] tests/kms: Skip kms test cases for DCC and DCC_RETILE

On Thu, Apr 7, 2022 at 1:42 PM Alex Hung <[email protected]> wrote:
title of commit message should include the test name if you're fixing only 1 text. so it would be tests/kms_plane

Quoted 2 lines

Skip the KMS test cases for planes that has modifiers with

nit: s/has/have.

Quoted 4 lines

DCC and DCC_RETILE on AMDGPU.

Current pixel-format and pixel-format-source-clamping subtests do not support modifers with DCC or DCC_RETILE in kernel.

nit: s/modifers/modifiers

Quoted 2 lines

1. dcc_formats's cpp[1] is set to 0 and this triggers kernel errors

is [1] referring to a url? i dont see it.

Quoted 2 lines

"Format requires non-linear modifier for plane 1" because block_size (i.e. cpp[1]) == 0. See kernel commits 816853f9dc40 and 8db2dc852941.

I would prefer you add links to make it easy to look up.

Quoted 4 lines

2. the subtests cause kernel's amdgpu_display_verify_sizes to fail because they do not provide an extra plane with compression metadata. See kernel commit 234055fd9728 for details.

ditto

if this is affecting a specific subtest, please add it here.

Quoted 14 lines

---

v2: update comments in commit messages

 tests/kms_plane.c | 8 ++++++++
 1 file changed, 8 insertions(+)
tests/kms_plane.c +0 -0
index 137f23a8..1a71822a 100644

tests/kms_plane.c static bool skip_plane(data_t *data, igt_plane_t *plane) · line 1007

Quoted 4 lines
tests/kms_plane.c +1 -0
@@ -1004,6 +1004,14 @@ static bool skip_plane(data_t *data, igt_plane_t *plane)
 {
        int index = plane->index;
 
+       for (int i = 0; i < plane->format_mod_count; i++) {

not sure how it compiled, i think you'll need to move int i to above.

igt has many "for (int i ...)" so I use the same approach just for neatness. I will move it to above in V3.

Quoted 13 lines
tests/kms_plane.c +7 -1
+               if (AMD_FMT_MOD_GET(DCC, plane->modifiers[i]) ||
+                   AMD_FMT_MOD_GET(DCC_RETILE, plane->modifiers[i])) {
+                       igt_debug("Skipping planes with DCC or DCC_RETILE\n");
+                       return true;
+               }
+       }
+
        if (data->extended)
                return false;
 
--

2.35.1

#5 lore raw
In reply to Alex Hung
Quoted 10 lines · Alex Hung

Skip the KMS test cases for planes that has modifiers with DCC and DCC_RETILE on AMDGPU.

Current pixel-format and pixel-format-source-clamping subtests do not support modifers with DCC or DCC_RETILE in kernel.

1. dcc_formats's cpp[1] is set to 0 and this triggers kernel errors "Format requires non-linear modifier for plane 1" because block_size (i.e. cpp[1]) == 0. See kernel commits 816853f9dc40 and 8db2dc852941.

We aren't using a linear modifier here, why would this trigger?

Quoted 4 lines

2. the subtests cause kernel's amdgpu_display_verify_sizes to fail because they do not provide an extra plane with compression metadata. See kernel commit 234055fd9728 for details.

Can we do something more generic by skipping all modifiers where the number of planes != the number of planes for the format with a linear modifier?

Quoted 14 lines

---

v2: update comments in commit messages

 tests/kms_plane.c | 8 ++++++++
 1 file changed, 8 insertions(+)
tests/kms_plane.c +0 -0
index 137f23a8..1a71822a 100644

tests/kms_plane.c static bool skip_plane(data_t *data, igt_plane_t *plane) · line 1009

Quoted 6 lines
tests/kms_plane.c +3 -0
@@ -1004,6 +1004,14 @@ static bool skip_plane(data_t *data, igt_plane_t *plane)
 {
        int index = plane->index;
 
+       for (int i = 0; i < plane->format_mod_count; i++) {
+               if (AMD_FMT_MOD_GET(DCC, plane->modifiers[i]) ||
+                   AMD_FMT_MOD_GET(DCC_RETILE, plane->modifiers[i])) {

This check is only valid if you first check that this is an AMD modifier.

Quoted 11 lines
tests/kms_plane.c +5 -1
+                       igt_debug("Skipping planes with DCC or DCC_RETILE\n");
+                       return true;
+               }
+       }
+
        if (data->extended)
                return false;
 
--

2.35.1

author
#6 lore raw

[AMD Official Use Only]

________________________________
From: Bas Nieuwenhuizen <[email protected]>
Sent: 13 April 2022 16:00
To: Hung, Alex <[email protected]>
Cc: Development mailing list for IGT GPU Tools <[email protected]>; Mark Yacoub <[email protected]>; Siqueira, Rodrigo <[email protected]>; Pillai, Aurabindo <[email protected]>
Subject: Re: [PATCH i-g-t][V2] tests/kms: Skip kms test cases for DCC and DCC_RETILE

Quoted 10 lines · Alex Hung

Skip the KMS test cases for planes that has modifiers with DCC and DCC_RETILE on AMDGPU.

Current pixel-format and pixel-format-source-clamping subtests do not support modifers with DCC or DCC_RETILE in kernel.

1. dcc_formats's cpp[1] is set to 0 and this triggers kernel errors "Format requires non-linear modifier for plane 1" because block_size (i.e. cpp[1]) == 0. See kernel commits 816853f9dc40 and 8db2dc852941.

We aren't using a linear modifier here, why would this trigger?

The data seems to be all zero, and r->modifier[i] will be zero and equals DRM_FORMAT_MOD_LINEAR (= 0)

Quoted 4 lines

2. the subtests cause kernel's amdgpu_display_verify_sizes to fail because they do not provide an extra plane with compression metadata. See kernel commit 234055fd9728 for details.

Can we do something more generic by skipping all modifiers where the number of planes != the number of planes for the format with a linear modifier?

===================
Do you mean something like below:

        int nlinear = 0;
        int i;

        for (i = 0; i < plane->format_mod_count; i++)
                if (plane->modifiers[i] == DRM_FORMAT_MOD_LINEAR)
                        nlinear++;

        if (plane->format_mod_count != nlinear)
                return true;

This will affect more than DCC.

Quoted 14 lines

---

v2: update comments in commit messages

 tests/kms_plane.c | 8 ++++++++
 1 file changed, 8 insertions(+)
tests/kms_plane.c +0 -0
index 137f23a8..1a71822a 100644

tests/kms_plane.c static bool skip_plane(data_t *data, igt_plane_t *plane) · line 1009

Quoted 6 lines
tests/kms_plane.c +3 -0
@@ -1004,6 +1004,14 @@ static bool skip_plane(data_t *data, igt_plane_t *plane)
 {
        int index = plane->index;
 
+       for (int i = 0; i < plane->format_mod_count; i++) {
+               if (AMD_FMT_MOD_GET(DCC, plane->modifiers[i]) ||
+                   AMD_FMT_MOD_GET(DCC_RETILE, plane->modifiers[i])) {

This check is only valid if you first check that this is an AMD modifier.

===================
Thanks. This can be fixed by the following if it is to be used.

        for (i = 0; i < plane->format_mod_count; i++) {
                if (IS_AMD_FMT_MOD(plane->modifiers[i]) &&
                    (AMD_FMT_MOD_GET(DCC, plane->modifiers[i]) ||
                     AMD_FMT_MOD_GET(DCC_RETILE, plane->modifiers[i]))) {
                        igt_debug("Skipping planes with DCC or DCC_RETILE\n");
                        return true;
                }
        }
Quoted 11 lines
tests/kms_plane.c +5 -1
+                       igt_debug("Skipping planes with DCC or DCC_RETILE\n");
+                       return true;
+               }
+       }
+
        if (data->extended)
                return false;
 
--

2.35.1

#7 lore raw
Quoted 21 lines · Alex

[AMD Official Use Only]

________________________________
From: Bas Nieuwenhuizen <[email protected]>
Sent: 13 April 2022 16:00
To: Hung, Alex <[email protected]>
Cc: Development mailing list for IGT GPU Tools <[email protected]>; Mark Yacoub <[email protected]>; Siqueira, Rodrigo <[email protected]>; Pillai, Aurabindo <[email protected]>
Subject: Re: [PATCH i-g-t][V2] tests/kms: Skip kms test cases for DCC and DCC_RETILE

Quoted 7 lines · Alex Hung

Skip the KMS test cases for planes that has modifiers with DCC and DCC_RETILE on AMDGPU.

Current pixel-format and pixel-format-source-clamping subtests do not support modifers with DCC or DCC_RETILE in kernel.

Quoted 7 lines
Quoted 3 lines

1. dcc_formats's cpp[1] is set to 0 and this triggers kernel errors "Format requires non-linear modifier for plane 1" because block_size (i.e. cpp[1]) == 0. See kernel commits 816853f9dc40 and 8db2dc852941.

We aren't using a linear modifier here, why would this trigger?

The data seems to be all zero, and r->modifier[i] will be zero and equals DRM_FORMAT_MOD_LINEAR (= 0)

So if we hit this case at least one of the r->modifier[i] should be a DCC modifier. AFAIU KMS rules are that all planes should have the same modifier (though I cannot quickly find a check for it), so this seems like a test issue to me.

Quoted 23 lines
Quoted 5 lines

2. the subtests cause kernel's amdgpu_display_verify_sizes to fail because they do not provide an extra plane with compression metadata. See kernel commit 234055fd9728 for details.

Can we do something more generic by skipping all modifiers where the number of planes != the number of planes for the format with a linear modifier?

===================
Do you mean something like below:

        int nlinear = 0;
        int i;

        for (i = 0; i < plane->format_mod_count; i++)
                if (plane->modifiers[i] == DRM_FORMAT_MOD_LINEAR)
                        nlinear++;

        if (plane->format_mod_count != nlinear)
                return true;
Quoted 1 line

This will affect more than DCC.

No, I mean something like get_format_info_for(format, DRM_FORMAT_MOD_LINEAR)->num_planes != get_format_info_for(format, plane->modifiers[0])->num_planes . If the test can't synthesize the extra planes this seems like the obvious skip condition (no idea how you'd query this in IGT though)

Quoted 27 lines
Quoted 15 lines

---

v2: update comments in commit messages

 tests/kms_plane.c | 8 ++++++++
 1 file changed, 8 insertions(+)
tests/kms_plane.c +0 -0
index 137f23a8..1a71822a 100644

tests/kms_plane.c static bool skip_plane(data_t *data, igt_plane_t *plane) · line 1009

Quoted 6 lines
tests/kms_plane.c +3 -0
@@ -1004,6 +1004,14 @@ static bool skip_plane(data_t *data, igt_plane_t *plane)
 {
        int index = plane->index;
 
+       for (int i = 0; i < plane->format_mod_count; i++) {
+               if (AMD_FMT_MOD_GET(DCC, plane->modifiers[i]) ||
+                   AMD_FMT_MOD_GET(DCC_RETILE, plane->modifiers[i])) {

This check is only valid if you first check that this is an AMD modifier.

===================
Thanks. This can be fixed by the following if it is to be used.

Quoted 8 lines
        for (i = 0; i < plane->format_mod_count; i++) {
                if (IS_AMD_FMT_MOD(plane->modifiers[i]) &&
                    (AMD_FMT_MOD_GET(DCC, plane->modifiers[i]) ||
                     AMD_FMT_MOD_GET(DCC_RETILE, plane->modifiers[i]))) {
                        igt_debug("Skipping planes with DCC or DCC_RETILE\n");
                        return true;
                }
        }

Seems fine by me.

Quoted 13 lines
Quoted 13 lines
tests/kms_plane.c +5 -1
+                       igt_debug("Skipping planes with DCC or DCC_RETILE\n");
+                       return true;
+               }
+       }
+
        if (data->extended)
                return false;
 
--

2.35.1