qed: remove an unneed NULL check on list iterator
Subsystems (3)
PATCH v2 1/1 qed: remove an unneed NULL check on list iterator
The define for_each_pci_dev(d) is:
while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)
Thus, the list iterator 'd' is always non-NULL so it doesn't need to be checked. So just remove the unnecessary NULL check. Also remove the unnecessary initializer because the list iterator is always initialized.
---
changes since v1:
- adjust the order of variable declaration (Jakub Kicinski)
v1: https://lore.kernel.org/lkml/[email protected]/
--- drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c +2 -2
@@ -161,11 +161,11 @@ EXPORT_SYMBOL(qed_vlan_get_ndev);struct pci_dev *qed_validate_ndev (struct net_device *ndev) { -struct pci_dev *pdev =NULL ;struct net_device *upper; +struct pci_dev *pdev;for_each_pci_dev (pdev) { -if (pdev && pdev->driver && +if (pdev->driver && !strcmp (pdev->driver->name,"qede" )) { upper =pci_get_drvdata (pdev);if (upper->ifindex == ndev->ifindex)
Signature · 1 line
2.17.1
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 6 Apr 2022 09:59:21 +0800 you wrote:
The define
for_each_pci_dev(d)is:
while ((d =pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)Thus, the list iterator 'd' is always non-NULL so it doesn't need to be checked. So just remove the unnecessary NULL check. Also remove the unnecessary initializer because the list iterator is always initialized.
[...]
Here is the summary with links:
- [v2] qed: remove an unneed NULL check on list iterator
https://git.kernel.org/netdev/net-next/c/4daf5f195630
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html