Skip to contentSkip to conversation

net: atm: remove the ambassador driver

PATCH Applied Jakub Kicinski 5 participants 5 messages Apr 6, 2022 – Jun 3, 2022

Subsystems (4)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 net: atm: remove the ambassador driver

The driver for ATM Ambassador devices spews build warnings on microblaze. The virt_to_bus() calls discard the volatile keyword. The right thing to do would be to migrate this driver to a modern DMA API but it seems unlikely anyone is actually using it. There had been no fixes or functional changes here since the git era begun.

In fact it sounds like the FW loading was broken from 2008 'til 2012 - see commit fcdc90b025e6 ("atm: forever loop loading ambassador firmware").

Let's remove this driver, there isn't much changing in the APIs, if users come forward we can apologize and revert.

---
CC: [email protected],[email protected]
CC: Jesper Juhl <[email protected]>
CC: Dan Carpenter <[email protected]>
CC: Chas Williams <[email protected]> # ATM
CC: [email protected]
CC: [email protected] # MIPS
CC: [email protected]
CC: [email protected] # dunno why, get_maintainer

---
 arch/mips/configs/gpr_defconfig  |    1 -
 arch/mips/configs/mtx1_defconfig |    1 -
 drivers/atm/Kconfig              |   25 -
 drivers/atm/Makefile             |    1 -
 drivers/atm/ambassador.c         | 2400 ------------------------------
 drivers/atm/ambassador.h         |  648 --------
 6 files changed, 3076 deletions(-)
 delete mode 100644 drivers/atm/ambassador.c
 delete mode 100644 drivers/atm/ambassador.h
arch/mips/configs/gpr_defconfig +0 -1
index f86838bcae4c..b0489437621a 100644
@@ -182,7 +182,6 @@ CONFIG_ATM_FIRESTREAM=m
 CONFIG_ATM_ZATM=m
 CONFIG_ATM_NICSTAR=m
 CONFIG_ATM_IDT77252=m
-CONFIG_ATM_AMBASSADOR=m
 CONFIG_ATM_HORIZON=m
 CONFIG_ATM_IA=m
 CONFIG_ATM_FORE200E=m
arch/mips/configs/mtx1_defconfig +0 -1
index eb0b313a2109..c98099f0b354 100644
@@ -259,7 +259,6 @@ CONFIG_ATM_FIRESTREAM=m
 CONFIG_ATM_ZATM=m
 CONFIG_ATM_NICSTAR=m
 CONFIG_ATM_IDT77252=m
-CONFIG_ATM_AMBASSADOR=m
 CONFIG_ATM_HORIZON=m
 CONFIG_ATM_IA=m
 CONFIG_ATM_FORE200E=m
drivers/atm/Kconfig +0 -25
index b9370bbca828..7be08e24955c 100644
@@ -244,31 +244,6 @@ config ATM_IDT77252_USE_SUNI
 	depends on ATM_IDT77252
 	default y
 
-config ATM_AMBASSADOR
-	tristate "Madge Ambassador (Collage PCI 155 Server)"
-	depends on PCI && VIRT_TO_BUS
-	select BITREVERSE
-	help
-	  This is a driver for ATMizer based ATM card produced by Madge
-	  Networks Ltd. Say Y (or M to compile as a module named ambassador)
-	  here if you have one of these cards.
-
-config ATM_AMBASSADOR_DEBUG
-	bool "Enable debugging messages"
-	depends on ATM_AMBASSADOR
-	help
-	  Somewhat useful debugging messages are available. The choice of
-	  messages is controlled by a bitmap.  This may be specified as a
-	  module argument (kernel command line argument as well?), changed
-	  dynamically using an ioctl (not yet) or changed by sending the
-	  string "Dxxxx" to VCI 1023 (where x is a hex digit).  See the file
-	  <file:drivers/atm/ambassador.h> for the meanings of the bits in the
-	  mask.
-
-	  When active, these messages can have a significant impact on the
-	  speed of the driver, and the size of your syslog files! When
-	  inactive, they will have only a modest impact on performance.
-
 config ATM_HORIZON
 	tristate "Madge Horizon [Ultra] (Collage PCI 25 and Collage PCI 155 Client)"
 	depends on PCI && VIRT_TO_BUS
drivers/atm/Makefile +0 -1
index aa191616a72e..99ecbc280643 100644
@@ -7,7 +7,6 @@ fore_200e-y	:= fore200e.o
 
 obj-$(CONFIG_ATM_ZATM)		+= zatm.o uPD98402.o
 obj-$(CONFIG_ATM_NICSTAR)	+= nicstar.o
-obj-$(CONFIG_ATM_AMBASSADOR)	+= ambassador.o
 obj-$(CONFIG_ATM_HORIZON)	+= horizon.o
 obj-$(CONFIG_ATM_IA)		+= iphase.o suni.o
 obj-$(CONFIG_ATM_FORE200E)	+= fore_200e.o
drivers/atm/ambassador.c deleted +0 -2400

2,400 lines not on this page · raw message

drivers/atm/ambassador.h deleted +0 -648

548 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.34.1

Part of the diff is not shown here. View the raw message.

Acked-by on v1 1/1
#1 lore raw
Quoted 26 lines · Jakub Kicinski

The driver for ATM Ambassador devices spews build warnings on microblaze. The virt_to_bus() calls discard the volatile keyword. The right thing to do would be to migrate this driver to a modern DMA API but it seems unlikely anyone is actually using it. There had been no fixes or functional changes here since the git era begun.

In fact it sounds like the FW loading was broken from 2008 'til 2012 - see commit fcdc90b025e6 ("atm: forever loop loading ambassador firmware").

Let's remove this driver, there isn't much changing in the APIs, if users come forward we can apologize and revert.

---
CC: [email protected],[email protected]
CC: Jesper Juhl <[email protected]>
CC: Dan Carpenter <[email protected]>
CC: Chas Williams <[email protected]> # ATM
CC: [email protected]
CC: [email protected] # MIPS
CC: [email protected]
CC: [email protected] # dunno why, get_maintainer

Quoted 7 lines
---
 arch/mips/configs/gpr_defconfig  |    1 -
 arch/mips/configs/mtx1_defconfig |    1 -
 drivers/atm/Kconfig              |   25 -
 drivers/atm/Makefile             |    1 -
 drivers/atm/ambassador.c         | 2400 ------------------------------
 drivers/atm/ambassador.h         |  648 --------
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Jakub Kicinski
Quoted 25 lines · Jakub Kicinski

The driver for ATM Ambassador devices spews build warnings on microblaze. The virt_to_bus() calls discard the volatile keyword. The right thing to do would be to migrate this driver to a modern DMA API but it seems unlikely anyone is actually using it. There had been no fixes or functional changes here since the git era begun.

In fact it sounds like the FW loading was broken from 2008 'til 2012 - see commit fcdc90b025e6 ("atm: forever loop loading ambassador firmware").

Let's remove this driver, there isn't much changing in the APIs, if users come forward we can apologize and revert.

---
CC: [email protected],[email protected]
CC: Jesper Juhl <[email protected]>
CC: Dan Carpenter <[email protected]>
CC: Chas Williams <[email protected]> # ATM
CC: [email protected]
CC: [email protected] # MIPS
CC: [email protected]
CC: [email protected] # dunno why, get_maintainer

Quoted 10 lines
---
 arch/mips/configs/gpr_defconfig  |    1 -
 arch/mips/configs/mtx1_defconfig |    1 -
 drivers/atm/Kconfig              |   25 -
 drivers/atm/Makefile             |    1 -
 drivers/atm/ambassador.c         | 2400 ------------------------------
 drivers/atm/ambassador.h         |  648 --------
 6 files changed, 3076 deletions(-)
 delete mode 100644 drivers/atm/ambassador.c
 delete mode 100644 drivers/atm/ambassador.h
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
#3 lore raw
Quoted 8 lines · Thomas Bogendoerfer
Quoted 7 lines · Jakub Kicinski

The driver for ATM Ambassador devices spews build warnings on microblaze. The virt_to_bus() calls discard the volatile keyword. The right thing to do would be to migrate this driver to a modern DMA API but it seems unlikely anyone is actually using it. There had been no fixes or functional changes here since the git era begun.

Quoted 7 lines
Quoted 7 lines

In fact it sounds like the FW loading was broken from 2008 'til 2012 - see commit fcdc90b025e6 ("atm: forever loop loading ambassador firmware").

Let's remove this driver, there isn't much changing in the APIs, if users come forward we can apologize and revert.

I contributed this driver (and the horizon one) over 20 years ago. I doubt the hardware has been used in 20 years.

I just spoke today with David Miller about finally removing them and found that you've already started.

Please remove horizon as well, analogously. Thanks!

Quoted 22 lines
Quoted 11 lines

---
CC: [email protected],[email protected]
CC: Jesper Juhl <[email protected]>
CC: Dan Carpenter <[email protected]>
CC: Chas Williams <[email protected]> # ATM
CC: [email protected]
CC: [email protected] # MIPS
CC: [email protected]
CC: [email protected] # dunno why, get_maintainer

Quoted 10 lines
---
 arch/mips/configs/gpr_defconfig  |    1 -
 arch/mips/configs/mtx1_defconfig |    1 -
 drivers/atm/Kconfig              |   25 -
 drivers/atm/Makefile             |    1 -
 drivers/atm/ambassador.c         | 2400 ------------------------------
 drivers/atm/ambassador.h         |  648 --------
 6 files changed, 3076 deletions(-)
 delete mode 100644 drivers/atm/ambassador.c
 delete mode 100644 drivers/atm/ambassador.h
Quoted 2 lines
#4 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Quoted 8 lines · On Tue, 5 Apr 2022 21:16:27 -0700 you wrote:

The driver for ATM Ambassador devices spews build warnings on microblaze. The virt_to_bus() calls discard the volatile keyword. The right thing to do would be to migrate this driver to a modern DMA API but it seems unlikely anyone is actually using it. There had been no fixes or functional changes here since the git era begun.

[...]

Here is the summary with links:
- [net-next] net: atm: remove the ambassador driver

    https://git.kernel.org/netdev/net-next/c/e05afd0848f8

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html