Skip to contentSkip to conversation

DT changes for Embedded USB Debugger(EUD)

PATCH New Souradeep Chowdhury 2 participants 4 messages Apr 6, 2022 – Apr 8, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover DT changes for Embedded USB Debugger(EUD)

This patch contains the DT changes for EUD from the QCOM tree. The DT changes have been reverted from USB tree to avoid conflicts. The DT changes for EUD should go through the QCOM tree.

Souradeep Chowdhury (2):
arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector
arm64: dts: qcom: sc7280: Set the default dr_mode for usb2

 arch/arm64/boot/dts/qcom/sc7280-idp.dts |  2 +-
 arch/arm64/boot/dts/qcom/sc7280.dtsi    | 36 +++++++++++++++++++++++++++++++++
 2 files changed, 37 insertions(+), 1 deletion(-)

--
2.7.4

#1 lore raw

PATCH 1/2 arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector

Add the Embedded USB Debugger(EUD) device tree node. The node contains EUD base register region and EUD mode manager register regions along with the interrupt entry. Also add the typec connector node for EUD which is attached to EUD node via port. EUD is also attached to DWC3 node via port. Also add the role-switch property to dwc3 node.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
arch/arm64/boot/dts/qcom/sc7280.dtsi +36 -0
index 3572399..baf1653 100644
@@ -2592,6 +2592,12 @@
 				phys = <&usb_2_hsphy>;
 				phy-names = "usb2-phy";
 				maximum-speed = "high-speed";
+				usb-role-switch;
+				port {
+					usb2_role_switch: endpoint {
+						remote-endpoint = <&eud_ep>;
+					};
+				};
 			};
 		};
 
@@ -2633,6 +2639,36 @@
 			interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
+		eud: eud@88e0000 {
+			compatible = "qcom,sc7280-eud","qcom,eud";
+			reg = <0 0x88e0000 0 0x2000>,
+			      <0 0x88e2000 0 0x1000>;
+			interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
+			ports {
+				port@0 {
+					eud_ep: endpoint {
+						remote-endpoint = <&usb2_role_switch>;
+					};
+				};
+				port@1 {
+					eud_con: endpoint {
+						remote-endpoint = <&con_eud>;
+					};
+				};
+			};
+		};
+
+		eud_typec: connector {
+			compatible = "usb-c-connector";
+			ports {
+				port@0 {
+					con_eud: endpoint {
+						remote-endpoint = <&eud_con>;
+					};
+				};
+			};
+		};
+
 		nsp_noc: interconnect@a0c0000 {
 			reg = <0 0x0a0c0000 0 0x10000>;
 			compatible = "qcom,sc7280-nsp-noc";
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/2 arm64: dts: qcom: sc7280: Set the default dr_mode for usb2

In reply to Souradeep Chowdhury

Set the default dr_mode for usb2 node to "otg" to enable role-switch for EUD(Embedded USB Debugger) connector node.

---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +1 -1
index a7be133..6d3ff80 100644
@@ -90,7 +90,7 @@
 };
 
 &usb_2_dwc3 {
-	dr_mode = "host";
+	dr_mode = "otg";
 };
 
 &usb_2_hsphy {
Signature · 1 line
2.7.4
#3 lore raw
In reply to Souradeep Chowdhury
This series was applied to qcom/linux.git (for-next) by Greg Kroah-Hartman <[email protected]>:

Hello:

This series was applied to qcom/linux.git (for-next) by Greg Kroah-Hartman <[email protected]>:

Quoted 10 lines · On Wed, 6 Apr 2022 15:03:46 +0530 you wrote:

This patch contains the DT changes for EUD from the QCOM tree. The DT changes have been reverted from USB tree to avoid conflicts. The DT changes for EUD should go through the QCOM tree.

Souradeep Chowdhury (2):
arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector
arm64: dts: qcom: sc7280: Set the default dr_mode for usb2

[...]

Here is the summary with links:
- [V0,1/2] arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector

    https://git.kernel.org/qcom/c/a0c68e493007

- [V0,2/2] arm64: dts: qcom: sc7280: Set the default dr_mode for usb2 (no matching commit)

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html