Skip to contentSkip to conversation

sched/fair: Fix decision matrix of type misfit_task

PATCH In review zgpeng 2 participants 2 messages Apr 24, 2022 – Apr 25, 2022 Scheduler

lore
Share & tools
lore

zgpeng

author
#0 lore raw

PATCH 1/1 sched/fair: Fix decision matrix of type misfit_task

When the group type of the busiest is misfit_task, as long as the type of the local group is not equal to has_spare, those situation already filtered while updating statistics.

---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +1 -1
index d4bd299..b8c67e7 100644
@@ -9495,7 +9495,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
  * busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
  * has_spare        nr_idle   balanced   N/A    N/A  balanced   balanced
  * fully_busy       nr_idle   nr_idle    N/A    N/A  balanced   balanced
- * misfit_task      force     N/A        N/A    N/A  force      force
+ * misfit_task      force     N/A        N/A    N/A  N/A        N/A
  * asym_packing     force     force      N/A    N/A  force      force
  * imbalanced       force     force      N/A    N/A  force      force
  * overloaded       force     force      N/A    N/A  force      avg_load
Signature · 1 line
2.9.5
#1 lore raw
Quoted 16 lines · zgpeng

When the group type of the busiest is misfit_task, as long as the type of the local group is not equal to has_spare, those situation already filtered while updating statistics.

---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +0 -0
index d4bd299..b8c67e7 100644

kernel/sched/fair.c static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s · line 9501

Quoted 8 lines
kernel/sched/fair.c +1 -1
@@ -9495,7 +9495,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
  * busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
  * has_spare        nr_idle   balanced   N/A    N/A  balanced   balanced
  * fully_busy       nr_idle   nr_idle    N/A    N/A  balanced   balanced
- * misfit_task      force     N/A        N/A    N/A  force      force
+ * misfit_task      force     N/A        N/A    N/A  N/A        N/A
  * asym_packing     force     force      N/A    N/A  force      force
  * imbalanced       force     force      N/A    N/A  force      force
  * overloaded       force     force      N/A    N/A  force      avg_load

This issue has been sorted. Patch from Tao Zhou <[email protected]> is already on tip sched/core.

https://lkml.kernel.org/r/165062326028.4207.17060214721845047142.tip-bot2@tip-bot2