net: hns: Add missing fwnode_handle_put in hns_mac_init
Subsystems (3)
PATCH 1/1 net: hns: Add missing fwnode_handle_put in hns_mac_init
In one of the error paths of the device_for_each_child_node() loop in hns_mac_init, add missing call to fwnode_handle_put.
Signed-off-by Peng Wu <[email protected]>
--- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c +5 -1
@@ -1065,19 +1065,23 @@ int hns_mac_init(struct dsaf_device *dsaf_dev)device_for_each_child_node (dsaf_dev->dev, child) { ret =fwnode_property_read_u32 (child,"reg" , &port_id);if (ret) { +fwnode_handle_put (child);dev_err (dsaf_dev->dev,"get reg fail, ret=%d!\n" , ret);return ret; }if (port_id >= max_port_num) { +fwnode_handle_put (child);dev_err (dsaf_dev->dev,"reg(%u) out of range!\n" , port_id);return -EINVAL ; } mac_cb =devm_kzalloc (dsaf_dev->dev,sizeof (*mac_cb),GFP_KERNEL ); -if (!mac_cb) +if (!mac_cb) { +fwnode_handle_put (child);return -ENOMEM ; + } mac_cb->fw_port = child; mac_cb->mac_id = (u8 )port_id; dsaf_dev->mac_cb[port_id] = mac_cb;
Signature · 1 line
2.17.1
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 7 lines · On Thu, 21 Apr 2022 05:53:44 +0000 you wrote:
In one of the error paths of the
device_for_each_child_node()loop inhns_mac_init, add missing call tofwnode_handle_put.Signed-off-by Peng Wu <[email protected]>--- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Here is the summary with links:
- net: hns: Add missing fwnode_handle_put in hns_mac_init
https://git.kernel.org/netdev/net/c/e85f8a9f1625
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html