bpf: use bpf_prog_run_array_cg_flags everywhere
Subsystems (4)
PATCH v2 1/1 bpf: use bpf_prog_run_array_cg_flags everywhere
Rename bpf_prog_run_array_cg_flags to bpf_prog_run_array_cg and use it everywhere. check_return_code already enforces sane return ranges for all cgroup types. (only egress and bind hooks have uncanonical return ranges, the rest is using [0, 1])
No functional changes.
v2:
- 'func_ret & 1' under explicit test (Andrii & Martin)
--- include/linux/bpf-cgroup.h | 8 ++--- kernel/bpf/cgroup.c | 72 +++++++++++++------------------------- 2 files changed, 26 insertions(+), 54 deletions(-)
include/linux/bpf-cgroup.h +2 -6
@@ -225,24 +225,20 @@ static inline bool cgroup_bpf_sock_enabled(struct sock *sk,#define BPF_CGROUP_RUN_SA_PROG (sk, uaddr, atype) \ ({ \ - u32 __unused_flags; \ int __ret = 0; \ if (cgroup_bpf_enabled(atype)) \ __ret = __cgroup_bpf_run_filter_sock_addr(sk, uaddr, atype, \ - NULL, \ - &__unused_flags); \ + NULL, NULL); \ __ret; \ })#define BPF_CGROUP_RUN_SA_PROG_LOCK (sk, uaddr, atype, t_ctx) \ ({ \ - u32 __unused_flags; \ int __ret = 0; \ if (cgroup_bpf_enabled(atype)) { \ lock_sock(sk); \ __ret = __cgroup_bpf_run_filter_sock_addr(sk, uaddr, atype, \ - t_ctx, \ - &__unused_flags); \ + t_ctx, NULL); \ release_sock(sk); \ } \ __ret; \
kernel/bpf/cgroup.c +24 -48
154 lines not on this page · raw message
Signature · 1 line
2.36.0.rc2.479.g8af0fa9b8e-goog
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 8 lines · On Mon, 25 Apr 2022 15:04:48 -0700 you wrote:
Rename
bpf_prog_run_array_cg_flagstobpf_prog_run_array_cgand use it everywhere.check_return_codealready enforces sane return ranges for all cgroup types. (only egress and bind hooks have uncanonical return ranges, the rest is using [0, 1])No functional changes.
[...]
Here is the summary with links:
- [bpf-next,v2] bpf: use bpf_prog_run_array_cg_flags everywhere
https://git.kernel.org/bpf/bpf-next/c/d9d31cf88702
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html