Skip to contentSkip to conversation

net: phy: LAN937x: add interrupt support for link detection

PATCH Applied Arun Ramadoss 3 participants 4 messages Apr 23, 2022 – Apr 26, 2022

Subsystems (4)
lore
Share & tools
lore

Arun Ramadoss

author maintainer
#0 lore raw

PATCH 1/1 net: phy: LAN937x: add interrupt support for link detection

Added the config_intr and handle_interrupt for the LAN937x phy which is same as the LAN87xx phy.

---
 drivers/net/phy/microchip_t1.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/microchip_t1.c +2 -0
index 796fbcb7dafe..d4c93d59bc53 100644
@@ -792,6 +792,8 @@ static struct phy_driver microchip_t1_phy_driver[] = {
 		.flags          = PHY_POLL_CABLE_TEST,
 		.features	= PHY_BASIC_T1_FEATURES,
 		.config_init	= lan87xx_config_init,
+		.config_intr    = lan87xx_phy_config_intr,
+		.handle_interrupt = lan87xx_handle_interrupt,
 		.suspend	= genphy_suspend,
 		.resume		= genphy_resume,
 		.config_aneg    = lan87xx_config_aneg,

base-commit: cfc1d91a7d78cf9de25b043d81efcc16966d55b3

Signature · 1 line
2.33.0
author maintainer
#2 lore raw
Quoted 8 lines · Andrew Lunn

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 4 lines · Arun Ramadoss

Added the config_intr and handle_interrupt for the LAN937x phy which is
same as the LAN87xx phy.

Quoted 8 lines
Quoted 1 line

While looking at the code, i noticed LAN87XX has PHY_POLL_CABLE_TEST where as LAN937X does not. Is this correct?

Andrew

Yes Andrew, When I added the LAN937x support in the below patch I added the call back for the cable_test_start and cable_test_get_status and forgot to add the PHY_POLL_CABLE_TEST flag.

https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/

I initially posted the patch for adding flag in net-next, but you have suggested to me sent the bug fix patch for this. I sent the bug fix patch for adding the flag.

https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/

#3 lore raw
In reply to Arun Ramadoss
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Quoted 9 lines · On Sat, 23 Apr 2022 21:17:27 +0530 you wrote:

Added the config_intr and handle_interrupt for the LAN937x phy which is same as the LAN87xx phy.

---
 drivers/net/phy/microchip_t1.c | 2 ++
 1 file changed, 2 insertions(+)

[...]

Here is the summary with links:
- [net-next] net: phy: LAN937x: add interrupt support for link detection

    https://git.kernel.org/netdev/net-next/c/fb0a43f5bd45

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html