net: dsa: mv88e6xxx: Fix port_hidden_wait to account for port_base_addr
Subsystems (4)
PATCH v3 1/1 net: dsa: mv88e6xxx: Fix port_hidden_wait to account for port_base_addr
The other port_hidden functions rely on the port_read/port_write functions to access the hidden control port. These functions apply the offset for port_base_addr where applicable. Update port_hidden_wait to use the port_wait_bit so that port_base_addr offsets are accounted for when waiting for the busy bit to change.
Without the offset the port_hidden_wait function would timeout on devices that have a non-zero port_base_addr (e.g. MV88E6141), however devices that have a zero port_base_addr would operate correctly (e.g. MV88E6390).
---
Changes in v2:
- Add Fixes
Changes in v3:
- Changed Fixes to more recent commit where the bug is present
--- drivers/net/dsa/mv88e6xxx/port_hidden.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/dsa/mv88e6xxx/port_hidden.c +3 -2
@@ -40,8 +40,9 @@ int mv88e6xxx_port_hidden_wait(struct mv88e6xxx_chip *chip) {int bit =__bf_shf (MV88E6XXX_PORT_RESERVED_1A_BUSY ); -return mv88e6xxx_wait_bit (chip,MV88E6XXX_PORT_RESERVED_1A_CTRL_PORT , -MV88E6XXX_PORT_RESERVED_1A , bit,0 ); +return mv88e6xxx_port_wait_bit (chip, +MV88E6XXX_PORT_RESERVED_1A_CTRL_PORT , +MV88E6XXX_PORT_RESERVED_1A , bit,0 ); } int mv88e6xxx_port_hidden_read(struct mv88e6xxx_chip *chip, int block, int port,
---
2.35.2
This patch was applied to netdev/net.git (master) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <[email protected]>:
Quoted 6 lines · On Mon, 25 Apr 2022 07:04:54 +0000 you wrote:
The other
port_hiddenfunctions rely on the port_read/port_write functions to access the hidden control port. These functions apply the offset forport_base_addrwhere applicable. Updateport_hidden_waitto use theport_wait_bitso thatport_base_addroffsets are accounted for when waiting for the busy bit to change.
Quoted 6 lines
Without the offset the
port_hidden_waitfunction would timeout on devices that have a non-zeroport_base_addr(e.g. MV88E6141), however devices that have a zeroport_base_addrwould operate correctly (e.g. MV88E6390).[...]
Here is the summary with links:
- [v3] net: dsa: mv88e6xxx: Fix port_hidden_wait to account for port_base_addr
https://git.kernel.org/netdev/net/c/24cbdb910bb6
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html