net: tls: fix async vs NIC crypto offload
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 net: tls: fix async vs NIC crypto offload
When NIC takes care of crypto (or the record has already been decrypted) we forget to update darg->async. ->async is supposed to mean whether record is async capable on input and whether record has been queued for async crypto on output.
--- net/tls/tls_sw.c | 2 ++ 1 file changed, 2 insertions(+)
net/tls/tls_sw.c +2 -0
@@ -1562,6 +1562,7 @@ static int decrypt_skb_update(struct sock *sk, struct sk_buff *skb,if (tlm->decrypted) { darg->zc = false; + darg->async = false;return 0 ; }
@@ -1572,6 +1573,7 @@ static int decrypt_skb_update(struct sock *sk, struct sk_buff *skb,if (err >0 ) { tlm->decrypted =1 ; darg->zc = false; + darg->async = false; goto decrypt_done; } }
Signature · 1 line
2.34.1
Quoted 9 lines · Jakub Kicinski
When NIC takes care of crypto (or the record has already been decrypted) we forget to update
darg->async. ->async is supposed to mean whether record is async capable on input and whether record has been queued for async crypto on output.Reported-by Gal Pressman <[email protected]>Fixes 3547a1f9d988 ("tls: rx: use async as an in-out argument")Signed-off-by Jakub Kicinski <[email protected]>
Thanks Jakub!
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 11 lines · On Mon, 25 Apr 2022 16:33:09 -0700 you wrote:
When NIC takes care of crypto (or the record has already been decrypted) we forget to update
darg->async. ->async is supposed to mean whether record is async capable on input and whether record has been queued for async crypto on output.Reported-by Gal Pressman <[email protected]>Fixes 3547a1f9d988 ("tls: rx: use async as an in-out argument")Signed-off-by Jakub Kicinski <[email protected]>[...]
Here is the summary with links:
- [net-next] net: tls: fix async vs NIC crypto offload
https://git.kernel.org/netdev/net-next/c/c706b2b5ed74
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html