Skip to contentSkip to conversation

net: fec: add missing of_node_put() in fec_enet_init_stop_mode()

PATCH Applied Yang Yingliang 2 participants 2 messages Apr 26, 2022 – Apr 28, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: fec: add missing of_node_put() in fec_enet_init_stop_mode()

Put device node in error path in fec_enet_init_stop_mode().

Fixes 8a448bf832af ("net: ethernet: fec: move GPR register offset and bit into DT")
---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/fec_main.c +1 -1
index 11227f51404c..9f33ec838b52 100644
@@ -3731,7 +3731,7 @@ static int fec_enet_init_stop_mode(struct fec_enet_private *fep,
 					 ARRAY_SIZE(out_val));
 	if (ret) {
 		dev_dbg(&fep->pdev->dev, "no stop mode property\n");
-		return ret;
+		goto out;
 	}
 
 	fep->stop_gpr.gpr = syscon_node_to_regmap(gpr_np);
Signature · 1 line
2.25.1
#1 lore raw
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 7 lines · On Tue, 26 Apr 2022 20:52:31 +0800 you wrote:

Put device node in error path in fec_enet_init_stop_mode().

Fixes 8a448bf832af ("net: ethernet: fec: move GPR register offset and bit into DT")
---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- net: fec: add missing of_node_put() in fec_enet_init_stop_mode()

    https://git.kernel.org/netdev/net/c/d2b52ec056d5

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html