net: stmmac: disable Split Header (SPH) for Intel platforms
Subsystems (5)
PATCH v2 1/1 net: stmmac: disable Split Header (SPH) for Intel platforms
Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation of Split Header (SPH) feature is not supported for Ipv4 fragmented packet. This SPH limitation will cause ping failure when the packets size exceed the MTU size. For example, the issue happens once the basic ping packet size is larger than the configured MTU size and the data is lost inside the fragmented packet, replaced by zeros/corrupted values, and leads to ping fail.
So, disable the Split Header for Intel platforms.
v2: Add fixes tag in commit message.
in XGMAC cores")
--- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 + drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- include/linux/stmmac.h | 1 + 3 files changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c +1 -0
@@ -454,6 +454,7 @@ static int intel_mgbe_common_data(struct pci_dev *pdev, plat->has_gmac4 =1 ; plat->force_sf_dma_mode =0 ; plat->tso_en =1 ; + plat->sph_disable =1 ;/* Multiplying factor to the clk_eee_i clock time * period to make it closer to 100 ns. This value
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +1 -1
@@ -7021,7 +7021,7 @@ int stmmac_dvr_probe(struct device *device,dev_info (priv->device,"TSO feature enabled\n" ); } -if (priv->dma_cap.sphen) { +if (priv->dma_cap.sphen && !priv->plat->sph_disable) { ndev->hw_features |=NETIF_F_GRO ; priv->sph_cap = true; priv->sph = priv->sph_cap;
include/linux/stmmac.h +1 -0
@@ -270,5 +270,6 @@ struct plat_stmmacenet_data {int msi_rx_base_vec;int msi_tx_base_vec;bool use_phy_wol; + bool sph_disable; };#endif
Signature · 1 line
2.25.1
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 9 lines · On Fri, 29 Apr 2022 19:58:07 +0800 you wrote:
Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation of Split Header (SPH) feature is not supported for Ipv4 fragmented packet. This SPH limitation will cause ping failure when the packets size exceed the MTU size. For example, the issue happens once the basic ping packet size is larger than the configured MTU size and the data is lost inside the fragmented packet, replaced by zeros/corrupted values, and leads to ping fail.
[...]
Here is the summary with links:
- [net,v2,1/1] net: stmmac: disable Split Header (SPH) for Intel platforms
https://git.kernel.org/netdev/net/c/47f753c1108e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html