net: phy: add comments for LAN8742 phy support
Subsystems (3)
cover net: phy: add comments for LAN8742 phy support
Add comments for 0xfffffff2 phy ID mask for the LAN8742 and the LAN88xx, explaining that they can coexist and allow future hardware revisions. Also add one missing tab in smsc.c.
Yuiko Oshino (2):
net: phy: microchip: add comments for the modified LAN88xx phy ID
mask.
net: phy: smsc: add comments for the LAN8742 phy ID mask.
drivers/net/phy/microchip.c | 4 ++++ drivers/net/phy/smsc.c | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1
PATCH 1/2 net: phy: microchip: add comments for the modified LAN88xx phy ID mask.
add comments for the updated LAN88xx phy ID mask in the previous patch.
--- drivers/net/phy/microchip.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/phy/microchip.c +4 -0
@@ -345,6 +345,10 @@ static int lan88xx_config_aneg(struct phy_device *phydev)static struct phy_driver microchip_phy_driver[] = { { .phy_id =0x0007c132 , +/* This mask (0xfffffff2) is to differentiate from +* LAN8742 (phy_id 0x0007c130 and 0x0007c131) +* and allows future phy_id revisions. +*/ .phy_id_mask =0xfffffff2 , .name ="Microchip LAN88xx" ,
Signature · 1 line
2.25.1
PATCH 2/2 net: phy: smsc: add comments for the LAN8742 phy ID mask.
In reply to Yuiko Oshinoadd comments for the LAN8742 phy ID mask in the previous patch. add one missing tab in the LAN8742 phy ID line.
--- drivers/net/phy/smsc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/net/phy/smsc.c +5 -1
@@ -484,7 +484,11 @@ static struct phy_driver smsc_phy_driver[] = { .suspend = genphy_suspend, .resume = genphy_resume, }, { - .phy_id = 0x0007c130, /* 0x0007c130 and 0x0007c131 */ + .phy_id = 0x0007c130, /* 0x0007c130 and 0x0007c131 */ +/* This mask (0xfffffff2) is to differentiate from +* LAN88xx (phy_id 0x0007c132) +* and allows future phy_id revisions. +*/ .phy_id_mask = 0xfffffff2, .name = "Microchip LAN8742",
Signature · 1 line
2.25.1
This series was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Mon, 9 May 2022 11:58:02 -0700 you wrote:
Add comments for
0xfffffff2phy ID mask for the LAN8742 and the LAN88xx, explaining that they can coexist and allow future hardware revisions. Also add one missing tab insmsc.c.Yuiko Oshino (2):
net: phy: microchip: add comments for the modified LAN88xx phy ID
mask.
net: phy: smsc: add comments for the LAN8742 phy ID mask.[...]
Here is the summary with links:
- [net-next,1/2] net: phy: microchip: add comments for the modified LAN88xx phy ID mask.
https://git.kernel.org/netdev/net-next/c/70a40ecfcb7d - [net-next,2/2] net: phy: smsc: add comments for the LAN8742 phy ID mask. https://git.kernel.org/netdev/net-next/c/b2be075139fa
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html