Skip to contentSkip to conversation

selftests/bpf: add missed ima_setup.sh in Makefile

PATCH Applied Hangbin Liu 3 participants 3 messages May 16, 2022 – May 19, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 selftests/bpf: add missed ima_setup.sh in Makefile

When build bpf test and install it to another folder, e.g.

make -j10 install -C tools/testing/selftests/ TARGETS="bpf" \
SKIP_TARGETS="" INSTALL_PATH=/tmp/kselftests

The ima_setup.sh is missed in target folder, which makes test_ima failed.

Fix it by adding ima_setup.sh to TEST_PROGS_EXTENDED.

Fixes 34b82d3ac105 ("bpf: Add a selftest for bpf_ima_inode_hash")

---
v3: rebase code to latest bpf-next, and drop the second patch
v2: fix subject prefix from net to bpf-next

---
 tools/testing/selftests/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/Makefile +1 -1
index 6bbc03161544..74dda54e88c4 100644
@@ -75,7 +75,7 @@ TEST_PROGS := test_kmod.sh \
 	test_xsk.sh
 
 TEST_PROGS_EXTENDED := with_addr.sh \
-	with_tunnels.sh \
+	with_tunnels.sh ima_setup.sh \
 	test_xdp_vlan.sh test_bpftool.py
 
 # Compile but not part of 'make run_tests'
Signature · 1 line
2.35.1
Acked-by on v3 1/1
#1 lore raw
Quoted 11 lines · Hangbin Liu

When build bpf test and install it to another folder, e.g.

   make -j10 install -C tools/testing/selftests/ TARGETS="bpf" \
	SKIP_TARGETS="" INSTALL_PATH=/tmp/kselftests

The ima_setup.sh is missed in target folder, which makes test_ima failed.

Fix it by adding ima_setup.sh to TEST_PROGS_EXTENDED.

Fixes 34b82d3ac105 ("bpf: Add a selftest for bpf_ima_inode_hash")
#2 lore raw
In reply to Hangbin Liu
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Quoted 8 lines · On Mon, 16 May 2022 12:00:20 +0800 you wrote:

When build bpf test and install it to another folder, e.g.

make -j10 install -C tools/testing/selftests/ TARGETS="bpf" \
SKIP_TARGETS="" INSTALL_PATH=/tmp/kselftests

The ima_setup.sh is missed in target folder, which makes test_ima failed.

[...]

Here is the summary with links:
- [PATCHv3,bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile

    https://git.kernel.org/bpf/bpf-next/c/70a1b25326dd

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html