net: wwan: t7xx: Fix smatch errors
Ricardo Martinez
reviewerPATCH 1/1 net: wwan: t7xx: Fix smatch errors
t7xx_request_irq() error: uninitialized symbol 'ret'.
t7xx_core_hk_handler() error: potentially dereferencing uninitialized 'event'. If the condition to enter the loop that waits for the handshake event is false on the first iteration then the uninitialized 'event' will be dereferenced, fix this by initializing 'event' to NULL.
t7xx_port_proxy_recv_skb() warn: variable dereferenced before check 'skb'. No need to check skb at t7xx_port_proxy_recv_skb() since we know it is always called with a valid skb by t7xx_cldma_gpd_rx_from_q().
--- drivers/net/wwan/t7xx/t7xx_modem_ops.c | 4 ++-- drivers/net/wwan/t7xx/t7xx_pci.c | 2 +- drivers/net/wwan/t7xx/t7xx_port_proxy.c | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-)
drivers/net/wwan/t7xx/t7xx_modem_ops.c +2 -2
@@ -458,9 +458,9 @@ static void t7xx_core_hk_handler(struct t7xx_modem *md, struct t7xx_fsm_ctl *ctlenum t7xx_fsm_event_state event_id, enum t7xx_fsm_event_state err_detect) { + struct t7xx_fsm_event *event = NULL, *event_next;struct t7xx_sys_info *core_info = &md->core_md;struct device *dev = &md->t7xx_dev->pdev->dev; -struct t7xx_fsm_event *event, *event_next;unsigned long flags;int ret;
@@ -493,7 +493,7 @@ static void t7xx_core_hk_handler(struct t7xx_modem *md, struct t7xx_fsm_ctl *ctl goto err_free_event; } -if (ctl->exp_flg) +if (!event || ctl->exp_flg) goto err_free_event; ret =t7xx_parse_host_rt_data (ctl, core_info, dev, event->data, event->length);
drivers/net/wwan/t7xx/t7xx_pci.c +1 -1
@@ -568,7 +568,7 @@ static const struct dev_pm_ops t7xx_pci_pm_ops = {static int t7xx_request_irq (struct pci_dev *pdev) {struct t7xx_pci_dev *t7xx_dev; -int ret, i; +int ret =0 , i; t7xx_dev =pci_get_drvdata (pdev);
drivers/net/wwan/t7xx/t7xx_port_proxy.c +0 -3
@@ -350,9 +350,6 @@ static int t7xx_port_proxy_recv_skb(struct cldma_queue *queue, struct sk_buff *su16 seq_num, channel;int ret; -if (!skb) -return -EINVAL ; - channel =FIELD_GET (CCCI_H_CHN_FLD ,le32_to_cpu (ccci_h->status));if (t7xx_fsm_get_md_state (ctl) ==MD_STATE_INVALID ) {dev_err_ratelimited (dev,"Packet drop on channel 0x%x, modem not ready\n" , channel);
Signature · 1 line
2.25.1
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 18 May 2022 12:55:29 -0700 you wrote:
t7xx_request_irq()error: uninitialized symbol 'ret'.
t7xx_core_hk_handler()error: potentially dereferencing uninitialized 'event'. If the condition to enter the loop that waits for the handshake event is false on the first iteration then the uninitialized 'event' will be dereferenced, fix this by initializing 'event' to NULL.[...]
Here is the summary with links:
- [net-next,1/1] net: wwan: t7xx: Fix smatch errors
https://git.kernel.org/netdev/net-next/c/86afd5a0e78e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html