selftests/bpf: fix stacktrace_build_id with missing kprobe/urandom_read
Subsystems (5)
Song Liu
reviewerPATCH 1/1 selftests/bpf: fix stacktrace_build_id with missing kprobe/urandom_read
Kernel function urandom_read is replaced with urandom_read_iter. Therefore, kprobe on urandom_read is not working any more:
[root@eth50-1 bpf]# ./test_progs -n 161 test_stacktrace_build_id:PASS:skel_open_and_load 0 nsec
libbpf: kprobe perf_event_open() failed: No such file or directory
libbpf: prog 'oncpu': failed to create kprobe 'urandom_read+0x0' \
perf event: No such file or directory
libbpf: prog 'oncpu': failed to auto-attach: -2 test_stacktrace_build_id:FAIL:attach_tp err -2
161 stacktrace_build_id:FAIL
Fix this by replacing urandom_read with urandom_read_iter in the test.
--- tools/testing/selftests/bpf/progs/test_stacktrace_build_id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/progs/test_stacktrace_build_id.c +1 -1
@@ -39,7 +39,7 @@ struct {__type (value, stack_trace_t); } stack_amap SEC(".maps"); -SEC("kprobe/urandom_read") +SEC("kprobe/urandom_read_iter")int oncpu (struct pt_regs *args) {__u32 max_len =sizeof (struct bpf_stack_build_id )
Signature · 1 line
2.30.2
Quoted 37 lines · Song Liu
Kernel function
urandom_readis replaced withurandom_read_iter. Therefore, kprobe onurandom_readis not working any more:[root@eth50-1 bpf]# ./test_progs -n 161 test_stacktrace_build_id:PASS:skel_open_and_load 0 nsec
libbpf: kprobeperf_event_open()failed: No such file or directory
libbpf: prog 'oncpu': failed to create kprobe 'urandom_read+0x0' \
perf event: No such file or directory
libbpf: prog 'oncpu': failed to auto-attach: -2 test_stacktrace_build_id:FAIL:attach_tp err -2
161 stacktrace_build_id:FAILFix this by replacing
urandom_readwithurandom_read_iterin the test.Fixes 1b388e7765f2 ("random: convert to using fops->read_iter()")Reported-by Mykola Lysenko <[email protected]>Signed-off-by Song Liu <[email protected]>--- tools/testing/selftests/bpf/progs/test_stacktrace_build_id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/bpf/progs/test_stacktrace_build_id.c +1
-1@@ -39,7 +39,7 @@ struct {__type (value, stack_trace_t); } stack_amap SEC(".maps"); -SEC("kprobe/urandom_read") +SEC("kprobe/urandom_read_iter")int oncpu (struct pt_regs *args) {__u32 max_len =sizeof (struct bpf_stack_build_id )Signature · 1 line
2.30.2
This patch was applied to bpf/bpf.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <[email protected]>:
Quoted 12 lines · On Thu, 26 May 2022 12:16:08 -0700 you wrote:
Kernel function
urandom_readis replaced withurandom_read_iter. Therefore, kprobe onurandom_readis not working any more:[root@eth50-1 bpf]# ./test_progs -n 161 test_stacktrace_build_id:PASS:skel_open_and_load 0 nsec
libbpf: kprobeperf_event_open()failed: No such file or directory
libbpf: prog 'oncpu': failed to create kprobe 'urandom_read+0x0' \
perf event: No such file or directory
libbpf: prog 'oncpu': failed to auto-attach: -2 test_stacktrace_build_id:FAIL:attach_tp err -2
161 stacktrace_build_id:FAIL
Quoted 1 line
[...]
Here is the summary with links:
- [bpf] selftests/bpf: fix stacktrace_build_id with missing kprobe/urandom_read
https://git.kernel.org/bpf/bpf/c/59ed76fe2f98
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html