Skip to contentSkip to conversation

net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()

PATCH Applied Dan Carpenter 3 participants 3 messages May 31, 2022 – Jun 1, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()

The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return false on failure. It should not return negatives because that means succes/true.

Fixes fcb6aa86532c ("act_ct: Support GRE offload")
---
 net/sched/act_ct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/sched/act_ct.c +1 -1
index 8af9d6e5ba61..e013253b10d1 100644
@@ -548,7 +548,7 @@ tcf_ct_flow_table_fill_tuple_ipv6(struct sk_buff *skb,
 		break;
 #endif
 	default:
-		return -1;
+		return false;
 	}
 
 	if (ip6h->hop_limit <= 1)
Signature · 1 line
2.35.1
#2 lore raw
In reply to Dan Carpenter
This patch was applied to netdev/net.git (master) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Tue, 31 May 2022 15:10:05 +0300 you wrote:

The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return false on failure. It should not return negatives because that means succes/true.

Fixes fcb6aa86532c ("act_ct: Support GRE offload")

[...]

Here is the summary with links:
- [net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()

    https://git.kernel.org/netdev/net/c/86360030cc51

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html