WTF: patch "[PATCH] crypto: qat - add param check for RSA" was seriously submitted to be applied to the 5.18-stable tree?
Subsystems (2)
[email protected]
maintainerThe patch below was submitted to be applied to the 5.18-stable tree.
I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable-kernel-rules.rst.
I could be totally wrong, and if so, please respond to <[email protected]> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 9714061423b8b24b8afb31b8eb4df977c63f19c4 Mon Sep 17 00:00:00 2001
From: Giovanni Cabiddu <[email protected]>
Date: Mon, 9 May 2022 14:34:14 +0100
Subject: [PATCH] crypto: qat - add param check for RSA
Reject requests with a source buffer that is bigger than the size of the key. This is to prevent a possible integer underflow that might happen when copying the source scatterlist into a linear buffer.
drivers/crypto/qat/qat_common/qat_asym_algs.c +8 -0
@@ -656,6 +656,10 @@ static int qat_rsa_enc(struct akcipher_request *req) req->dst_len = ctx->key_sz;return -EOVERFLOW ; } + +if (req->src_len > ctx->key_sz) +return -EINVAL ; +memset (msg,'\0' ,sizeof (*msg));ICP_QAT_FW_PKE_HDR_VALID_FLAG_SET (msg->pke_hdr,ICP_QAT_FW_COMN_REQ_FLAG_SET );
@@ -785,6 +789,10 @@ static int qat_rsa_dec(struct akcipher_request *req) req->dst_len = ctx->key_sz;return -EOVERFLOW ; } + +if (req->src_len > ctx->key_sz) +return -EINVAL ; +memset (msg,'\0' ,sizeof (*msg));ICP_QAT_FW_PKE_HDR_VALID_FLAG_SET (msg->pke_hdr,ICP_QAT_FW_COMN_REQ_FLAG_SET );