FAILED: patch "[PATCH] ipmi:ipmb: Fix refcount leak in ipmi_ipmb_probe" failed to apply to 5.17-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.17-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From a508e33956b538e034ed5df619a73ec7c15bda72 Mon Sep 17 00:00:00 2001
From: Miaoqian Lin <[email protected]>
Date: Thu, 12 May 2022 08:44:45 +0400
Subject: [PATCH] ipmi:ipmb: Fix refcount leak in ipmi_ipmb_probe
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak.
Fixes 00d93611f002 ("ipmi:ipmb: Add the ability to have a separate slave and master device")
Signed-off-by Miaoqian Lin <[email protected]>
Message-Id: <[email protected]>
Cc [email protected] # v5.17+
Signed-off-by Corey Minyard <[email protected]>
drivers/char/ipmi/ipmi_ipmb.c +1 -0
@@ -475,6 +475,7 @@ static int ipmi_ipmb_probe(struct i2c_client *client) slave_np =of_parse_phandle (dev->of_node,"slave-dev" ,0 );if (slave_np) { slave_adap =of_get_i2c_adapter_by_node (slave_np); +of_node_put (slave_np);if (!slave_adap) {dev_notice (&client->dev,"Could not find slave adapter\n" );