vmxnet3: disable overlay offloads if UPT device does not support
Subsystems (3)
PATCH 1/1 vmxnet3: disable overlay offloads if UPT device does not support
'Commit 6f91f4ba046e ("vmxnet3: add support for capability registers")' added support for capability registers. These registers are used to advertize capabilities of the device.
The patch updated the dev_caps to disable outer checksum offload if PTCR register does not support it. However, it missed to update other overlay offloads. This patch fixes this issue.
--- drivers/net/vmxnet3/vmxnet3_drv.c | 9 ++++++++- drivers/net/vmxnet3/vmxnet3_ethtool.c | 6 ++++++ 2 files changed, 14 insertions(+), 1 deletion(-)
drivers/net/vmxnet3/vmxnet3_drv.c +8 -1
@@ -3365,10 +3365,17 @@ vmxnet3_declare_features(struct vmxnet3_adapter *adapter) adapter->dev_caps[0 ] =VMXNET3_READ_BAR1_REG (adapter,VMXNET3_REG_CMD );spin_unlock_irqrestore (&adapter->cmd_lock, flags); +if (!(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_GENEVE_CHECKSUM_OFFLOAD )) && + !(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_VXLAN_CHECKSUM_OFFLOAD )) && + !(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_GENEVE_TSO )) && + !(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_VXLAN_TSO ))) { + netdev->hw_enc_features &= ~NETIF_F_GSO_UDP_TUNNEL ; + netdev->hw_features &= ~NETIF_F_GSO_UDP_TUNNEL ; + }if (!(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_GENEVE_OUTER_CHECKSUM_OFFLOAD )) && !(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_VXLAN_OUTER_CHECKSUM_OFFLOAD ))) { netdev->hw_enc_features &= ~NETIF_F_GSO_UDP_TUNNEL_CSUM ; - netdev->features &= ~NETIF_F_GSO_UDP_TUNNEL_CSUM ; + netdev->hw_features &= ~NETIF_F_GSO_UDP_TUNNEL_CSUM ; } }
drivers/net/vmxnet3/vmxnet3_ethtool.c +6 -0
@@ -346,6 +346,12 @@ static void vmxnet3_enable_encap_offloads(struct net_device *netdev, netdev_feat adapter->dev_caps[0 ] =VMXNET3_READ_BAR1_REG (adapter,VMXNET3_REG_CMD );spin_unlock_irqrestore (&adapter->cmd_lock, flags); +if (!(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_GENEVE_CHECKSUM_OFFLOAD )) && + !(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_VXLAN_CHECKSUM_OFFLOAD )) && + !(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_GENEVE_TSO )) && + !(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_VXLAN_TSO ))) { + netdev->hw_enc_features &= ~NETIF_F_GSO_UDP_TUNNEL ; + }if (!(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_GENEVE_OUTER_CHECKSUM_OFFLOAD )) && !(adapter->dev_caps[0 ] & (1UL <<VMXNET3_CAP_VXLAN_OUTER_CHECKSUM_OFFLOAD ))) { netdev->hw_enc_features &= ~NETIF_F_GSO_UDP_TUNNEL_CSUM ;
Signature · 1 line
2.11.0
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Quoted 9 lines · On Sun, 19 Jun 2022 17:10:13 -0700 you wrote:
'Commit
6f91f4ba046e("vmxnet3: add support for capability registers")' added support for capability registers. These registers are used to advertize capabilities of the device.The patch updated the
dev_capsto disable outer checksum offload if PTCR register does not support it. However, it missed to update other overlay offloads. This patch fixes this issue.[...]
Here is the summary with links:
- [net-next] vmxnet3: disable overlay offloads if UPT device does not support
https://git.kernel.org/netdev/net-next/c/a56b158a5078
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html