net: dsa: qca8k: reset cpu port on MTU change
Subsystems (4)
PATCH v2 1/1 net: dsa: qca8k: reset cpu port on MTU change
It was discovered that the Documentation lacks of a fundamental detail on how to correctly change the MAX_FRAME_SIZE of the switch.
In fact if the MAX_FRAME_SIZE is changed while the cpu port is on, the switch panics and cease to send any packet. This cause the mgmt ethernet system to not receive any packet (the slow fallback still works) and makes the device not reachable. To recover from this a switch reset is required.
To correctly handle this, turn off the cpu ports before changing the MAX_FRAME_SIZE and turn on again after the value is applied.
---
v2:
- Split from original series sent to net-next and rebased
- Added the stable cc tag
drivers/net/dsa/qca8k.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)
drivers/net/dsa/qca8k.c +21 -1
@@ -2334,6 +2334,7 @@ static int qca8k_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu) { struct qca8k_priv *priv = ds->priv; +int ret;/* We have only have a general MTU setting. * DSA always set the CPU port's MTU to the largest MTU of the slave
@@ -2344,8 +2345,27 @@ qca8k_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)if (!dsa_is_cpu_port (ds, port))return 0 ; +/* To change the MAX_FRAME_SIZE the cpu ports must be off or +* the switch panics. +* Turn off both cpu ports before applying the new value to prevent +* this. +*/ +if (priv->port_enabled_map &BIT (0 )) +qca8k_port_set_status (priv,0 ,0 ); + +if (priv->port_enabled_map &BIT (6 )) +qca8k_port_set_status (priv,6 ,0 ); +/* Include L2 header / FCS length */ -return qca8k_write (priv,QCA8K_MAX_FRAME_SIZE , new_mtu +ETH_HLEN +ETH_FCS_LEN ); + ret =qca8k_write (priv,QCA8K_MAX_FRAME_SIZE , new_mtu +ETH_HLEN +ETH_FCS_LEN ); + +if (priv->port_enabled_map &BIT (0 )) +qca8k_port_set_status (priv,0 ,1 ); + +if (priv->port_enabled_map &BIT (6 )) +qca8k_port_set_status (priv,6 ,1 ); + +return ret; } static int
Signature · 1 line
2.36.1
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Tue, 21 Jun 2022 17:11:22 +0200 you wrote:
It was discovered that the Documentation lacks of a fundamental detail on how to correctly change the
MAX_FRAME_SIZEof the switch.In fact if the
MAX_FRAME_SIZEis changed while the cpu port is on, the switch panics and cease to send any packet. This cause the mgmt ethernet system to not receive any packet (the slow fallback still works) and makes the device not reachable. To recover from this a switch reset is required.[...]
Here is the summary with links:
- [net,v2] net: dsa: qca8k: reset cpu port on MTU change
https://git.kernel.org/netdev/net/c/386228c694bf
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html