Skip to contentSkip to conversation

raw: fix a typo in raw_icmp_error()

PATCH Applied Eric Dumazet 2 participants 2 messages Jun 23, 2022 – Jun 25, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 raw: fix a typo in raw_icmp_error()

I accidentally broke IPv4 traceroute, by swaping iph->saddr and iph->daddr.

Probably because raw_icmp_error() and raw_v4_input() use different order for iph->saddr and iph->daddr.

Fixes ba44f8182ec2 ("raw: use more conventional iterators")
---
 net/ipv4/raw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/raw.c +1 -1
index 027389969915e456b0009e2a0b4ad81afb836e9d..006c1f0ed8b4731a8c64de282409e4bb03a6c1a6 100644
@@ -278,7 +278,7 @@ void raw_icmp_error(struct sk_buff *skb, int protocol, u32 info)
 	sk_nulls_for_each(sk, hnode, hlist) {
 		iph = (const struct iphdr *)skb->data;
 		if (!raw_v4_match(net, sk, iph->protocol,
-				  iph->saddr, iph->daddr, dif, sdif))
+				  iph->daddr, iph->saddr, dif, sdif))
 			continue;
 		raw_err(sk, skb, info);
 	}
Signature · 1 line
2.37.0.rc0.104.g0611611a94-goog
#1 lore raw
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Thu, 23 Jun 2022 19:35:40 +0000 you wrote:

I accidentally broke IPv4 traceroute, by swaping iph->saddr and iph->daddr.

Probably because raw_icmp_error() and raw_v4_input() use different order for iph->saddr and iph->daddr.

Fixes ba44f8182ec2 ("raw: use more conventional iterators")

[...]

Here is the summary with links:
- [net-next] raw: fix a typo in raw_icmp_error()

    https://git.kernel.org/netdev/net-next/c/97a4d46b1516

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html