net: pcs: xpcs: depends on PHYLINK in Kconfig
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 net: pcs: xpcs: depends on PHYLINK in Kconfig
This is yet another attempt at fixing:
Quoted 2 lines
Quoted 2 lines
ERROR: modpost: "
phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!
Switch XPCS to be invisible, as Russell points out it's "selected" by its consumers. Drop the dependency on MDIO_BUS as "depends" is meaningless on "selected" symbols.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- drivers/net/pcs/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/pcs/Kconfig +2 -2
@@ -6,8 +6,8 @@ menu "PCS device drivers" config PCS_XPCS - tristate "Synopsys DesignWare XPCS controller" - depends on MDIO_DEVICE && MDIO_BUS + tristate + select PHYLINK help This module provides helper functions for Synopsys DesignWare XPCS controllers.
Signature · 1 line
2.36.1
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Thu, 23 Jun 2022 13:29:33 -0700 you wrote:
This is yet another attempt at fixing:
Quoted 2 lines
Quoted 2 lines
ERROR: modpost: "
phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!Switch XPCS to be invisible, as Russell points out it's "selected" by its consumers. Drop the dependency on
MDIO_BUSas "depends" is meaningless on "selected" symbols.[...]
Here is the summary with links:
- [net-next] net: pcs: xpcs: depends on PHYLINK in Kconfig
https://git.kernel.org/netdev/net-next/c/ebeae54d3a77
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html