Skip to contentSkip to conversation

proc:fix confusing macro arg name

PATCH linmiaohe 4 participants 4 messages Oct 8, 2019

Subsystems (2)
lore
Share & tools
lore

linmiaohe

author Reviewed-by Andrew Morton
#0 lore raw

Add suitable additional cc's as Andrew Morton suggested.
Get cc list from get_maintainer script:
[root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch Alexey Dobriyan <[email protected]> (reviewer:PROC FILESYSTEM) [email protected] (open list:PROC FILESYSTEM) [email protected] (open list:PROC FILESYSTEM)

------------------------------------------------------
From: Miaohe Lin <[email protected]>
Subject: fix confusing macro arg name

state_size and ops are in the wrong position, fix it.

---

 include/linux/proc_fs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/proc_fs.h +2 -3
@@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *);  struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
 		struct proc_dir_entry *parent, const struct seq_operations *ops,
 		unsigned int state_size, void *data);
-#define proc_create_net(name, mode, parent, state_size, ops) \
-	proc_create_net_data(name, mode, parent, state_size, ops, NULL)
+#define proc_create_net(name, mode, parent, ops, state_size) \
+	proc_create_net_data(name, mode, parent, ops, state_size, NULL)
 struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
 		struct proc_dir_entry *parent,
 		int (*show)(struct seq_file *, void *), void *data);
--

2.21.GIT

#1 lore raw
Quoted 11 lines · linmiaohe

Add suitable additional cc's as Andrew Morton suggested.
Get cc list from get_maintainer script:
[root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch Alexey Dobriyan <[email protected]> (reviewer:PROC FILESYSTEM) [email protected] (open list:PROC FILESYSTEM) [email protected] (open list:PROC FILESYSTEM)

------------------------------------------------------
From: Miaohe Lin <[email protected]>
Subject: fix confusing macro arg name

Quoted 7 lines

state_size and ops are in the wrong position, fix it.

---

Good catch!

This is interesting, I saw this interface has 50+ callers, How did they work before? ;)

Thanks,
-Aubrey

Quoted 21 lines
 include/linux/proc_fs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/proc_fs.h +2 -3
@@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *);  struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
 		struct proc_dir_entry *parent, const struct seq_operations *ops,
 		unsigned int state_size, void *data);
-#define proc_create_net(name, mode, parent, state_size, ops) \
-	proc_create_net_data(name, mode, parent, state_size, ops, NULL)
+#define proc_create_net(name, mode, parent, ops, state_size) \
+	proc_create_net_data(name, mode, parent, ops, state_size, NULL)
 struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
 		struct proc_dir_entry *parent,
 		int (*show)(struct seq_file *, void *), void *data);
--

2.21.GIT

Acked-by
#2 lore raw
In reply to linmiaohe
Quoted 11 lines · linmiaohe

Add suitable additional cc's as Andrew Morton suggested.
Get cc list from get_maintainer script:
[root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch Alexey Dobriyan <[email protected]> (reviewer:PROC FILESYSTEM) [email protected] (open list:PROC FILESYSTEM) [email protected] (open list:PROC FILESYSTEM)

------------------------------------------------------
From: Miaohe Lin <[email protected]>
Subject: fix confusing macro arg name

Quoted 6 lines

state_size and ops are in the wrong position, fix it.

Looks reasonable.

Quoted 21 lines

---

 include/linux/proc_fs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/proc_fs.h +2 -3
@@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *);  struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
 		struct proc_dir_entry *parent, const struct seq_operations *ops,
 		unsigned int state_size, void *data);
-#define proc_create_net(name, mode, parent, state_size, ops) \
-	proc_create_net_data(name, mode, parent, state_size, ops, NULL)
+#define proc_create_net(name, mode, parent, ops, state_size) \
+	proc_create_net_data(name, mode, parent, ops, state_size, NULL)
 struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
 		struct proc_dir_entry *parent,
 		int (*show)(struct seq_file *, void *), void *data);
--

2.21.GIT

Signature · 4 lines
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
Reviewed-by
#3 lore raw
In reply to linmiaohe
Quoted 11 lines · linmiaohe

Add suitable additional cc's as Andrew Morton suggested.
Get cc list from get_maintainer script:
[root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch Alexey Dobriyan <[email protected]> (reviewer:PROC FILESYSTEM) [email protected] (open list:PROC FILESYSTEM) [email protected] (open list:PROC FILESYSTEM)

------------------------------------------------------
From: Miaohe Lin <[email protected]>
Subject: fix confusing macro arg name

Quoted 6 lines

state_size and ops are in the wrong position, fix it.

I thought I already reviewed this weeks ago...