Skip to contentSkip to conversation

ARM: dts: imx6qdl-ts7970: Fix ngpio typo and count

PATCH Superseded Kris Bahnsen 2 participants 5 messages Jun 30, 2022

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Kris Bahnsen

author
#0 lore raw

PATCH 1/1 ARM: dts: imx6qdl-ts7970: Fix ngpio typo and count

Device-tree incorrectly used "ngpio" which caused the driver to fallback to 32 ngpios.

This platform has 62 GPIO registers.

Signed-off-by Kris Bahnsen <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-ts7970.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-ts7970.dtsi +1 -1
index fded07f370b3..d6ba4b2a60f6 100644
@@ -226,7 +226,7 @@
 		reg = <0x28>;
 		#gpio-cells = <2>;
 		gpio-controller;
-		ngpio = <32>;
+		ngpios = <62>;
 	};
 
 	sgtl5000: codec@a {

base-commit: 03c765b0e3b4cb5063276b086c76f7a612856a9a

Signature · 1 line
2.11.0
#1 lore raw
Quoted 6 lines · Kris Bahnsen

Device-tree incorrectly used "ngpio" which caused the driver to fallback to 32 ngpios.

This platform has 62 GPIO registers.

Signed-off-by Kris Bahnsen <[email protected]>

You should add here Fixes tag.

Best regards,
Krzysztof

#2 lore raw
In reply to Kris Bahnsen
Quoted 7 lines · Kris Bahnsen

Device-tree incorrectly used "ngpio" which caused the driver to fallback to 32 ngpios.

This platform has 62 GPIO registers.

Signed-off-by Kris Bahnsen <[email protected]>

---

Ah and one more - for some reason you did not send it to maintainers, so patch will be most likely ignored. Please use scripts/get_maintainer.pl to CC relevant people.

Best regards,
Krzysztof

author
#3 lore raw
Quoted 6 lines · Krzysztof Kozlowski
Quoted 5 lines · Kris Bahnsen

Device-tree incorrectly used "ngpio" which caused the driver to fallback to 32 ngpios.

This platform has 62 GPIO registers.

Quoted 7 lines
Quoted 2 lines
Signed-off-by Kris Bahnsen <[email protected]>

---

Ah and one more - for some reason you did not send it to maintainers, so patch will be most likely ignored. Please use scripts/get_maintainer.pl to CC relevant people.

I reviewed that output and erred on the side of not generating too much noise and skipped folks/lists marked as general ARM/NXP maintainers. I'll be sure to send to all in the future.

Forgot about Fixes: tag, I'll add that in a v2.

Thanks for the feedback.

Quoted 4 lines

Best regards,
Krzysztof

#4 lore raw
Quoted 11 lines · Kris Bahnsen
Quoted 10 lines · Krzysztof Kozlowski
Quoted 7 lines · Kris Bahnsen

Device-tree incorrectly used "ngpio" which caused the driver to fallback to 32 ngpios.

This platform has 62 GPIO registers.

Signed-off-by Kris Bahnsen <[email protected]>

---

Quoted 7 lines
Quoted 3 lines

Ah and one more - for some reason you did not send it to maintainers, so patch will be most likely ignored. Please use scripts/get_maintainer.pl to CC relevant people.

I reviewed that output and erred on the side of not generating too much noise and skipped folks/lists marked as general ARM/NXP maintainers. I'll be sure to send to all in the future.

For small patchsets usually entire output of get_maintainers.pl is correct. What's worth to skip are the entries coming from history (--no-git-fallback).

Best regards,
Krzysztof