Skip to contentSkip to conversation

avdtp: fix possible minor problems

PATCH Applied lishengyu 3 participants 3 messages Jun 29, 2022 – Jun 30, 2022 Bluetooth drivers

lore
Share & tools
lore

lishengyu

author
#0 lore raw

PATCH 1/1 avdtp: fix possible minor problems

It should always be considered that if send_request fails, sep should be removed from the list and the requested memory freed;

---
 profiles/audio/avdtp.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
profiles/audio/avdtp.c +4 -1
index 0d2213ea2..10ef380d4 100644
@@ -2765,8 +2765,11 @@ static gboolean avdtp_discover_resp(struct avdtp *session,
 
 		ret = send_request(session, TRUE, NULL, getcap_cmd,
 							&req, sizeof(req));
-		if (ret < 0)
+		if (ret < 0) {
+			session->seps = g_slist_remove(session->seps, sep);
+			g_free(sep);
 			break;
+		}
 		getcap_pending = TRUE;
 	}
 
Signature · 1 line
2.20.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=655015

---Test result---

Test Summary:

CheckPatch                    PASS      1.19 seconds
GitLint                       PASS      0.87 seconds
Prep - Setup ELL              PASS      44.14 seconds
Build - Prep                  PASS      0.54 seconds
Build - Configure             PASS      8.63 seconds
Build - Make                  PASS      1434.45 seconds
Make Check                    PASS      11.55 seconds
Make Check w/Valgrind         PASS      450.88 seconds
Make Distcheck                PASS      240.18 seconds
Build w/ext ELL - Configure   PASS      8.66 seconds
Build w/ext ELL - Make        PASS      1419.52 seconds
Incremental Build with patchesPASS      0.00 seconds

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to lishengyu
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 5 lines · On Wed, 29 Jun 2022 20:46:56 +0800 you wrote:

It should always be considered that if send_request fails, sep should be removed from the list and the requested memory freed;

---
 profiles/audio/avdtp.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Here is the summary with links:
- [BlueZ] avdtp: fix possible minor problems

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=44658fccacda

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html