Skip to contentSkip to conversation

Documentation: add a description for net.core.high_order_alloc_disable

PATCH Applied Antoine Tenart 3 participants 3 messages Jul 7, 2022 – Jul 9, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Documentation: add a description for net.core.high_order_alloc_disable

A description is missing for the net.core.high_order_alloc_disable option in admin-guide/sysctl/net.rst ; add it. The above sysctl option was introduced by commit ce27ec60648d ("net: add high_order_alloc_disable sysctl/static key").

Thanks to Eric for running again the benchmark cited in the above commit, showing this knob is now mostly of historical importance.

---

Since v1:
- Reworked the documentation to mention this knob is now mostly of historical importance after Eric ran again the benchmark cited in the above commit.

 Documentation/admin-guide/sysctl/net.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/admin-guide/sysctl/net.rst +12 -0
index fcd650bdbc7e..805f2281e000 100644
@@ -391,6 +391,18 @@ GRO has decided not to coalesce, it is placed on a per-NAPI list. This
 list is then passed to the stack when the number of segments reaches the
 gro_normal_batch limit.
 
+high_order_alloc_disable
+------------------------
+
+By default the allocator for page frags tries to use high order pages (order-3
+on x86). While the default behavior gives good results in most cases, some users
+might have hit a contention in page allocations/freeing. This was especially
+true on older kernels (< 5.14) when high-order pages were not stored on per-cpu
+lists. This allows to opt-in for order-0 allocation instead but is now mostly of
+historical importance.
+
+Default: 0
+
 2. /proc/sys/net/unix - Parameters for Unix domain sockets
 ----------------------------------------------------------
 
Signature · 1 line
2.36.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · Antoine Tenart

A description is missing for the net.core.high_order_alloc_disable option in admin-guide/sysctl/net.rst ; add it. The above sysctl option was introduced by commit ce27ec60648d ("net: add high_order_alloc_disable sysctl/static key").

Quoted 6 lines

Thanks to Eric for running again the benchmark cited in the above commit, showing this knob is now mostly of historical importance.

---

#2 lore raw
In reply to Antoine Tenart
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Thu, 7 Jul 2022 10:02:45 +0200 you wrote:

A description is missing for the net.core.high_order_alloc_disable option in admin-guide/sysctl/net.rst ; add it. The above sysctl option was introduced by commit ce27ec60648d ("net: add high_order_alloc_disable sysctl/static key").

Thanks to Eric for running again the benchmark cited in the above commit, showing this knob is now mostly of historical importance.

[...]

Here is the summary with links:
- [net-next,v2] Documentation: add a description for net.core.high_order_alloc_disable

    https://git.kernel.org/netdev/net-next/c/40ad0a52ef5d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html