net: phylink: fix SGMII inband autoneg enable
Subsystems (4)
PATCH 1/1 net: phylink: fix SGMII inband autoneg enable
When we are operating in SGMII inband mode, it implies that there is a PHY connected, and the ethtool advertisement for autoneg applies to the PHY, not the SGMII link. When in 1000base-X mode, then this applies to the 802.3z link and needs to be applied to the PCS.
Fix this.
--- drivers/net/phy/phylink.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/phy/phylink.c +3 -1
@@ -3166,7 +3166,9 @@ int phylink_mii_c22_pcs_config(struct mdio_device *pcs, unsigned int mode,/* Ensure ISOLATE bit is disabled */ if (mode ==MLO_AN_INBAND && -linkmode_test_bit (ETHTOOL_LINK_MODE_Autoneg_BIT, advertising)) + (interface ==PHY_INTERFACE_MODE_SGMII || + interface ==PHY_INTERFACE_MODE_QSGMII || +linkmode_test_bit (ETHTOOL_LINK_MODE_Autoneg_BIT, advertising))) bmcr =BMCR_ANENABLE ;else bmcr =0 ;
Signature · 1 line
2.30.2
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Thu, 07 Jul 2022 10:20:02 +0100 you wrote:
When we are operating in SGMII inband mode, it implies that there is a PHY connected, and the ethtool advertisement for autoneg applies to the PHY, not the SGMII link. When in 1000base-X mode, then this applies to the 802.3z link and needs to be applied to the PCS.
Fix this.
[...]
Here is the summary with links:
- [net-next] net: phylink: fix SGMII inband autoneg enable
https://git.kernel.org/netdev/net-next/c/6d1ce9c03880
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html