nfp: fix clang -Wformat warnings
Subsystems (3)
PATCH 1/1 nfp: fix clang -Wformat warnings
When building with Clang we encounter these warnings:
| drivers/net/ethernet/netronome/nfp/nfp_app.c:233:99: error: format | specifies type 'unsigned char' but the argument has underlying type | 'unsigned int' [-Werror,-Wformat] nfp_err(pf->cpp, "unknown FW app ID | 0x%02hhx, driver too old or support for FW not built in\n", id); - | drivers/net/ethernet/netronome/nfp/nfp_main.c:396:11: error: format | specifies type 'unsigned char' but the argument has type 'int' | [-Werror,-Wformat] serial, interface >> 8, interface & 0xff);
Correct format specifier for id is %x since the default type for the nfp_app_id enum is unsigned int. The second warning is also solved by using the %x format specifier as the expressions involving interface are implicity promoted to integers (%x is used to maintain hexadecimal representation).
--- drivers/net/ethernet/netronome/nfp/nfp_app.c | 2 +- drivers/net/ethernet/netronome/nfp/nfp_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/netronome/nfp/nfp_app.c +1 -1
@@ -230,7 +230,7 @@ struct nfp_app *nfp_app_alloc(struct nfp_pf *pf, enum nfp_app_id id)struct nfp_app *app;if (id >=ARRAY_SIZE (apps) || !apps[id]) { -nfp_err (pf->cpp,"unknown FW app ID 0x%02hhx, driver too old or support for FW not built in\n" , id); +nfp_err (pf->cpp,"unknown FW app ID 0x%02x, driver too old or support for FW not built in\n" , id);return ERR_PTR (-EINVAL ); }
drivers/net/ethernet/netronome/nfp/nfp_main.c +1 -1
@@ -392,7 +392,7 @@ nfp_net_fw_find(struct pci_dev *pdev, struct nfp_pf *pf)/* First try to find a firmware image specific for this device */ interface =nfp_cpp_interface (pf->cpp);nfp_cpp_serial (pf->cpp, &serial); -sprintf (fw_name,"netronome/serial-%pMF-%02hhx-%02hhx.nffw" , +sprintf (fw_name,"netronome/serial-%pMF-%02x-%02x.nffw" , serial, interface >>8 , interface &0xff ); fw =nfp_net_fw_request (pdev, pf, fw_name);if (fw)
Signature · 1 line
2.37.0.144.g8ac04bfd2-goog
Quoted 10 lines · Justin Stitt
When building with Clang we encounter these warnings:
| drivers/net/ethernet/netronome/nfp/nfp_app.c:233:99: error: format | specifies type 'unsigned char' but the argument has underlying type | 'unsigned int' [-Werror,-Wformat] nfp_err(pf->cpp, "unknown FW app ID | 0x%02hhx, driver too old or support for FW not built in\n", id); - | drivers/net/ethernet/netronome/nfp/nfp_main.c:396:11: error: format | specifies type 'unsigned char' but the argument has type 'int' | [-Werror,-Wformat] serial, interface >> 8, interface & 0xff);
Quoted 8 lines
Correct format specifier for
idis%xsince the default type for thenfp_app_idenum isunsigned int. The second warning is also solved by using the%xformat specifier as the expressions involvinginterfaceare implicity promoted to integers (%x is used to maintain hexadecimal representation).
Thanks for improving the nfp driver.
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 11 lines · On Mon, 11 Jul 2022 17:01:52 -0700 you wrote:
When building with Clang we encounter these warnings:
| drivers/net/ethernet/netronome/nfp/nfp_app.c:233:99: error: format | specifies type 'unsigned char' but the argument has underlying type | 'unsigned int' [-Werror,-Wformat] nfp_err(pf->cpp, "unknown FW app ID | 0x%02hhx, driver too old or support for FW not built in\n", id); - | drivers/net/ethernet/netronome/nfp/nfp_main.c:396:11: error: format | specifies type 'unsigned char' but the argument has type 'int' | [-Werror,-Wformat] serial, interface >> 8, interface & 0xff);[...]
Here is the summary with links:
- nfp: fix clang -Wformat warnings
https://git.kernel.org/netdev/net-next/c/ef2a95db8900
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html