net: ftgmac100: Hold reference returned by of_get_child_by_name()
Subsystems (2)
PATCH v3 1/1 net: ftgmac100: Hold reference returned by of_get_child_by_name()
In ftgmac100_probe(), we should hold the refernece returned by of_get_child_by_name() and use it to call of_node_put() for reference balance.
---
changelog:
v3: make the helper return 'bool' and remove 'inline'
v2: (1) use a helper advised by Jakub (2) add fix tag
v1: directly hold the reference returned by of_get_xx
v1 link: https://lore.kernel.org/all/[email protected]/
v2 link: https://lore.kernel.org/all/[email protected]/
drivers/net/ethernet/faraday/ftgmac100.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)
drivers/net/ethernet/faraday/ftgmac100.c +14 -1
@@ -1764,6 +1764,19 @@ static int ftgmac100_setup_clk(struct ftgmac100 *priv)return rc; } +static bool ftgmac100_has_child_node (struct device_node *np,const char *name) +{ +struct device_node *child_np =of_get_child_by_name (np, name); +bool ret = false; + +if (child_np) { + ret = true; +of_node_put (child_np); + } + +return ret; +} +static int ftgmac100_probe (struct platform_device *pdev) {struct resource *res;
@@ -1883,7 +1896,7 @@ static int ftgmac100_probe(struct platform_device *pdev)/* Display what we found */ phy_attached_info (phy); - }else if (np && !of_get_child_by_name (np,"mdio" )) { + }else if (np && !ftgmac100_has_child_node (np,"mdio" )) {/* Support legacy ASPEED devicetree descriptions that decribe a * MAC with an embedded MDIO controller but have no "mdio" * child node. Automatically scan the MDIO bus for available
Signature · 1 line
2.25.1
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Tue, 12 Jul 2022 14:14:17 +0800 you wrote:
In
ftgmac100_probe(), we should hold the refernece returned byof_get_child_by_name()and use it to callof_node_put()for reference balance.Fixes 39bfab8844a0 ("net: ftgmac100: Add support for DT phy-handle property")Signed-off-by Liang He <[email protected]>[...]
Here is the summary with links:
- [v3] net: ftgmac100: Hold reference returned by of_get_child_by_name()
https://git.kernel.org/netdev/net/c/49b9f431ff0d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html