bpf: fix check against plain integer v 'NULL'
PATCH 1/1 bpf: fix check against plain integer v 'NULL'
When checking with sparse, btf_show_type_value() is causing a warning about checking integer vs NULL when the macro is passed a pointer, due to the 'value != 0' check. Stop sparse complaining about any type-casting by adding a cast to the typeof(value).
This fixes the following sparse warnings:
kernel/bpf/btf.c:2579:17: warning: Using plain integer as NULL pointer kernel/bpf/btf.c:2581:17: warning: Using plain integer as NULL pointer kernel/bpf/btf.c:3407:17: warning: Using plain integer as NULL pointer kernel/bpf/btf.c:3758:9: warning: Using plain integer as NULL pointer
--- kernel/bpf/btf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/bpf/btf.c +2 -1
@@ -1108,7 +1108,8 @@ __printf(2, 3) static void btf_show(struct btf_show *show, const char *fmt, ...)*/ #define btf_show_type_value (show, fmt, value) \ do { \ - if ((value) != 0 || (show->flags & BTF_SHOW_ZERO) || \ + if ((value) != (__typeof__(value))0 || \ + (show->flags & BTF_SHOW_ZERO) || \ show->state.depth == 0) { \ btf_show(show, "%s%s" fmt "%s%s", \ btf_show_indent(show), \
Signature · 1 line
2.35.1
Quoted 5 lines · Ben Dooks
When checking with sparse,
btf_show_type_value()is causing a warning about checking integer vs NULL when the macro is passed a pointer, due to the 'value != 0' check. Stop sparse complaining about any type-casting by adding a cast to the typeof(value).
Quoted 8 lines
This fixes the following sparse warnings:
kernel/bpf/btf.c:2579:17: warning: Using plain integer as NULL pointerkernel/bpf/btf.c:2581:17: warning: Using plain integer as NULL pointerkernel/bpf/btf.c:3407:17: warning: Using plain integer as NULL pointerkernel/bpf/btf.c:3758:9: warning: Using plain integer as NULL pointerSigned-off-by Ben Dooks <[email protected]>
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Quoted 8 lines · On Thu, 14 Jul 2022 11:03:22 +0100 you wrote:
When checking with sparse,
btf_show_type_value()is causing a warning about checking integer vs NULL when the macro is passed a pointer, due to the 'value != 0' check. Stop sparse complaining about any type-casting by adding a cast to the typeof(value).This fixes the following sparse warnings:
[...]
Here is the summary with links:
- bpf: fix check against plain integer v 'NULL'
https://git.kernel.org/bpf/bpf-next/c/a2a5580fcbf8
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html