Skip to contentSkip to conversation

atl1c: use netif_tx_napi_add() for Tx NAPI

PATCH Superseded Sieng-Piaw Liew 3 participants 4 messages Jul 15, 2022 – Jul 18, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 atl1c: use netif_tx_napi_add() for Tx NAPI

Use netif_tx_napi_add() for NAPI in Tx direction instead of the regular netif_napi_add() function.

---
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/atheros/atl1c/atl1c_main.c +2 -2
index 948584761e66..bf293a3ed4c9 100644
@@ -2734,8 +2734,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		netif_napi_add(netdev, &adapter->rrd_ring[i].napi,
 			       atl1c_clean_rx, 64);
 	for (i = 0; i < adapter->tx_queue_count; ++i)
-		netif_napi_add(netdev, &adapter->tpd_ring[i].napi,
-			       atl1c_clean_tx, 64);
+		netif_napi_add_tx_weight(netdev, &adapter->tpd_ring[i].napi,
+					 atl1c_clean_tx, 64);
 	timer_setup(&adapter->phy_config_timer, atl1c_phy_config, 0);
 	/* setup the private structure */
 	err = atl1c_sw_init(adapter);
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 4 lines · On Fri, 15 Jul 2022 12:21:31 +0800 Sieng-Piaw Liew wrote:

Use netif_tx_napi_add() for NAPI in Tx direction instead of the regular netif_napi_add() function.

Please use netif_napi_add_tx(), since you use the default weight anyway there's no need to specify it.

Quoted 15 lines
drivers/net/ethernet/atheros/atl1c/atl1c_main.c +2 -2
index 948584761e66..bf293a3ed4c9 100644
@@ -2734,8 +2734,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		netif_napi_add(netdev, &adapter->rrd_ring[i].napi,
 			       atl1c_clean_rx, 64);
 	for (i = 0; i < adapter->tx_queue_count; ++i)
-		netif_napi_add(netdev, &adapter->tpd_ring[i].napi,
-			       atl1c_clean_tx, 64);
+		netif_napi_add_tx_weight(netdev, &adapter->tpd_ring[i].napi,
+					 atl1c_clean_tx, 64);
 	timer_setup(&adapter->phy_config_timer, atl1c_phy_config, 0);
 	/* setup the private structure */
 	err = atl1c_sw_init(adapter);
#2 lore raw

PATCH v2 1/1 atl1c: use netif_napi_add_tx() for Tx NAPI

Use netif_napi_add_tx() for NAPI in Tx direction instead of the regular netif_napi_add() function.

---
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/atheros/atl1c/atl1c_main.c +2 -2
index 948584761e66..a6d55f452e2f 100644
@@ -2734,8 +2734,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		netif_napi_add(netdev, &adapter->rrd_ring[i].napi,
 			       atl1c_clean_rx, 64);
 	for (i = 0; i < adapter->tx_queue_count; ++i)
-		netif_napi_add(netdev, &adapter->tpd_ring[i].napi,
-			       atl1c_clean_tx, 64);
+		netif_napi_add_tx(netdev, &adapter->tpd_ring[i].napi,
+				  atl1c_clean_tx);
 	timer_setup(&adapter->phy_config_timer, atl1c_phy_config, 0);
 	/* setup the private structure */
 	err = atl1c_sw_init(adapter);
Signature · 1 line
2.17.1
#3 lore raw

Re: [PATCH net-next v2] atl1c: use netif_napi_add_tx() for Tx NAPI

This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Quoted 7 lines · On Fri, 15 Jul 2022 15:50:43 +0800 you wrote:

Use netif_napi_add_tx() for NAPI in Tx direction instead of the regular netif_napi_add() function.

---
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- [net-next,v2] atl1c: use netif_napi_add_tx() for Tx NAPI

    https://git.kernel.org/netdev/net-next/c/6e693a104207

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html