Skip to contentSkip to conversation

bpf: fix bpf_skb_pull_data documentation

PATCH Applied Joanne Koong 3 participants 3 messages Jul 15, 2022 – Jul 19, 2022 BPF

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 bpf: fix bpf_skb_pull_data documentation

Fix documentation for bpf_skb_pull_data() helper for when len == 0.

Fixes fa15601ab31e ("bpf: add documentation for eBPF helpers (33-41)")
---
 include/uapi/linux/bpf.h       | 3 ++-
 tools/include/uapi/linux/bpf.h | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
include/uapi/linux/bpf.h +2 -1
index 379e68fb866f..ffcbf79a556b 100644
@@ -2361,7 +2361,8 @@ union bpf_attr {
  * 		Pull in non-linear data in case the *skb* is non-linear and not
  * 		all of *len* are part of the linear section. Make *len* bytes
  * 		from *skb* readable and writable. If a zero value is passed for
- * 		*len*, then the whole length of the *skb* is pulled.
+ *		*len*, then all bytes in the linear part of *skb* will be made
+ *		readable and writable.
  *
  * 		This helper is only needed for reading and writing with direct
  * 		packet access.
tools/include/uapi/linux/bpf.h +2 -1
index 379e68fb866f..ffcbf79a556b 100644
@@ -2361,7 +2361,8 @@ union bpf_attr {
  * 		Pull in non-linear data in case the *skb* is non-linear and not
  * 		all of *len* are part of the linear section. Make *len* bytes
  * 		from *skb* readable and writable. If a zero value is passed for
- * 		*len*, then the whole length of the *skb* is pulled.
+ *		*len*, then all bytes in the linear part of *skb* will be made
+ *		readable and writable.
  *
  * 		This helper is only needed for reading and writing with direct
  * 		packet access.
Signature · 1 line
2.30.2
#2 lore raw
In reply to Joanne Koong
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Quoted 8 lines · On Fri, 15 Jul 2022 12:38:00 -0700 you wrote:

Fix documentation for bpf_skb_pull_data() helper for when len == 0.

Fixes fa15601ab31e ("bpf: add documentation for eBPF helpers (33-41)")

[...]

Here is the summary with links:
- [bpf-next,v2] bpf: fix bpf_skb_pull_data documentation

    https://git.kernel.org/bpf/bpf-next/c/bdb2bc759929

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html