mlxsw: Add PTP support for Spectrum-2 and newer ASICs
Subsystems (3)
Ido Schimmel
maintainercover mlxsw: Add PTP support for Spectrum-2 and newer ASICs
This patchset adds PTP support for Spectrum-{2,3,4} switch ASICs. They all act largely the same with respect to PTP except for a workaround implemented for Spectrum-{2,3} in patch #6.
Spectrum-2 and newer ASICs essentially implement a transparent clock between all the switch ports, including the CPU port. The hardware will generate the UTC time stamp for transmitted / received packets at the CPU port, but will compensate for forwarding delays in the ASIC by adjusting the correction field in the PTP header (for PTP events) at the ingress and egress ports.
Specifically, the hardware will subtract the current time stamp from the correction field at the ingress port and will add the current time stamp to the correction field at the egress port. For the purpose of an ordinary or boundary clock (this patchset), the correction field will always be adjusted between the CPU port and one of the front panel ports, but never between two front panel ports.
Patchset overview:
Patch #1 extracts a helper to configure traps for PTP packets (event and general messages). The helper is shared between all Spectrum generations.
Patch #2 transitions Spectrum-2 and newer ASICs to use a different format of Tx completions that includes the UTC time stamp of transmitted packets.
Patch #3 adds basic initialization required for Spectrum-2 PTP support. It mainly invokes the helper from patch #1.
Patch #4 adds helpers to read the UTC time (seconds and nanoseconds) from the device over memory-mapped I/O instead of going through firmware which is slower and therefore inaccurate. The helpers will be used to implement various PHC operations (e.g., gettimex64) and to construct the full UTC time stamp from the truncated one reported over Tx / Rx completions.
Patch #5 implements the various PHC operations.
Patch #6 implements the previously described workaround for Spectrum-{2,3}.
Patch #7 adds the ability to report a hardware time stamp for a received / transmitted packet based off the associated Rx / Tx completion that includes a truncated UTC time stamp.
Patches #8 and #9 implement support for the SIOCGHWTSTAMP / SIOCSHWTSTAMP ioctls and the get_ts_info ethtool callback, respectively.
Amit Cohen (1):
mlxsw: spectrum_ptp: Add helper functions to configure PTP traps
Danielle Ratson (8):
mlxsw: Support CQEv2 for SDQ in Spectrum-2 and newer ASICs
mlxsw: spectrum_ptp: Add PTP initialization / finalization for
Spectrum-2
mlxsw: Query UTC sec and nsec PCI offsets and values
mlxsw: spectrum_ptp: Add implementation for physical hardware clock
operations
mlxsw: Send PTP packets as data packets to overcome a limitation
mlxsw: spectrum: Support time stamping on Spectrum-2
mlxsw: spectrum_ptp: Support SIOCGHWTSTAMP, SIOCSHWTSTAMP ioctls
mlxsw: spectrum: Support ethtool 'get_ts_info' callback in Spectrum-2
drivers/net/ethernet/mellanox/mlxsw/core.c | 18 + drivers/net/ethernet/mellanox/mlxsw/core.h | 14 + drivers/net/ethernet/mellanox/mlxsw/pci.c | 64 +- .../net/ethernet/mellanox/mlxsw/spectrum.c | 118 +++- .../net/ethernet/mellanox/mlxsw/spectrum.h | 10 + .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 576 +++++++++++++++++- .../ethernet/mellanox/mlxsw/spectrum_ptp.h | 60 +- 7 files changed, 820 insertions(+), 40 deletions(-)
Signature · 1 line
2.36.1
Ido Schimmel
maintainerPATCH 1/9 mlxsw: spectrum_ptp: Add helper functions to configure PTP traps
From: Amit Cohen <[email protected]>
MTPTPT register is used to set which message types should arrive under which PTP trap. Currently, PTP0 is used for event message types, which means that the packets require time stamp. PTP1 is used for other packets.
This configuration will be same for Spectrum-2 and newer ASICs. In preparation for Spectrum-2 PTP support, add helper functions to configure PTP traps and use them for Spectrum-1. These functions will be used later also for Spectrum-2.
--- .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 62 ++++++++++++------- 1 file changed, 40 insertions(+), 22 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c +40 -22
@@ -835,10 +835,44 @@ static int mlxsw_sp1_ptp_shaper_params_set(struct mlxsw_sp *mlxsw_sp)return 0 ; } +static int mlxsw_sp_ptp_traps_set (struct mlxsw_sp *mlxsw_sp) +{ +u16 event_message_type; +int err; + +/* Deliver these message types as PTP0. */ + event_message_type =BIT (PTP_MSGTYPE_SYNC ) | +BIT (PTP_MSGTYPE_DELAY_REQ ) | +BIT (PTP_MSGTYPE_PDELAY_REQ ) | +BIT (PTP_MSGTYPE_PDELAY_RESP ); + + err =mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP0 , + event_message_type); +if (err) +return err; + +/* Everything else is PTP1. */ + err =mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP1 , + ~event_message_type); +if (err) + goto err_mtptpt1_set; + +return 0 ; + +err_mtptpt1_set: +mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP0 ,0 ); +return err; +} + +static void mlxsw_sp_ptp_traps_unset (struct mlxsw_sp *mlxsw_sp) +{ +mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP1 ,0 ); +mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP0 ,0 ); +} +struct mlxsw_sp_ptp_state *mlxsw_sp1_ptp_init (struct mlxsw_sp *mlxsw_sp) {struct mlxsw_sp1_ptp_state *ptp_state; -u16 message_type;int err; err =mlxsw_sp1_ptp_shaper_params_set (mlxsw_sp);
@@ -857,22 +891,9 @@ struct mlxsw_sp_ptp_state *mlxsw_sp1_ptp_init(struct mlxsw_sp *mlxsw_sp)if (err) goto err_hashtable_init; -/* Delive these message types as PTP0. */ - message_type =BIT (PTP_MSGTYPE_SYNC ) | -BIT (PTP_MSGTYPE_DELAY_REQ ) | -BIT (PTP_MSGTYPE_PDELAY_REQ ) | -BIT (PTP_MSGTYPE_PDELAY_RESP ); - err =mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP0 , - message_type); -if (err) - goto err_mtptpt_set; - -/* Everything else is PTP1. */ - message_type = ~message_type; - err =mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP1 , - message_type); + err =mlxsw_sp_ptp_traps_set (mlxsw_sp);if (err) - goto err_mtptpt1_set; + goto err_ptp_traps_set; err =mlxsw_sp1_ptp_set_fifo_clr_on_trap (mlxsw_sp, true);if (err)
@@ -884,10 +905,8 @@ struct mlxsw_sp_ptp_state *mlxsw_sp1_ptp_init(struct mlxsw_sp *mlxsw_sp)return &ptp_state->common; err_fifo_clr: -mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP1 ,0 ); -err_mtptpt1_set: -mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP0 ,0 ); -err_mtptpt_set: +mlxsw_sp_ptp_traps_unset (mlxsw_sp); +err_ptp_traps_set:rhltable_destroy (&ptp_state->unmatched_ht); err_hashtable_init:kfree (ptp_state);
@@ -904,8 +923,7 @@ void mlxsw_sp1_ptp_fini(struct mlxsw_sp_ptp_state *ptp_state_common)cancel_delayed_work_sync (&ptp_state->ht_gc_dw);mlxsw_sp1_ptp_mtpppc_set (mlxsw_sp,0 ,0 );mlxsw_sp1_ptp_set_fifo_clr_on_trap (mlxsw_sp, false); -mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP1 ,0 ); -mlxsw_sp_ptp_mtptpt_set (mlxsw_sp,MLXSW_REG_MTPTPT_TRAP_ID_PTP0 ,0 ); +mlxsw_sp_ptp_traps_unset (mlxsw_sp);rhltable_free_and_destroy (&ptp_state->unmatched_ht, &mlxsw_sp1_ptp_unmatched_free_fn,NULL );kfree (ptp_state);
Signature · 1 line
2.36.1
Ido Schimmel
maintainerPATCH 2/9 mlxsw: Support CQEv2 for SDQ in Spectrum-2 and newer ASICs
In reply to Ido SchimmelFrom: Danielle Ratson <[email protected]>
Currently, Tx completions are reported using Completion Queue Element version 1 (CQEv1). These elements do not contain the Tx time stamp, which is fine as Spectrum-1 reads Tx time stamps via a dedicated FIFO and Spectrum-2 does not currently support PTP.
In preparation for Spectrum-2 PTP support, use CQEv2 for Spectrum-2 and newer ASICs, as this CQE format encodes the Tx time stamp.
--- drivers/net/ethernet/mellanox/mlxsw/core.c | 6 ++++++ drivers/net/ethernet/mellanox/mlxsw/core.h | 3 +++ drivers/net/ethernet/mellanox/mlxsw/pci.c | 4 ++-- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 ++++ 4 files changed, 15 insertions(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/core.c +6 -0
@@ -3335,6 +3335,12 @@ u32 mlxsw_core_read_frc_l(struct mlxsw_core *mlxsw_core) }EXPORT_SYMBOL (mlxsw_core_read_frc_l); +bool mlxsw_core_sdq_supports_cqe_v2 (struct mlxsw_core *mlxsw_core) +{ +return mlxsw_core->driver->sdq_supports_cqe_v2; +} +EXPORT_SYMBOL (mlxsw_core_sdq_supports_cqe_v2); +void mlxsw_core_emad_string_tlv_enable (struct mlxsw_core *mlxsw_core) { mlxsw_core->emad.enable_string_tlv = true;
drivers/net/ethernet/mellanox/mlxsw/core.h +3 -0
@@ -427,6 +427,7 @@ struct mlxsw_driver {u8 txhdr_len;const struct mlxsw_config_profile *profile; +bool sdq_supports_cqe_v2; }; int mlxsw_core_kvd_sizes_get(struct mlxsw_core *mlxsw_core,
@@ -437,6 +438,8 @@ int mlxsw_core_kvd_sizes_get(struct mlxsw_core *mlxsw_core,u32 mlxsw_core_read_frc_h (struct mlxsw_core *mlxsw_core);u32 mlxsw_core_read_frc_l (struct mlxsw_core *mlxsw_core); +bool mlxsw_core_sdq_supports_cqe_v2 (struct mlxsw_core *mlxsw_core); +void mlxsw_core_emad_string_tlv_enable (struct mlxsw_core *mlxsw_core); bool mlxsw_core_res_valid(struct mlxsw_core *mlxsw_core,
drivers/net/ethernet/mellanox/mlxsw/pci.c +2 -2
@@ -456,9 +456,9 @@ static void mlxsw_pci_cq_pre_init(struct mlxsw_pci *mlxsw_pci, { q->u.cq.v = mlxsw_pci->max_cqe_ver; -/* For SDQ it is pointless to use CQEv2, so use CQEv1 instead */ if (q->u.cq.v ==MLXSW_PCI_CQE_V2 && - q->num < mlxsw_pci->num_sdq_cqs) + q->num < mlxsw_pci->num_sdq_cqs && + !mlxsw_core_sdq_supports_cqe_v2 (mlxsw_pci->core)) q->u.cq.v =MLXSW_PCI_CQE_V1 ; }
drivers/net/ethernet/mellanox/mlxsw/spectrum.c +4 -0
@@ -3831,6 +3831,7 @@ static struct mlxsw_driver mlxsw_sp1_driver = { .ptp_transmitted = mlxsw_sp_ptp_transmitted, .txhdr_len = MLXSW_TXHDR_LEN, .profile = &mlxsw_sp1_config_profile, + .sdq_supports_cqe_v2 = false, };static struct mlxsw_driver mlxsw_sp2_driver = {
@@ -3869,6 +3870,7 @@ static struct mlxsw_driver mlxsw_sp2_driver = { .ptp_transmitted = mlxsw_sp_ptp_transmitted, .txhdr_len = MLXSW_TXHDR_LEN, .profile = &mlxsw_sp2_config_profile, + .sdq_supports_cqe_v2 = true, };static struct mlxsw_driver mlxsw_sp3_driver = {
@@ -3907,6 +3909,7 @@ static struct mlxsw_driver mlxsw_sp3_driver = { .ptp_transmitted = mlxsw_sp_ptp_transmitted, .txhdr_len = MLXSW_TXHDR_LEN, .profile = &mlxsw_sp2_config_profile, + .sdq_supports_cqe_v2 = true, };static struct mlxsw_driver mlxsw_sp4_driver = {
@@ -3943,6 +3946,7 @@ static struct mlxsw_driver mlxsw_sp4_driver = { .ptp_transmitted = mlxsw_sp_ptp_transmitted, .txhdr_len = MLXSW_TXHDR_LEN, .profile = &mlxsw_sp2_config_profile, + .sdq_supports_cqe_v2 = true, };bool mlxsw_sp_port_dev_check (const struct net_device *dev)
Signature · 1 line
2.36.1
Ido Schimmel
maintainerPATCH 3/9 mlxsw: spectrum_ptp: Add PTP initialization / finalization for Spectrum-2
In reply to Ido SchimmelFrom: Danielle Ratson <[email protected]>
Lay the groundwork for Spectrum-2 support. On Spectrum-2, the packets get the time stamps from the CQE, which means that the time stamp is attached to its packet.
Configure MTPTPT to set which message types should arrive under which PTP trap. PTP0 will be used for event message types, which means that the packets require time stamp. PTP1 will be used for other packets.
Note that in Spectrum-2, all packets contain time stamp by default. The two types of traps (PTP0, PTP1) will be used to separate between PTP_EVENT traps and PTP_GENERAL traps, so then the driver will fill the time stamp as part of the SKB only for event message types.
Later the driver will enable the traps using 'MTPCPC.ptp_trap_en' bit. Then, PTP packets start arriving through the PTP traps.
Currently, the structure 'mlxsw_sp2_ptp_state' contains only the common structure, the next patches will extend it.
--- .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 44 +++++++++++++++++++ .../ethernet/mellanox/mlxsw/spectrum_ptp.h | 17 ++++--- 2 files changed, 54 insertions(+), 7 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c +44 -0
@@ -39,6 +39,10 @@ struct mlxsw_sp1_ptp_state {u32 gc_cycle; }; +struct mlxsw_sp2_ptp_state { +struct mlxsw_sp_ptp_state common; +}; +struct mlxsw_sp1_ptp_key {u16 local_port;u8 message_type;
@@ -85,6 +89,13 @@ mlxsw_sp1_ptp_state(struct mlxsw_sp *mlxsw_sp) common); } +static struct mlxsw_sp2_ptp_state * +mlxsw_sp2_ptp_state (struct mlxsw_sp *mlxsw_sp) +{ + return container_of(mlxsw_sp->ptp_state, struct mlxsw_sp2_ptp_state, + common); +} +static struct mlxsw_sp1_ptp_clock *mlxsw_sp1_ptp_clock (struct ptp_clock_info *ptp) {
@@ -1194,3 +1205,36 @@ void mlxsw_sp1_get_stats(struct mlxsw_sp_port *mlxsw_sp_port, *data++ = *(u64 *)(stats + offset); } } + +struct mlxsw_sp_ptp_state *mlxsw_sp2_ptp_init (struct mlxsw_sp *mlxsw_sp) +{ +struct mlxsw_sp2_ptp_state *ptp_state; +int err; + + ptp_state =kzalloc (sizeof (*ptp_state),GFP_KERNEL ); +if (!ptp_state) +return ERR_PTR (-ENOMEM ); + + ptp_state->common.mlxsw_sp = mlxsw_sp; + + err =mlxsw_sp_ptp_traps_set (mlxsw_sp); +if (err) + goto err_ptp_traps_set; + +return &ptp_state->common; + +err_ptp_traps_set: +kfree (ptp_state); +return ERR_PTR (err); +} + +void mlxsw_sp2_ptp_fini (struct mlxsw_sp_ptp_state *ptp_state_common) +{ +struct mlxsw_sp *mlxsw_sp = ptp_state_common->mlxsw_sp; +struct mlxsw_sp2_ptp_state *ptp_state; + + ptp_state =mlxsw_sp2_ptp_state (mlxsw_sp); + +mlxsw_sp_ptp_traps_unset (mlxsw_sp); +kfree (ptp_state); +}
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h +10 -7
@@ -57,6 +57,9 @@ void mlxsw_sp1_get_stats_strings(u8 **p);void mlxsw_sp1_get_stats (struct mlxsw_sp_port *mlxsw_sp_port,u64 *data,int data_index); +struct mlxsw_sp_ptp_state *mlxsw_sp2_ptp_init (struct mlxsw_sp *mlxsw_sp); + +void mlxsw_sp2_ptp_fini (struct mlxsw_sp_ptp_state *ptp_state);#else static inline struct mlxsw_sp_ptp_clock *
@@ -136,25 +139,25 @@ static inline void mlxsw_sp1_get_stats(struct mlxsw_sp_port *mlxsw_sp_port, u64 *data, int data_index) { } -#endif -static inline struct mlxsw_sp_ptp_clock * -mlxsw_sp2_ptp_clock_init (struct mlxsw_sp *mlxsw_sp,struct device *dev) +static inline struct mlxsw_sp_ptp_state * +mlxsw_sp2_ptp_init (struct mlxsw_sp *mlxsw_sp) {return NULL ; } -static inline void mlxsw_sp2_ptp_clock_fini (struct mlxsw_sp_ptp_clock *clock) +static inline void mlxsw_sp2_ptp_fini (struct mlxsw_sp_ptp_state *ptp_state) { } +#endif -static inline struct mlxsw_sp_ptp_state * -mlxsw_sp2_ptp_init (struct mlxsw_sp *mlxsw_sp) +static inline struct mlxsw_sp_ptp_clock * +mlxsw_sp2_ptp_clock_init (struct mlxsw_sp *mlxsw_sp,struct device *dev) {return NULL ; } -static inline void mlxsw_sp2_ptp_fini (struct mlxsw_sp_ptp_state *ptp_state) +static inline void mlxsw_sp2_ptp_clock_fini (struct mlxsw_sp_ptp_clock *clock) { }
Signature · 1 line
2.36.1
Ido Schimmel
maintainerPATCH 4/9 mlxsw: Query UTC sec and nsec PCI offsets and values
In reply to Ido SchimmelFrom: Danielle Ratson <[email protected]>
Query UTC sec and nsec PCI offsets during the pci_init(), to be able to read UTC time later.
Implement functions to read UTC seconds and nanoseconds from the offset which was read as part of initialization.
--- drivers/net/ethernet/mellanox/mlxsw/core.c | 12 +++++++ drivers/net/ethernet/mellanox/mlxsw/core.h | 5 +++ drivers/net/ethernet/mellanox/mlxsw/pci.c | 38 ++++++++++++++++++++++ 3 files changed, 55 insertions(+)
drivers/net/ethernet/mellanox/mlxsw/core.c +12 -0
@@ -3335,6 +3335,18 @@ u32 mlxsw_core_read_frc_l(struct mlxsw_core *mlxsw_core) }EXPORT_SYMBOL (mlxsw_core_read_frc_l); +u32 mlxsw_core_read_utc_sec (struct mlxsw_core *mlxsw_core) +{ +return mlxsw_core->bus->read_utc_sec (mlxsw_core->bus_priv); +} +EXPORT_SYMBOL (mlxsw_core_read_utc_sec); + +u32 mlxsw_core_read_utc_nsec (struct mlxsw_core *mlxsw_core) +{ +return mlxsw_core->bus->read_utc_nsec (mlxsw_core->bus_priv); +} +EXPORT_SYMBOL (mlxsw_core_read_utc_nsec); +bool mlxsw_core_sdq_supports_cqe_v2 (struct mlxsw_core *mlxsw_core) {return mlxsw_core->driver->sdq_supports_cqe_v2;
drivers/net/ethernet/mellanox/mlxsw/core.h +5 -0
@@ -438,6 +438,9 @@ int mlxsw_core_kvd_sizes_get(struct mlxsw_core *mlxsw_core,u32 mlxsw_core_read_frc_h (struct mlxsw_core *mlxsw_core);u32 mlxsw_core_read_frc_l (struct mlxsw_core *mlxsw_core); +u32 mlxsw_core_read_utc_sec (struct mlxsw_core *mlxsw_core); +u32 mlxsw_core_read_utc_nsec (struct mlxsw_core *mlxsw_core); +bool mlxsw_core_sdq_supports_cqe_v2 (struct mlxsw_core *mlxsw_core);void mlxsw_core_emad_string_tlv_enable (struct mlxsw_core *mlxsw_core);
@@ -479,6 +482,8 @@ struct mlxsw_bus { u8 *p_status);u32 (*read_frc_h)(void *bus_priv);u32 (*read_frc_l)(void *bus_priv); +u32 (*read_utc_sec)(void *bus_priv); +u32 (*read_utc_nsec)(void *bus_priv);u8 features; };
drivers/net/ethernet/mellanox/mlxsw/pci.c +38 -0
@@ -103,6 +103,8 @@ struct mlxsw_pci {struct pci_dev *pdev;u8 __iomem *hw_addr;u64 free_running_clock_offset; +u64 utc_sec_offset; +u64 utc_nsec_offset;struct mlxsw_pci_queue_type_group queues[MLXSW_PCI_QUEUE_TYPE_COUNT ];u32 doorbell_offset;struct mlxsw_core *core;
@@ -1537,6 +1539,24 @@ static int mlxsw_pci_init(void *bus_priv, struct mlxsw_core *mlxsw_core, mlxsw_pci->free_running_clock_offset =mlxsw_cmd_mbox_query_fw_free_running_clock_offset_get (mbox); +if (mlxsw_cmd_mbox_query_fw_utc_sec_bar_get (mbox) !=0 ) { +dev_err (&pdev->dev,"Unsupported UTC sec BAR queried from hw\n" ); + err = -EINVAL ; + goto err_utc_sec_bar; + } + + mlxsw_pci->utc_sec_offset = +mlxsw_cmd_mbox_query_fw_utc_sec_offset_get (mbox); + +if (mlxsw_cmd_mbox_query_fw_utc_nsec_bar_get (mbox) !=0 ) { +dev_err (&pdev->dev,"Unsupported UTC nsec BAR queried from hw\n" ); + err = -EINVAL ; + goto err_utc_nsec_bar; + } + + mlxsw_pci->utc_nsec_offset = +mlxsw_cmd_mbox_query_fw_utc_nsec_offset_get (mbox); + num_pages =mlxsw_cmd_mbox_query_fw_fw_pages_get (mbox); err =mlxsw_pci_fw_area_init (mlxsw_pci, mbox, num_pages);if (err)
@@ -1601,6 +1621,8 @@ static int mlxsw_pci_init(void *bus_priv, struct mlxsw_core *mlxsw_core, err_boardinfo:mlxsw_pci_fw_area_fini (mlxsw_pci); err_fw_area_init: +err_utc_nsec_bar: +err_utc_sec_bar: err_fr_rn_clk_bar: err_doorbell_page_bar: err_iface_rev:
@@ -1830,6 +1852,20 @@ static u32 mlxsw_pci_read_frc_l(void *bus_priv)return mlxsw_pci_read32_off (mlxsw_pci, frc_offset_l); } +static u32 mlxsw_pci_read_utc_sec (void *bus_priv) +{ +struct mlxsw_pci *mlxsw_pci = bus_priv; + +return mlxsw_pci_read32_off (mlxsw_pci, mlxsw_pci->utc_sec_offset); +} + +static u32 mlxsw_pci_read_utc_nsec (void *bus_priv) +{ +struct mlxsw_pci *mlxsw_pci = bus_priv; + +return mlxsw_pci_read32_off (mlxsw_pci, mlxsw_pci->utc_nsec_offset); +} +static const struct mlxsw_bus mlxsw_pci_bus = { .kind ="pci" , .init = mlxsw_pci_init,
@@ -1839,6 +1875,8 @@ static const struct mlxsw_bus mlxsw_pci_bus = { .cmd_exec = mlxsw_pci_cmd_exec, .read_frc_h = mlxsw_pci_read_frc_h, .read_frc_l = mlxsw_pci_read_frc_l, + .read_utc_sec = mlxsw_pci_read_utc_sec, + .read_utc_nsec = mlxsw_pci_read_utc_nsec, .features = MLXSW_BUS_F_TXRX | MLXSW_BUS_F_RESET, };
Signature · 1 line
2.36.1
Ido Schimmel
maintainerPATCH 5/9 mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations
In reply to Ido SchimmelFrom: Danielle Ratson <[email protected]>
Implement physical hardware clock operations. The main difference between the existing operations of Spectrum-1 and the new operations of Spectrum-2 is the usage of UTC hardware clock instead of FRC.
Add support for init() and fini() functions for PTP clock in Spectrum-2.
--- .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 147 ++++++++++++++++++ .../ethernet/mellanox/mlxsw/spectrum_ptp.h | 19 ++- 2 files changed, 159 insertions(+), 7 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c +147 -0
@@ -339,6 +339,153 @@ void mlxsw_sp1_ptp_clock_fini(struct mlxsw_sp_ptp_clock *clock_common)kfree (clock); } +static u64 mlxsw_sp2_ptp_read_utc (struct mlxsw_sp_ptp_clock *clock, +struct ptp_system_timestamp *sts) +{ +struct mlxsw_core *mlxsw_core = clock->core; +u32 utc_sec1, utc_sec2, utc_nsec; + + utc_sec1 =mlxsw_core_read_utc_sec (mlxsw_core); +ptp_read_system_prets (sts); + utc_nsec =mlxsw_core_read_utc_nsec (mlxsw_core); +ptp_read_system_postts (sts); + utc_sec2 =mlxsw_core_read_utc_sec (mlxsw_core); + +if (utc_sec1 != utc_sec2) { +/* Wrap around. */ +ptp_read_system_prets (sts); + utc_nsec =mlxsw_core_read_utc_nsec (mlxsw_core); +ptp_read_system_postts (sts); + } + +return (u64 )utc_sec2 *NSEC_PER_SEC + utc_nsec; +} + +static int +mlxsw_sp2_ptp_phc_settime (struct mlxsw_sp_ptp_clock *clock,u64 nsec) +{ +struct mlxsw_core *mlxsw_core = clock->core; +char mtutc_pl[MLXSW_REG_MTUTC_LEN ]; +u32 sec, nsec_rem; + + sec =div_u64_rem (nsec,NSEC_PER_SEC , &nsec_rem); +mlxsw_reg_mtutc_pack (mtutc_pl, +MLXSW_REG_MTUTC_OPERATION_SET_TIME_IMMEDIATE , +0 , sec, nsec_rem,0 ); +return mlxsw_reg_write (mlxsw_core,MLXSW_REG (mtutc), mtutc_pl); +} + +static int mlxsw_sp2_ptp_adjfine (struct ptp_clock_info *ptp,long scaled_ppm) +{ +struct mlxsw_sp_ptp_clock *clock = + container_of(ptp, struct mlxsw_sp_ptp_clock, ptp_info); +s32 ppb =scaled_ppm_to_ppb (scaled_ppm); + +/* In Spectrum-2 and newer ASICs, the frequency adjustment in MTUTC is +* reversed, positive values mean to decrease the frequency. Adjust the +* sign of PPB to this behavior. +*/ +return mlxsw_sp_ptp_phc_adjfreq (clock, -ppb); +} + +static int mlxsw_sp2_ptp_adjtime (struct ptp_clock_info *ptp,s64 delta) +{ +struct mlxsw_sp_ptp_clock *clock = + container_of(ptp, struct mlxsw_sp_ptp_clock, ptp_info); +struct mlxsw_core *mlxsw_core = clock->core; +char mtutc_pl[MLXSW_REG_MTUTC_LEN ]; + +/* HW time adjustment range is s16. If out of range, set time instead. */ +if (delta <S16_MIN || delta >S16_MAX ) { +u64 nsec; + + nsec =mlxsw_sp2_ptp_read_utc (clock,NULL ); + nsec += delta; + +return mlxsw_sp2_ptp_phc_settime (clock, nsec); + } + +mlxsw_reg_mtutc_pack (mtutc_pl, +MLXSW_REG_MTUTC_OPERATION_ADJUST_TIME , +0 ,0 ,0 , delta); +return mlxsw_reg_write (mlxsw_core,MLXSW_REG (mtutc), mtutc_pl); +} + +static int mlxsw_sp2_ptp_gettimex (struct ptp_clock_info *ptp, +struct timespec64 *ts, +struct ptp_system_timestamp *sts) +{ +struct mlxsw_sp_ptp_clock *clock = + container_of(ptp, struct mlxsw_sp_ptp_clock, ptp_info); +u64 nsec; + + nsec =mlxsw_sp2_ptp_read_utc (clock, sts); + *ts =ns_to_timespec64 (nsec); + +return 0 ; +} + +static int mlxsw_sp2_ptp_settime (struct ptp_clock_info *ptp, +const struct timespec64 *ts) +{ +struct mlxsw_sp_ptp_clock *clock = + container_of(ptp, struct mlxsw_sp_ptp_clock, ptp_info); +u64 nsec =timespec64_to_ns (ts); + +return mlxsw_sp2_ptp_phc_settime (clock, nsec); +} + +static const struct ptp_clock_info mlxsw_sp2_ptp_clock_info = { + .owner =THIS_MODULE , + .name ="mlxsw_sp_clock" , + .max_adj =MLXSW_REG_MTUTC_MAX_FREQ_ADJ , + .adjfine = mlxsw_sp2_ptp_adjfine, + .adjtime = mlxsw_sp2_ptp_adjtime, + .gettimex64 = mlxsw_sp2_ptp_gettimex, + .settime64 = mlxsw_sp2_ptp_settime, +}; + +struct mlxsw_sp_ptp_clock * +mlxsw_sp2_ptp_clock_init (struct mlxsw_sp *mlxsw_sp,struct device *dev) +{ +struct mlxsw_sp_ptp_clock *clock; +int err; + + clock =kzalloc (sizeof (*clock),GFP_KERNEL ); +if (!clock) +return ERR_PTR (-ENOMEM ); + + clock->core = mlxsw_sp->core; + + clock->ptp_info = mlxsw_sp2_ptp_clock_info; + + err =mlxsw_sp2_ptp_phc_settime (clock,0 ); +if (err) { +dev_err (dev,"setting UTC time failed %d\n" , err); + goto err_ptp_phc_settime; + } + + clock->ptp =ptp_clock_register (&clock->ptp_info, dev); +if (IS_ERR (clock->ptp)) { + err =PTR_ERR (clock->ptp); +dev_err (dev,"ptp_clock_register failed %d\n" , err); + goto err_ptp_clock_register; + } + +return clock; + +err_ptp_clock_register: +err_ptp_phc_settime: +kfree (clock); +return ERR_PTR (err); +} + +void mlxsw_sp2_ptp_clock_fini (struct mlxsw_sp_ptp_clock *clock) +{ +ptp_clock_unregister (clock->ptp); +kfree (clock); +} + static int mlxsw_sp_ptp_parse(struct sk_buff *skb, u8 *p_domain_number, u8 *p_message_type,
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h +12 -7
@@ -57,6 +57,11 @@ void mlxsw_sp1_get_stats_strings(u8 **p);void mlxsw_sp1_get_stats (struct mlxsw_sp_port *mlxsw_sp_port,u64 *data,int data_index); +struct mlxsw_sp_ptp_clock * +mlxsw_sp2_ptp_clock_init (struct mlxsw_sp *mlxsw_sp,struct device *dev); + +void mlxsw_sp2_ptp_clock_fini (struct mlxsw_sp_ptp_clock *clock); +struct mlxsw_sp_ptp_state *mlxsw_sp2_ptp_init (struct mlxsw_sp *mlxsw_sp);void mlxsw_sp2_ptp_fini (struct mlxsw_sp_ptp_state *ptp_state);
@@ -140,26 +145,26 @@ static inline void mlxsw_sp1_get_stats(struct mlxsw_sp_port *mlxsw_sp_port, { } -static inline struct mlxsw_sp_ptp_state * -mlxsw_sp2_ptp_init (struct mlxsw_sp *mlxsw_sp) +static inline struct mlxsw_sp_ptp_clock * +mlxsw_sp2_ptp_clock_init (struct mlxsw_sp *mlxsw_sp,struct device *dev) {return NULL ; } -static inline void mlxsw_sp2_ptp_fini (struct mlxsw_sp_ptp_state *ptp_state) +static inline void mlxsw_sp2_ptp_clock_fini (struct mlxsw_sp_ptp_clock *clock) { } -#endif -static inline struct mlxsw_sp_ptp_clock * -mlxsw_sp2_ptp_clock_init (struct mlxsw_sp *mlxsw_sp,struct device *dev) +static inline struct mlxsw_sp_ptp_state * +mlxsw_sp2_ptp_init (struct mlxsw_sp *mlxsw_sp) {return NULL ; } -static inline void mlxsw_sp2_ptp_clock_fini (struct mlxsw_sp_ptp_clock *clock) +static inline void mlxsw_sp2_ptp_fini (struct mlxsw_sp_ptp_state *ptp_state) { } +#endif static inline void mlxsw_sp2_ptp_receive (struct mlxsw_sp *mlxsw_sp,struct sk_buff *skb,u16 local_port)
Signature · 1 line
2.36.1
Ido Schimmel
maintainerPATCH 6/9 mlxsw: Send PTP packets as data packets to overcome a limitation
In reply to Ido SchimmelFrom: Danielle Ratson <[email protected]>
In Spectrum-2 and Spectrum-3, the correction field of PTP packets which are sent as control packets is not updated at egress port. To overcome this limitation, PTP packets which require time stamp, should be sent as data packets with the following details:
1. FID valid = 1
2. FID value above the maximum FID
3. rx_router_port = 1
Quoted 1 line
From Spectrum-4 and on, this limitation will be solved.
Extend the function which handles TX header, in case that the packet is a PTP packet, add TX header with type=data and all the above mentioned requirements. Add operation as part of 'struct mlxsw_sp_ptp_ops', to be able to separate the handling of PTP packets between different ASICs. Use the data packet solution only for Spectrum-2 and Spectrum-3. Therefore, add a dedicated operation structure for Spectrum-4, as it will be same to Spectrum-2 in PTP implementation, just will not have the limitation of control packets.
--- .../net/ethernet/mellanox/mlxsw/spectrum.c | 114 ++++++++++++++++-- .../net/ethernet/mellanox/mlxsw/spectrum.h | 10 ++ .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 34 ++++++ .../ethernet/mellanox/mlxsw/spectrum_ptp.h | 27 +++++ 4 files changed, 175 insertions(+), 10 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/spectrum.c +104 -10
@@ -29,6 +29,7 @@#include <net/pkt_cls.h> #include <net/netevent.h> #include <net/addrconf.h> +#include <linux/ptp_classify.h> #include "spectrum.h" #include "pci.h"
@@ -230,8 +231,8 @@ void mlxsw_sp_flow_counter_free(struct mlxsw_sp *mlxsw_sp, counter_index); } -static void mlxsw_sp_txhdr_construct (struct sk_buff *skb, -const struct mlxsw_tx_info *tx_info) +void mlxsw_sp_txhdr_construct (struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info) {char *txhdr =skb_push (skb,MLXSW_TXHDR_LEN );
@@ -246,6 +247,82 @@ static void mlxsw_sp_txhdr_construct(struct sk_buff *skb,mlxsw_tx_hdr_type_set (txhdr,MLXSW_TXHDR_TYPE_CONTROL ); } +int +mlxsw_sp_txhdr_ptp_data_construct (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info) +{ +char *txhdr; +u16 max_fid; +int err; + +if (skb_cow_head (skb,MLXSW_TXHDR_LEN )) { + err = -ENOMEM ; + goto err_skb_cow_head; + } + +if (!MLXSW_CORE_RES_VALID (mlxsw_core,FID )) { + err = -EIO ; + goto err_res_valid; + } + max_fid =MLXSW_CORE_RES_GET (mlxsw_core,FID ); + + txhdr =skb_push (skb,MLXSW_TXHDR_LEN ); +memset (txhdr,0 ,MLXSW_TXHDR_LEN ); + +mlxsw_tx_hdr_version_set (txhdr,MLXSW_TXHDR_VERSION_1 ); +mlxsw_tx_hdr_proto_set (txhdr,MLXSW_TXHDR_PROTO_ETH ); +mlxsw_tx_hdr_rx_is_router_set (txhdr, true); +mlxsw_tx_hdr_fid_valid_set (txhdr, true); +mlxsw_tx_hdr_fid_set (txhdr, max_fid + tx_info->local_port -1 ); +mlxsw_tx_hdr_type_set (txhdr,MLXSW_TXHDR_TYPE_DATA ); +return 0 ; + +err_res_valid: +err_skb_cow_head: +this_cpu_inc (mlxsw_sp_port->pcpu_stats->tx_dropped); +dev_kfree_skb_any (skb); +return err; +} + +static bool mlxsw_sp_skb_requires_ts (struct sk_buff *skb) +{ +unsigned int type; + +if (!(skb_shinfo (skb)->tx_flags &SKBTX_HW_TSTAMP )) +return false; + + type =ptp_classify_raw (skb); +return !!ptp_parse_header (skb, type); +} + +static int mlxsw_sp_txhdr_handle (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info) +{ +struct mlxsw_sp *mlxsw_sp =mlxsw_core_driver_priv (mlxsw_core); + +/* In Spectrum-2 and Spectrum-3, PTP events that require a time stamp +* need special handling and cannot be transmitted as regular control +* packets. +*/ +if (unlikely (mlxsw_sp_skb_requires_ts (skb))) +return mlxsw_sp->ptp_ops->txhdr_construct (mlxsw_core, + mlxsw_sp_port, skb, + tx_info); + +if (skb_cow_head (skb,MLXSW_TXHDR_LEN )) { +this_cpu_inc (mlxsw_sp_port->pcpu_stats->tx_dropped); +dev_kfree_skb_any (skb); +return -ENOMEM ; + } + +mlxsw_sp_txhdr_construct (skb, tx_info); +return 0 ; +} +enum mlxsw_reg_spms_state mlxsw_sp_stp_spms_state (u8 state) {switch (state) {
@@ -648,12 +725,6 @@ static netdev_tx_t mlxsw_sp_port_xmit(struct sk_buff *skb,u64 len;int err; -if (skb_cow_head (skb,MLXSW_TXHDR_LEN )) { -this_cpu_inc (mlxsw_sp_port->pcpu_stats->tx_dropped); -dev_kfree_skb_any (skb); -return NETDEV_TX_OK ; - } -memset (skb->cb,0 ,sizeof (struct mlxsw_skb_cb ));if (mlxsw_core_skb_transmit_busy (mlxsw_sp->core, &tx_info))
@@ -664,7 +735,11 @@ static netdev_tx_t mlxsw_sp_port_xmit(struct sk_buff *skb,return NETDEV_TX_OK ; } -mlxsw_sp_txhdr_construct (skb, &tx_info); + err =mlxsw_sp_txhdr_handle (mlxsw_sp->core, mlxsw_sp_port, skb, + &tx_info); +if (err) +return NETDEV_TX_OK ; +/* TX header is consumed by HW on the way so we shouldn't count its * bytes as being sent. */
@@ -2666,6 +2741,7 @@ static const struct mlxsw_sp_ptp_ops mlxsw_sp1_ptp_ops = { .get_stats_count = mlxsw_sp1_get_stats_count, .get_stats_strings = mlxsw_sp1_get_stats_strings, .get_stats = mlxsw_sp1_get_stats, + .txhdr_construct = mlxsw_sp_ptp_txhdr_construct, };static const struct mlxsw_sp_ptp_ops mlxsw_sp2_ptp_ops = {
@@ -2682,6 +2758,24 @@ static const struct mlxsw_sp_ptp_ops mlxsw_sp2_ptp_ops = { .get_stats_count = mlxsw_sp2_get_stats_count, .get_stats_strings = mlxsw_sp2_get_stats_strings, .get_stats = mlxsw_sp2_get_stats, + .txhdr_construct = mlxsw_sp2_ptp_txhdr_construct, +}; + +static const struct mlxsw_sp_ptp_ops mlxsw_sp4_ptp_ops = { + .clock_init = mlxsw_sp2_ptp_clock_init, + .clock_fini = mlxsw_sp2_ptp_clock_fini, + .init = mlxsw_sp2_ptp_init, + .fini = mlxsw_sp2_ptp_fini, + .receive = mlxsw_sp2_ptp_receive, + .transmitted = mlxsw_sp2_ptp_transmitted, + .hwtstamp_get = mlxsw_sp2_ptp_hwtstamp_get, + .hwtstamp_set = mlxsw_sp2_ptp_hwtstamp_set, + .shaper_work = mlxsw_sp2_ptp_shaper_work, + .get_ts_info = mlxsw_sp2_ptp_get_ts_info, + .get_stats_count = mlxsw_sp2_get_stats_count, + .get_stats_strings = mlxsw_sp2_get_stats_strings, + .get_stats = mlxsw_sp2_get_stats, + .txhdr_construct = mlxsw_sp_ptp_txhdr_construct, };struct mlxsw_sp_sample_trigger_node {
@@ -3327,7 +3421,7 @@ static int mlxsw_sp4_init(struct mlxsw_core *mlxsw_core, mlxsw_sp->sb_vals = &mlxsw_sp2_sb_vals; mlxsw_sp->sb_ops = &mlxsw_sp3_sb_ops; mlxsw_sp->port_type_speed_ops = &mlxsw_sp2_port_type_speed_ops; - mlxsw_sp->ptp_ops = &mlxsw_sp2_ptp_ops; + mlxsw_sp->ptp_ops = &mlxsw_sp4_ptp_ops; mlxsw_sp->span_ops = &mlxsw_sp3_span_ops; mlxsw_sp->policer_core_ops = &mlxsw_sp2_policer_core_ops; mlxsw_sp->trap_ops = &mlxsw_sp2_trap_ops;
drivers/net/ethernet/mellanox/mlxsw/spectrum.h +10 -0
@@ -243,6 +243,10 @@ struct mlxsw_sp_ptp_ops {void (*get_stats_strings)(u8 **p);void (*get_stats)(struct mlxsw_sp_port *mlxsw_sp_port,u64 *data,int data_index); +int (*txhdr_construct)(struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info); }; static inline struct mlxsw_sp_upper *
@@ -700,6 +704,12 @@ int mlxsw_sp_flow_counter_alloc(struct mlxsw_sp *mlxsw_sp, unsigned int *p_counter_index);void mlxsw_sp_flow_counter_free (struct mlxsw_sp *mlxsw_sp,unsigned int counter_index); +void mlxsw_sp_txhdr_construct (struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info); +int mlxsw_sp_txhdr_ptp_data_construct (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info);bool mlxsw_sp_port_dev_check (const struct net_device *dev);struct mlxsw_sp *mlxsw_sp_lower_get (struct net_device *dev);struct mlxsw_sp_port *mlxsw_sp_port_dev_lower_find (struct net_device *dev);
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c +34 -0
@@ -1385,3 +1385,37 @@ void mlxsw_sp2_ptp_fini(struct mlxsw_sp_ptp_state *ptp_state_common)mlxsw_sp_ptp_traps_unset (mlxsw_sp);kfree (ptp_state); } + +int mlxsw_sp_ptp_txhdr_construct (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info) +{ +mlxsw_sp_txhdr_construct (skb, tx_info); +return 0 ; +} + +int mlxsw_sp2_ptp_txhdr_construct (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info) +{ +/* In Spectrum-2 and Spectrum-3, in order for PTP event packets to have +* their correction field correctly set on the egress port they must be +* transmitted as data packets. Such packets ingress the ASIC via the +* CPU port and must have a VLAN tag, as the CPU port is not configured +* with a PVID. Push the default VLAN (4095), which is configured as +* egress untagged on all the ports. +*/ +if (!skb_vlan_tagged (skb)) { + skb =vlan_insert_tag_set_proto (skb,htons (ETH_P_8021Q ), +MLXSW_SP_DEFAULT_VID ); +if (!skb) { +this_cpu_inc (mlxsw_sp_port->pcpu_stats->tx_dropped); +return -ENOMEM ; + } + } + +return mlxsw_sp_txhdr_ptp_data_construct (mlxsw_core, mlxsw_sp_port, skb, + tx_info); +}
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h +27 -0
@@ -57,6 +57,11 @@ void mlxsw_sp1_get_stats_strings(u8 **p);void mlxsw_sp1_get_stats (struct mlxsw_sp_port *mlxsw_sp_port,u64 *data,int data_index); +int mlxsw_sp_ptp_txhdr_construct (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info); +struct mlxsw_sp_ptp_clock *mlxsw_sp2_ptp_clock_init (struct mlxsw_sp *mlxsw_sp,struct device *dev);
@@ -65,6 +70,12 @@ void mlxsw_sp2_ptp_clock_fini(struct mlxsw_sp_ptp_clock *clock);struct mlxsw_sp_ptp_state *mlxsw_sp2_ptp_init (struct mlxsw_sp *mlxsw_sp);void mlxsw_sp2_ptp_fini (struct mlxsw_sp_ptp_state *ptp_state); + +int mlxsw_sp2_ptp_txhdr_construct (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info); +#else static inline struct mlxsw_sp_ptp_clock *
@@ -145,6 +156,14 @@ static inline void mlxsw_sp1_get_stats(struct mlxsw_sp_port *mlxsw_sp_port, { } +int mlxsw_sp_ptp_txhdr_construct (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info) +{ +return -EOPNOTSUPP ; +} +static inline struct mlxsw_sp_ptp_clock *mlxsw_sp2_ptp_clock_init (struct mlxsw_sp *mlxsw_sp,struct device *dev) {
@@ -164,6 +183,14 @@ mlxsw_sp2_ptp_init(struct mlxsw_sp *mlxsw_sp)static inline void mlxsw_sp2_ptp_fini (struct mlxsw_sp_ptp_state *ptp_state) { } + +int mlxsw_sp2_ptp_txhdr_construct (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info) +{ +return -EOPNOTSUPP ; +}#endif static inline void mlxsw_sp2_ptp_receive(struct mlxsw_sp *mlxsw_sp,
Signature · 1 line
2.36.1
Ido Schimmel
maintainerPATCH 7/9 mlxsw: spectrum: Support time stamping on Spectrum-2
In reply to Ido SchimmelFrom: Danielle Ratson <[email protected]>
As opposed to Spectrum-1, in which time stamps arrive through a pair of dedicated events into a queue and later are being matched to the corresponding packets, in Spectrum-2 we are reading the time stamps directly from the CQE. Software can get the time stamp in UTC format using CQEv2.
Add a time stamp field to 'struct mlxsw_skb_cb'. In mlxsw_pci_cqe_{rdq,sdq}_handle() extract the time stamp from the CQE into the new time stamp field. Note that the time stamp in the CQE is represented by 38 bits, which is a short representation of UTC time. Software should create the full time stamp using the global UTC clock. Read UTC clock from hardware only for PTP packets which were trapped to CPU with PTP0 trap ID (event packets).
Use the time stamp from the SKB when packet is received or transmitted.
--- drivers/net/ethernet/mellanox/mlxsw/core.h | 6 ++ drivers/net/ethernet/mellanox/mlxsw/pci.c | 22 ++++++- .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 62 +++++++++++++++++++ .../ethernet/mellanox/mlxsw/spectrum_ptp.h | 24 ++++--- 4 files changed, 104 insertions(+), 10 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/core.h +6 -0
@@ -558,11 +558,17 @@ enum mlxsw_devlink_param_id { MLXSW_DEVLINK_PARAM_ID_ACL_REGION_REHASH_INTERVAL, }; +struct mlxsw_cqe_ts { +u8 sec; +u32 nsec; +}; +struct mlxsw_skb_cb {union {struct mlxsw_tx_info tx_info;struct mlxsw_rx_md_info rx_md_info; }; +struct mlxsw_cqe_ts cqe_ts; };static inline struct mlxsw_skb_cb *mlxsw_skb_cb (struct sk_buff *skb)
drivers/net/ethernet/mellanox/mlxsw/pci.c +21 -1
@@ -513,9 +513,26 @@ static unsigned int mlxsw_pci_read32_off(struct mlxsw_pci *mlxsw_pci,return ioread32be (mlxsw_pci->hw_addr + off); } +static void mlxsw_pci_skb_cb_ts_set (struct mlxsw_pci *mlxsw_pci, +struct sk_buff *skb, +enum mlxsw_pci_cqe_v cqe_v,char *cqe) +{ +if (cqe_v !=MLXSW_PCI_CQE_V2 ) +return ; + +if (mlxsw_pci_cqe2_time_stamp_type_get (cqe) != +MLXSW_PCI_CQE_TIME_STAMP_TYPE_UTC ) +return ; + +mlxsw_skb_cb (skb)->cqe_ts.sec =mlxsw_pci_cqe2_time_stamp_sec_get (cqe); +mlxsw_skb_cb (skb)->cqe_ts.nsec = +mlxsw_pci_cqe2_time_stamp_nsec_get (cqe); +} +static void mlxsw_pci_cqe_sdq_handle (struct mlxsw_pci *mlxsw_pci,struct mlxsw_pci_queue *q,u16 consumer_counter_limit, +enum mlxsw_pci_cqe_v cqe_v,char *cqe) {struct pci_dev *pdev = mlxsw_pci->pdev;
@@ -535,6 +552,7 @@ static void mlxsw_pci_cqe_sdq_handle(struct mlxsw_pci *mlxsw_pci,if (unlikely (!tx_info.is_emad &&skb_shinfo (skb)->tx_flags &SKBTX_HW_TSTAMP )) { +mlxsw_pci_skb_cb_ts_set (mlxsw_pci, skb, cqe_v, cqe);mlxsw_core_ptp_transmitted (mlxsw_pci->core, skb, tx_info.local_port); skb =NULL ;
@@ -655,6 +673,8 @@ static void mlxsw_pci_cqe_rdq_handle(struct mlxsw_pci *mlxsw_pci,mlxsw_pci_cqe_rdq_md_tx_port_init (skb, cqe); } +mlxsw_pci_skb_cb_ts_set (mlxsw_pci, skb, cqe_v, cqe); + byte_count =mlxsw_pci_cqe_byte_count_get (cqe);if (mlxsw_pci_cqe_crc_get (cqe_v, cqe)) byte_count -=ETH_FCS_LEN ;
@@ -706,7 +726,7 @@ static void mlxsw_pci_cq_tasklet(struct tasklet_struct *t) sdq =mlxsw_pci_sdq_get (mlxsw_pci, dqn);mlxsw_pci_cqe_sdq_handle (mlxsw_pci, sdq, - wqe_counter, ncqe); + wqe_counter, q->u.cq.v, ncqe); q->u.cq.comp_sdq_count++; }else {struct mlxsw_pci_queue *rdq;
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c +62 -0
68 lines not on this page · raw message
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h +15 -9
@@ -71,6 +71,12 @@ struct mlxsw_sp_ptp_state *mlxsw_sp2_ptp_init(struct mlxsw_sp *mlxsw_sp);void mlxsw_sp2_ptp_fini (struct mlxsw_sp_ptp_state *ptp_state); +void mlxsw_sp2_ptp_receive (struct mlxsw_sp *mlxsw_sp,struct sk_buff *skb, +u16 local_port); + +void mlxsw_sp2_ptp_transmitted (struct mlxsw_sp *mlxsw_sp, +struct sk_buff *skb,u16 local_port); + int mlxsw_sp2_ptp_txhdr_construct(struct mlxsw_core *mlxsw_core, struct mlxsw_sp_port *mlxsw_sp_port, struct sk_buff *skb,
@@ -184,15 +190,6 @@ static inline void mlxsw_sp2_ptp_fini(struct mlxsw_sp_ptp_state *ptp_state) { } -int mlxsw_sp2_ptp_txhdr_construct (struct mlxsw_core *mlxsw_core, -struct mlxsw_sp_port *mlxsw_sp_port, -struct sk_buff *skb, -const struct mlxsw_tx_info *tx_info) -{ -return -EOPNOTSUPP ; -} -#endif -static inline void mlxsw_sp2_ptp_receive (struct mlxsw_sp *mlxsw_sp,struct sk_buff *skb,u16 local_port) {
@@ -205,6 +202,15 @@ static inline void mlxsw_sp2_ptp_transmitted(struct mlxsw_sp *mlxsw_sp, dev_kfree_skb_any(skb); } +int mlxsw_sp2_ptp_txhdr_construct (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info) +{ +return -EOPNOTSUPP ; +} +#endif +static inline int mlxsw_sp2_ptp_hwtstamp_get (struct mlxsw_sp_port *mlxsw_sp_port,struct hwtstamp_config *config)
Signature · 1 line
2.36.1
Ido Schimmel
maintainerPATCH 8/9 mlxsw: spectrum_ptp: Support SIOCGHWTSTAMP, SIOCSHWTSTAMP ioctls
In reply to Ido SchimmelFrom: Danielle Ratson <[email protected]>
The SIOCSHWTSTAMP ioctl configures HW timestamping on a given port. In Spectrum-2 and above, each packet gets time stamp by default, but in order to provide an accurate time stamp, software should configure to update the correction field. In addition, the PTP traps are not enabled by default, software should enable it per port or for all ports.
The switch behaves like a transparent clock between CPU port and each front panel port. If ingress correction is set on a port for a given packet type, then when such a packet is received via the port, the current time stamp is subtracted from the correction field. If egress correction is set on a port for a given packet type, then when such a packet is transmitted via the port, the current time stamp is added to the correction field.
The result is that as the packet ingresses through a port with ingress correction enabled, and egresses through a port with egress correction enabled, the PTP correction field is updated to reflect the time that the packet spent in the ASIC.
This can be used to update the correction field of trapped packets by enabling ingress correction on a port where time stamping was enabled, and egress correction on the CPU port. Similarly, for packets transmitted from the host, ingress correction should be enabled on the CPU port, and egress correction on a front-panel port.
However, since the correction fields will be updated for all PTP packets crossing the CPU port, in order not to mangle the correction field, the front panel port involved in the packet transfer must have the corresponding correction enabled as well.
Therefore, when HW timestamping is enabled on at least one port, we have to configure hardware to update the correction field and trap PTP event packets on all ports.
Add reference count as part of 'struct mlxsw_sp_ptp_state', to maintain how many ports use HW timestamping. Handle the correction field configuration only when the first port enables time stamping and when the last port disables time stamping. Store the configuration as part of 'struct mlxsw_sp_ptp_state', as it is global for all ports.
The SIOCGHWTSTAMP ioctl is a getter for the current configuration, implement it and use the global configuration.
--- .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 208 ++++++++++++++++++ .../ethernet/mellanox/mlxsw/spectrum_ptp.h | 24 +- 2 files changed, 223 insertions(+), 9 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c +208 -0
@@ -11,6 +11,7 @@#include <linux/if_ether.h> #include <linux/if_vlan.h> #include <linux/net_tstamp.h> +#include <linux/refcount.h> #include "spectrum.h" #include "spectrum_ptp.h"
@@ -41,6 +42,10 @@ struct mlxsw_sp1_ptp_state {struct mlxsw_sp2_ptp_state {struct mlxsw_sp_ptp_state common; +refcount_t ptp_port_enabled_ref;/* Number of ports with time stamping +* enabled. +*/ +struct hwtstamp_config config; };struct mlxsw_sp1_ptp_key {
@@ -1368,6 +1373,7 @@ struct mlxsw_sp_ptp_state *mlxsw_sp2_ptp_init(struct mlxsw_sp *mlxsw_sp)if (err) goto err_ptp_traps_set; +refcount_set (&ptp_state->ptp_port_enabled_ref,0 );return &ptp_state->common; err_ptp_traps_set:
@@ -1448,6 +1454,208 @@ void mlxsw_sp2_ptp_transmitted(struct mlxsw_sp *mlxsw_sp,dev_kfree_skb_any (skb); } +int mlxsw_sp2_ptp_hwtstamp_get (struct mlxsw_sp_port *mlxsw_sp_port, +struct hwtstamp_config *config) +{ +struct mlxsw_sp2_ptp_state *ptp_state; + + ptp_state =mlxsw_sp2_ptp_state (mlxsw_sp_port->mlxsw_sp); + + *config = ptp_state->config; +return 0 ; +} + +static int +mlxsw_sp2_ptp_get_message_types (const struct hwtstamp_config *config, +u16 *p_ing_types,u16 *p_egr_types, +enum hwtstamp_rx_filters *p_rx_filter) +{ +enum hwtstamp_rx_filters rx_filter = config->rx_filter; +enum hwtstamp_tx_types tx_type = config->tx_type; +u16 ing_types =0x00 ; +u16 egr_types =0x00 ; + + *p_rx_filter = rx_filter; + +switch (rx_filter) { +case HWTSTAMP_FILTER_NONE : + ing_types =0x00 ; +break ; +case HWTSTAMP_FILTER_PTP_V1_L4_SYNC : +case HWTSTAMP_FILTER_PTP_V2_L4_SYNC : +case HWTSTAMP_FILTER_PTP_V2_L2_SYNC : +case HWTSTAMP_FILTER_PTP_V2_SYNC : +case HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ : +case HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ : +case HWTSTAMP_FILTER_PTP_V2_L2_DELAY_REQ : +case HWTSTAMP_FILTER_PTP_V2_DELAY_REQ : +case HWTSTAMP_FILTER_PTP_V1_L4_EVENT : +case HWTSTAMP_FILTER_PTP_V2_L4_EVENT : +case HWTSTAMP_FILTER_PTP_V2_L2_EVENT : +case HWTSTAMP_FILTER_PTP_V2_EVENT : +/* In Spectrum-2 and above, all packets get time stamp by +* default and the driver fill the time stamp only for event +* packets. Return all event types even if only specific types +* were required. +*/ + ing_types =0x0f ; + *p_rx_filter =HWTSTAMP_FILTER_SOME ; +break ; +case HWTSTAMP_FILTER_ALL : +case HWTSTAMP_FILTER_SOME : +case HWTSTAMP_FILTER_NTP_ALL : +return -ERANGE ; +default : +return -EINVAL ; + } + +switch (tx_type) { +case HWTSTAMP_TX_OFF : + egr_types =0x00 ; +break ; +case HWTSTAMP_TX_ON : + egr_types =0x0f ; +break ; +case HWTSTAMP_TX_ONESTEP_SYNC : +case HWTSTAMP_TX_ONESTEP_P2P : +return -ERANGE ; +default : +return -EINVAL ; + } + + *p_ing_types = ing_types; + *p_egr_types = egr_types; +return 0 ; +} + +static int mlxsw_sp2_ptp_mtpcpc_set (struct mlxsw_sp *mlxsw_sp,bool ptp_trap_en, +u16 ing_types,u16 egr_types) +{ +char mtpcpc_pl[MLXSW_REG_MTPCPC_LEN ]; + +mlxsw_reg_mtpcpc_pack (mtpcpc_pl, false,0 , ptp_trap_en, ing_types, + egr_types); +return mlxsw_reg_write (mlxsw_sp->core,MLXSW_REG (mtpcpc), mtpcpc_pl); +} + +static int mlxsw_sp2_ptp_enable (struct mlxsw_sp *mlxsw_sp,u16 ing_types, +u16 egr_types, +struct hwtstamp_config new_config) +{ +struct mlxsw_sp2_ptp_state *ptp_state =mlxsw_sp2_ptp_state (mlxsw_sp); +int err; + + err =mlxsw_sp2_ptp_mtpcpc_set (mlxsw_sp, true, ing_types, egr_types); +if (err) +return err; + + ptp_state->config = new_config; +return 0 ; +} + +static int mlxsw_sp2_ptp_disable (struct mlxsw_sp *mlxsw_sp, +struct hwtstamp_config new_config) +{ +struct mlxsw_sp2_ptp_state *ptp_state =mlxsw_sp2_ptp_state (mlxsw_sp); +int err; + + err =mlxsw_sp2_ptp_mtpcpc_set (mlxsw_sp, false,0 ,0 ); +if (err) +return err; + + ptp_state->config = new_config; +return 0 ; +} + +static int mlxsw_sp2_ptp_configure_port (struct mlxsw_sp_port *mlxsw_sp_port, +u16 ing_types,u16 egr_types, +struct hwtstamp_config new_config) +{ +struct mlxsw_sp2_ptp_state *ptp_state; +int err; + +ASSERT_RTNL (); + + ptp_state =mlxsw_sp2_ptp_state (mlxsw_sp_port->mlxsw_sp); + +if (refcount_inc_not_zero (&ptp_state->ptp_port_enabled_ref)) +return 0 ; + + err =mlxsw_sp2_ptp_enable (mlxsw_sp_port->mlxsw_sp, ing_types, + egr_types, new_config); +if (err) +return err; + +refcount_set (&ptp_state->ptp_port_enabled_ref,1 ); + +return 0 ; +} + +static int mlxsw_sp2_ptp_deconfigure_port (struct mlxsw_sp_port *mlxsw_sp_port, +struct hwtstamp_config new_config) +{ +struct mlxsw_sp2_ptp_state *ptp_state; +int err; + +ASSERT_RTNL (); + + ptp_state =mlxsw_sp2_ptp_state (mlxsw_sp_port->mlxsw_sp); + +if (!refcount_dec_and_test (&ptp_state->ptp_port_enabled_ref)) +return 0 ; + + err =mlxsw_sp2_ptp_disable (mlxsw_sp_port->mlxsw_sp, new_config); +if (err) + goto err_ptp_disable; + +return 0 ; + +err_ptp_disable: +refcount_set (&ptp_state->ptp_port_enabled_ref,1 ); +return err; +} + +int mlxsw_sp2_ptp_hwtstamp_set (struct mlxsw_sp_port *mlxsw_sp_port, +struct hwtstamp_config *config) +{ +enum hwtstamp_rx_filters rx_filter; +struct hwtstamp_config new_config; +u16 new_ing_types, new_egr_types; +bool ptp_enabled; +int err; + + err =mlxsw_sp2_ptp_get_message_types (config, &new_ing_types, + &new_egr_types, &rx_filter); +if (err) +return err; + + new_config.flags = config->flags; + new_config.tx_type = config->tx_type; + new_config.rx_filter = rx_filter; + + ptp_enabled = mlxsw_sp_port->ptp.ing_types || + mlxsw_sp_port->ptp.egr_types; + +if ((new_ing_types || new_egr_types) && !ptp_enabled) { + err =mlxsw_sp2_ptp_configure_port (mlxsw_sp_port, new_ing_types, + new_egr_types, new_config); +if (err) +return err; + }else if (!new_ing_types && !new_egr_types && ptp_enabled) { + err =mlxsw_sp2_ptp_deconfigure_port (mlxsw_sp_port, new_config); +if (err) +return err; + } + + mlxsw_sp_port->ptp.ing_types = new_ing_types; + mlxsw_sp_port->ptp.egr_types = new_egr_types; + +/* Notify the ioctl caller what we are actually timestamping. */ + config->rx_filter = rx_filter; + +return 0 ; +} + int mlxsw_sp_ptp_txhdr_construct(struct mlxsw_core *mlxsw_core, struct mlxsw_sp_port *mlxsw_sp_port, struct sk_buff *skb,
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h +15 -9
@@ -77,6 +77,12 @@ void mlxsw_sp2_ptp_receive(struct mlxsw_sp *mlxsw_sp, struct sk_buff *skb,void mlxsw_sp2_ptp_transmitted (struct mlxsw_sp *mlxsw_sp,struct sk_buff *skb,u16 local_port); +int mlxsw_sp2_ptp_hwtstamp_get (struct mlxsw_sp_port *mlxsw_sp_port, +struct hwtstamp_config *config); + +int mlxsw_sp2_ptp_hwtstamp_set (struct mlxsw_sp_port *mlxsw_sp_port, +struct hwtstamp_config *config); + int mlxsw_sp2_ptp_txhdr_construct(struct mlxsw_core *mlxsw_core, struct mlxsw_sp_port *mlxsw_sp_port, struct sk_buff *skb,
@@ -202,15 +208,6 @@ static inline void mlxsw_sp2_ptp_transmitted(struct mlxsw_sp *mlxsw_sp,dev_kfree_skb_any (skb); } -int mlxsw_sp2_ptp_txhdr_construct (struct mlxsw_core *mlxsw_core, -struct mlxsw_sp_port *mlxsw_sp_port, -struct sk_buff *skb, -const struct mlxsw_tx_info *tx_info) -{ -return -EOPNOTSUPP ; -} -#endif -static inline int mlxsw_sp2_ptp_hwtstamp_get (struct mlxsw_sp_port *mlxsw_sp_port,struct hwtstamp_config *config)
@@ -225,6 +222,15 @@ mlxsw_sp2_ptp_hwtstamp_set(struct mlxsw_sp_port *mlxsw_sp_port, return -EOPNOTSUPP; } +int mlxsw_sp2_ptp_txhdr_construct (struct mlxsw_core *mlxsw_core, +struct mlxsw_sp_port *mlxsw_sp_port, +struct sk_buff *skb, +const struct mlxsw_tx_info *tx_info) +{ +return -EOPNOTSUPP ; +} +#endif +static inline void mlxsw_sp2_ptp_shaper_work (struct work_struct *work) { }
Signature · 1 line
2.36.1
Ido Schimmel
maintainerPATCH 9/9 mlxsw: spectrum: Support ethtool 'get_ts_info' callback in Spectrum-2
In reply to Ido SchimmelFrom: Danielle Ratson <[email protected]>
The 'get_ts_info' callback is used for obtaining information about time stamping and PTP hardware clock capabilities of a network device.
The existing function of Spectrum-1 is used to advertise the PHC capabilities and the supported RX and TX filters. Implement a similar function for Spectrum-2, expose that the supported 'rx_filters' are all PTP event packets, as for these packets the driver fills the time stamp from the CQE in the SKB.
In the future, mlxsw driver will be extended to support one-step PTP in Spectrum-2 and newer ASICs. Then additional 'tx_types' will be supported.
--- .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 19 +++++++++++++++++++ .../ethernet/mellanox/mlxsw/spectrum_ptp.h | 15 +++++++++------ 2 files changed, 28 insertions(+), 6 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c +19 -0
@@ -1656,6 +1656,25 @@ int mlxsw_sp2_ptp_hwtstamp_set(struct mlxsw_sp_port *mlxsw_sp_port,return 0 ; } +int mlxsw_sp2_ptp_get_ts_info (struct mlxsw_sp *mlxsw_sp, +struct ethtool_ts_info *info) +{ + info->phc_index =ptp_clock_index (mlxsw_sp->clock->ptp); + + info->so_timestamping =SOF_TIMESTAMPING_TX_HARDWARE | +SOF_TIMESTAMPING_RX_HARDWARE | +SOF_TIMESTAMPING_RAW_HARDWARE ; + + info->tx_types =BIT (HWTSTAMP_TX_OFF ) | +BIT (HWTSTAMP_TX_ON ); + + info->rx_filters =BIT (HWTSTAMP_FILTER_NONE ) | +BIT (HWTSTAMP_FILTER_PTP_V1_L4_EVENT ) | +BIT (HWTSTAMP_FILTER_PTP_V2_EVENT ); + +return 0 ; +} + int mlxsw_sp_ptp_txhdr_construct(struct mlxsw_core *mlxsw_core, struct mlxsw_sp_port *mlxsw_sp_port, struct sk_buff *skb,
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h +9 -6
@@ -83,6 +83,9 @@ int mlxsw_sp2_ptp_hwtstamp_get(struct mlxsw_sp_port *mlxsw_sp_port,int mlxsw_sp2_ptp_hwtstamp_set (struct mlxsw_sp_port *mlxsw_sp_port,struct hwtstamp_config *config); +int mlxsw_sp2_ptp_get_ts_info (struct mlxsw_sp *mlxsw_sp, +struct ethtool_ts_info *info); + int mlxsw_sp2_ptp_txhdr_construct(struct mlxsw_core *mlxsw_core, struct mlxsw_sp_port *mlxsw_sp_port, struct sk_buff *skb,
@@ -222,6 +225,12 @@ mlxsw_sp2_ptp_hwtstamp_set(struct mlxsw_sp_port *mlxsw_sp_port,return -EOPNOTSUPP ; } +static inline int mlxsw_sp2_ptp_get_ts_info (struct mlxsw_sp *mlxsw_sp, +struct ethtool_ts_info *info) +{ +return mlxsw_sp_ptp_get_ts_info_noptp (info); +} + int mlxsw_sp2_ptp_txhdr_construct(struct mlxsw_core *mlxsw_core, struct mlxsw_sp_port *mlxsw_sp_port, struct sk_buff *skb,
@@ -235,12 +244,6 @@ static inline void mlxsw_sp2_ptp_shaper_work(struct work_struct *work) { } -static inline int mlxsw_sp2_ptp_get_ts_info (struct mlxsw_sp *mlxsw_sp, -struct ethtool_ts_info *info) -{ -return mlxsw_sp_ptp_get_ts_info_noptp (info); -} -static inline int mlxsw_sp2_get_stats_count (void ) {return 0 ;
Signature · 1 line
2.36.1
Quoted 3 lines · Ido Schimmel
Spectrum-2 and newer ASICs essentially implement a transparent clock between all the switch ports, including the CPU port. The hardware will generate the UTC time stamp for transmitted / received packets at the
The PTP time scale is TAI, not UTC.
Quoted 3 lines
CPU port, but will compensate for forwarding delays in the ASIC by adjusting the correction field in the PTP header (for PTP events) at the ingress and egress ports.
If the switch adjusts this automatcally, then the time scale in use is not relevant.
Thanks,
Richard
Ido Schimmel
maintainerQuoted 6 lines · Richard Cochran
Quoted 3 lines · Ido Schimmel
Spectrum-2 and newer ASICs essentially implement a transparent clock between all the switch ports, including the CPU port. The hardware will generate the UTC time stamp for transmitted / received packets at the
Quoted 8 lines
The PTP time scale is TAI, not UTC.
Quoted 3 lines
CPU port, but will compensate for forwarding delays in the ASIC by adjusting the correction field in the PTP header (for PTP events) at the ingress and egress ports.
If the switch adjusts this automatcally, then the time scale in use is not relevant.
It is adjusted automatically by hardware. Software only needs to enable it.
Quoted 3 lines · Ido Schimmel
Specifically, the hardware will subtract the current time stamp from the correction field at the ingress port and will add the current time stamp to the correction field at the egress port.
Doing this in pure HW TC mode, the time scale of the switch's clock does not matter at all. It can be a free running counter.
Quoted 4 lines
For the purpose of an
ordinary or boundary clock (this patchset), the correction field will always be adjusted between the CPU port and one of the front panel ports, but never between two front panel ports.
To clarify, the only reason why you say "never between two front panel ports" is because the switch will configured not to forward PTP frames over the front panel ports, for BC mode. For TC operation, the switch will apply the correction, right?
Thanks,
Richard
Ido Schimmel
maintainerQuoted 8 lines · Richard Cochran
Quoted 3 lines · Ido Schimmel
Specifically, the hardware will subtract the current time stamp from the correction field at the ingress port and will add the current time stamp to the correction field at the egress port.
Doing this in pure HW TC mode, the time scale of the switch's clock does not matter at all. It can be a free running counter.
It is done in hardware.
Quoted 10 lines
Quoted 5 lines
For the purpose of an
ordinary or boundary clock (this patchset), the correction field will always be adjusted between the CPU port and one of the front panel ports, but never between two front panel ports.To clarify, the only reason why you say "never between two front panel ports" is because the switch will configured not to forward PTP frames over the front panel ports, for BC mode. For TC operation, the switch will apply the correction, right?
Right. The hardware can support a TC operation, but I did not find any Linux interfaces to configure it (did I miss something?) nor got any requirements to support it at the moment.
Quoted 3 lines · Ido Schimmel
Right. The hardware can support a TC operation, but I did not find any Linux interfaces to configure it (did I miss something?) nor got any requirements to support it at the moment.
linuxptp can operate as a TC, but it sounds like your HW does E2E TC without any software support.
P2P TC does need SW support, because the ports must generate peer delay requests.
Thanks,
Richard
Ido Schimmel
maintainerQuoted 8 lines · Richard Cochran
Quoted 3 lines · Ido Schimmel
Right. The hardware can support a TC operation, but I did not find any Linux interfaces to configure it (did I miss something?) nor got any requirements to support it at the moment.
linuxptp can operate as a TC, but it sounds like your HW does E2E TC without any software support.
Yes. I believe linuxptp only implements a two-step transparent clock, whereas the hardware supports a one-step transparent clock. Like I said, I'm not aware of any requirements for that at the moment, but I imagine we would need a per-netdev interface to instruct the kernel/hardware to adjust the correction field at ingress/egress for specific message types.
Quoted 3 lines
P2P TC does need SW support, because the ports must generate peer delay requests.
Right. The hardware has the ability to add/reduce a number of nanoseconds (that it gets from software) from the computed latency on a per-port and ingress/egress basis.
Quoted 3 lines
Thanks,
Richard
This series was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Quoted 4 lines · On Wed, 27 Jul 2022 09:23:19 +0300 you wrote:
This patchset adds PTP support for Spectrum-{2,3,4} switch ASICs. They all act largely the same with respect to PTP except for a workaround implemented for Spectrum-{2,3} in patch #6.
Quoted 8 lines
Spectrum-2 and newer ASICs essentially implement a transparent clock between all the switch ports, including the CPU port. The hardware will generate the UTC time stamp for transmitted / received packets at the CPU port, but will compensate for forwarding delays in the ASIC by adjusting the correction field in the PTP header (for PTP events) at the ingress and egress ports.
[...]
Here is the summary with links:
- [net-next,1/9] mlxsw: spectrum_ptp: Add helper functions to configure PTP traps
https://git.kernel.org/netdev/net-next/c/37b62b282b18 - [net-next,2/9] mlxsw: Support CQEv2 for SDQ in Spectrum-2 and newer ASICs https://git.kernel.org/netdev/net-next/c/42823208b946 - [net-next,3/9] mlxsw: spectrum_ptp: Add PTP initialization / finalization for Spectrum-2 https://git.kernel.org/netdev/net-next/c/d25ff63a181b - [net-next,4/9] mlxsw: Query UTC sec and nsec PCI offsets and values https://git.kernel.org/netdev/net-next/c/bbd300570a9e - [net-next,5/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations https://git.kernel.org/netdev/net-next/c/a5bf8e5e8b8d - [net-next,6/9] mlxsw: Send PTP packets as data packets to overcome a limitation https://git.kernel.org/netdev/net-next/c/24157bc69f45 - [net-next,7/9] mlxsw: spectrum: Support time stamping on Spectrum-2 https://git.kernel.org/netdev/net-next/c/382ad0d95793 - [net-next,8/9] mlxsw: spectrum_ptp: Support SIOCGHWTSTAMP, SIOCSHWTSTAMP ioctls https://git.kernel.org/netdev/net-next/c/08ef8bc825d9 - [net-next,9/9] mlxsw: spectrum: Support ethtool 'get_ts_info' callback in Spectrum-2 https://git.kernel.org/netdev/net-next/c/eba28aaf2f53
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html