vmxnet3: do not reschedule napi for rx processing
Subsystems (3)
PATCH 1/1 vmxnet3: do not reschedule napi for rx processing
Commit '2c5a5748105a ("vmxnet3: add support for out of order rx completion")' added support for out of order rx completion. Within that patch, an enhancement was done to reschedule napi for processing rx completions.
However, it can lead to missing an interrupt. So, this patch reverts that part of the code.
--- drivers/net/vmxnet3/vmxnet3_drv.c | 9 --------- 1 file changed, 9 deletions(-)
drivers/net/vmxnet3/vmxnet3_drv.c +0 -9
@@ -2075,17 +2075,8 @@ vmxnet3_poll_rx_only(struct napi_struct *napi, int budget) rxd_done =vmxnet3_rq_rx_complete (rq, adapter, budget);if (rxd_done < budget) { -struct Vmxnet3_RxCompDesc *rcd; -#ifdef __BIG_ENDIAN_BITFIELD -struct Vmxnet3_RxCompDesc rxComp; -#endif napi_complete_done (napi, rxd_done);vmxnet3_enable_intr (adapter, rq->comp_ring.intr_idx); -/* after unmasking the interrupt, check if any descriptors were completed */ -vmxnet3_getRxComp (rcd, &rq->comp_ring.base[rq->comp_ring.next2proc].rcd, - &rxComp); -if (rcd->gen == rq->comp_ring.gen &&napi_reschedule (napi)) -vmxnet3_disable_intr (adapter, rq->comp_ring.intr_idx); }return rxd_done; }
Signature · 1 line
2.11.0
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Quoted 9 lines · On Wed, 27 Jul 2022 10:30:37 -0700 you wrote:
Commit '
2c5a5748105a("vmxnet3: add support for out of order rx completion")' added support for out of order rx completion. Within that patch, an enhancement was done to reschedule napi for processing rx completions.However, it can lead to missing an interrupt. So, this patch reverts that part of the code.
[...]
Here is the summary with links:
- [net-next] vmxnet3: do not reschedule napi for rx processing
https://git.kernel.org/netdev/net-next/c/5b91884bf50b
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html