Skip to contentSkip to conversation

rtw89: 8852a: adjust IMR for SER L1

PATCH In review Ping-Ke Shih 2 participants 2 messages Jul 21, 2022 – Jul 29, 2022 Realtek wireless driver (rtw89)

lore
Share & tools
lore

Ping-Ke Shih

author maintainer
#0 lore raw

PATCH 1/1 rtw89: 8852a: adjust IMR for SER L1

From: Zong-Zhe Yang <[email protected]>

SER (system error recovery) L1 (level 1) has a step-by-step handshake process with FW. These handshakes still rely on B_AX_HS0ISR_IND_INT_EN. So, even already during recovery, we enable this bit in IMR.

---
 drivers/net/wireless/realtek/rtw89/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw89/pci.c +1 -1
index 73b3b7e9fe6f5..c68fec9eb5a64 100644
@@ -3111,7 +3111,7 @@ void rtw89_pci_config_intr_mask(struct rtw89_dev *rtwdev)
 	rtwpci->halt_c2h_intrs = B_AX_HALT_C2H_INT_EN | 0;
 
 	if (rtwpci->under_recovery) {
-		rtwpci->intrs[0] = 0;
+		rtwpci->intrs[0] = B_AX_HS0ISR_IND_INT_EN;
 		rtwpci->intrs[1] = 0;
 	} else {
 		rtwpci->intrs[0] = B_AX_TXDMA_STUCK_INT_EN |
Signature · 1 line
2.25.1
#1 lore raw

Re: wifi: rtw89: 8852a: adjust IMR for SER L1

Quoted 8 lines · Ping-Ke Shih

From: Zong-Zhe Yang <[email protected]>

SER (system error recovery) L1 (level 1) has a step-by-step handshake process with FW. These handshakes still rely on B_AX_HS0ISR_IND_INT_EN. So, even already during recovery, we enable this bit in IMR.

Patch applied to wireless-next.git, thanks.

334facd651b9 wifi: rtw89: 8852a: adjust IMR for SER L1

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches