Skip to contentSkip to conversation

sched/features: Expand the space of sched features

PATCH In review Cruz Zhao 2 participants 2 messages Aug 1, 2022 Scheduler

lore
Share & tools
lore

Cruz Zhao

author
#0 lore raw

PATCH 1/1 sched/features: Expand the space of sched features

With the increase of sched features, the available space decreases gradually. In order to prevent features overflow, this patch expands the space of sched features from 32 to 64.

---
 kernel/sched/core.c  | 2 +-
 kernel/sched/sched.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
kernel/sched/core.c +1 -1
index 1899990..afe76fb 100644
@@ -122,7 +122,7 @@
  */
 #define SCHED_FEAT(name, enabled)	\
 	(1UL << __SCHED_FEAT_##name) * enabled |
-const_debug unsigned int sysctl_sched_features =
+const_debug u64 sysctl_sched_features =
 #include "features.h"
 	0;
 #undef SCHED_FEAT
kernel/sched/sched.h +2 -2
index a6f071b..ac97f0a 100644
@@ -1999,7 +1999,7 @@ enum {
  * To support run-time toggling of sched features, all the translation units
  * (but core.c) reference the sysctl_sched_features defined in core.c.
  */
-extern const_debug unsigned int sysctl_sched_features;
+extern const_debug u64 sysctl_sched_features;
 
 #ifdef CONFIG_JUMP_LABEL
 #define SCHED_FEAT(name, enabled)					\
@@ -2029,7 +2029,7 @@ enum {
  */
 #define SCHED_FEAT(name, enabled)	\
 	(1UL << __SCHED_FEAT_##name) * enabled |
-static const_debug __maybe_unused unsigned int sysctl_sched_features =
+static const_debug __maybe_unused u64 sysctl_sched_features =
 #include "features.h"
 	0;
 #undef SCHED_FEAT
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 15 lines · Cruz Zhao

With the increase of sched features, the available space decreases gradually. In order to prevent features overflow, this patch expands the space of sched features from 32 to 64.

---
 kernel/sched/core.c  | 2 +-
 kernel/sched/sched.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
kernel/sched/core.c +0 -0
index 1899990..afe76fb 100644

kernel/sched/core.c line 125

Quoted 5 lines
kernel/sched/core.c +1 -1
@@ -122,7 +122,7 @@
  */
 #define SCHED_FEAT(name, enabled)	\
 	(1UL << __SCHED_FEAT_##name) * enabled |
-const_debug unsigned int sysctl_sched_features =
+const_debug u64 sysctl_sched_features =

Have you run into this? We have 27 features listed, so this shouldn't be happening right now - and this patch just bloats the word for no good reason.

Also, doesn't it generate a build warning/error in that case?

Thanks,

Ingo