Skip to contentSkip to conversation

net: marvell: prestera: remove reduntant code

PATCH Applied Sebin Sebastian 2 participants 2 messages Aug 1, 2022 – Aug 2, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: marvell: prestera: remove reduntant code

Fixes the coverity warning 'EVALUATION_ORDER' violation. port is written twice with the same value.

Fixes Coverity CID 1519056 (Incorrect expression)
---
 drivers/net/ethernet/marvell/prestera/prestera_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/prestera/prestera_main.c +1 -1
index c267ca1ccdba..0df904455d76 100644
@@ -290,7 +290,7 @@ static int prestera_pcs_config(struct phylink_pcs *pcs,
 			       const unsigned long *advertising,
 			       bool permit_pause_to_mac)
 {
-	struct prestera_port *port = port = prestera_pcs_to_port(pcs);
+	struct prestera_port *port = prestera_pcs_to_port(pcs);
 	struct prestera_port_mac_config cfg_mac;
 	int err;
 
Signature · 1 line
2.34.1
#1 lore raw
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Mon, 1 Aug 2022 09:37:31 +0530 you wrote:

Fixes the coverity warning 'EVALUATION_ORDER' violation. port is written twice with the same value.

Fixes Coverity CID 1519056 (Incorrect expression)
---
 drivers/net/ethernet/marvell/prestera/prestera_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [-next] net: marvell: prestera: remove reduntant code

    https://git.kernel.org/netdev/net-next/c/969e26c63d30

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html