Skip to contentSkip to conversation

mt76: mt7921: apply the previous MCU timeout

PATCH [email protected] 1 participant 1 message Aug 4, 2022 1 message not in the archive Arm MediaTek

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): YuuAX3aa/[email protected]

#1 lore raw

From: Sean Wang <[email protected]>

Quoted 30 lines
Quoted 18 lines

From: Sean Wang <[email protected]>

Apply back the previous MCU timeout that can trigger the chip reset to recover the fatal error in time.

Fixes 8fcd1fb7cbd5 ("mt76: move mt76_connac2_mcu_fill_message in

mt76_connac module")

---
 drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
(quoted diff) +0 -0
 b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c

index 0afcadce87fc..da8223c515eb 100644

drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c int mt76_connac2_mcu_fill_message(struct · line 3057

Quoted 9 lines
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c +4 -1
@@ -3050,7 +3050,10 @@ int mt76_connac2_mcu_fill_message(struct
 mt76_dev  *dev, struct sk_buff *skb,
 	u8 seq;
 
 	/* TODO: make dynamic based on msg type */
-	dev->mcu.timeout = 20 * HZ;
+	if (is_mt7921(dev))
+		dev->mcu.timeout = 3 * HZ;
+	else
+		dev->mcu.timeout = 20 * HZ;

Hi Sean,

Quoted 1 line

I did not get the fix here since we are setting dev->mcu.timeout in

mt76_connac2_mcu_fill_message caller (e.g. mt7921s_mcu_send_message).

Quoted 1 line

Am I missing something?

oops! You're right. The patch should be dropped out. Thanks for the head-up.

Sean

Quoted 10 lines

Regards,
Lorenzo

Quoted 6 lines
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c +0 -1
 	seq = ++dev->mcu.msg_seq & 0xf;
 	if (!seq)
--

2.25.1