net: bcmgenet: Indicate MAC is in charge of PHY PM
Subsystems (3)
PATCH 1/1 net: bcmgenet: Indicate MAC is in charge of PHY PM
Avoid the PHY library call unnecessarily into the suspend/resume functions by setting phydev->mac_managed_pm to true. The GENET driver essentially does exactly what mdio_bus_phy_resume() does by calling phy_init_hw() plus phy_resume().
---
The commit ID used in the Fixes: tag is to ensure that this goes back to when the support for mac_managed_pm was introduced, however in premise this issue has existed for a while, so we might consider a targeted backport all the way back to 4.9.
drivers/net/ethernet/broadcom/genet/bcmmii.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/ethernet/broadcom/genet/bcmmii.c +3 -0
@@ -393,6 +393,9 @@ int bcmgenet_mii_probe(struct net_device *dev)if (priv->internal_phy && !GENET_IS_V5 (priv)) dev->phydev->irq =PHY_MAC_INTERRUPT ; +/* Indicate that the MAC is responsible for PHY PM */ + dev->phydev->mac_managed_pm = true; +return 0 ; }
Signature · 1 line
2.25.1
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Thu, 4 Aug 2022 10:36:04 -0700 you wrote:
Avoid the PHY library call unnecessarily into the suspend/resume functions by setting
phydev->mac_managed_pmto true. The GENET driver essentially does exactly whatmdio_bus_phy_resume()does by callingphy_init_hw()plusphy_resume().Fixes fba863b81604 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM")Signed-off-by Florian Fainelli <[email protected]>[...]
Here is the summary with links:
- [net] net: bcmgenet: Indicate MAC is in charge of PHY PM
https://git.kernel.org/netdev/net/c/bc3410f25021
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html