Skip to contentSkip to conversation

selftests/bpf: Add lru_bug to s390x deny list

PATCH Applied Daniel Müller 3 participants 3 messages Aug 10, 2022 – Aug 12, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: Add lru_bug to s390x deny list

The lru_bug BPF selftest is failing execution on s390x machines. The failure is due to program attachment failing in turn, similar to a bunch of other tests. Those other tests have already been deny-listed and with this change we do the same for the lru_bug test, adding it to the corresponding file.

Fixes de7b9927105b ("selftests/bpf: Add test for prealloc_lru_pop bug")
---
 tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/DENYLIST.s390x +1 -0
index e33cab..db9810 100644
@@ -65,3 +65,4 @@ send_signal                              # intermittently fails to receive signa
 select_reuseport                         # intermittently fails on new s390x setup
 xdp_synproxy                             # JIT does not support calling kernel function                                (kfunc)
 unpriv_bpf_disabled                      # fentry
+lru_bug                                  # prog 'printk': failed to auto-attach: -524
Signature · 1 line
2.30.2
Acked-by on v1 1/1
#1 lore raw

Thanks Daniel for fixing this quickly. It should recover: https://github.com/kernel-patches/bpf/runs/7772305011?check_suite_focus=true

Quoted 26 lines · Daniel Müller

The lru_bug BPF selftest is failing execution on s390x machines. The failure is due to program attachment failing in turn, similar to a bunch of other tests. Those other tests have already been deny-listed and with this change we do the same for the lru_bug test, adding it to the corresponding file.

Fixes de7b9927105b ("selftests/bpf: Add test for prealloc_lru_pop bug")

---
tools/testing/selftests/bpf/DENYLIST.s390x | 1 +

1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/DENYLIST.s390x +0 -0
index e33cab..db9810 100644
@@ -65,3 +65,4 @@ send_signal                              # intermittently fails to receive signa
select_reuseport                         # intermittently fails on new s390x setup
xdp_synproxy                             # JIT does not support calling kernel function                                (kfunc)
unpriv_bpf_disabled                      # fentry

+lru_bug # prog 'printk': failed to auto-attach: -524

Signature · 1 line
2.30.2
#2 lore raw
In reply to Daniel Müller
This patch was applied to bpf/bpf.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <[email protected]>:

Quoted 10 lines · On Wed, 10 Aug 2022 20:07:10 +0000 you wrote:

The lru_bug BPF selftest is failing execution on s390x machines. The failure is due to program attachment failing in turn, similar to a bunch of other tests. Those other tests have already been deny-listed and with this change we do the same for the lru_bug test, adding it to the corresponding file.

Fixes de7b9927105b ("selftests/bpf: Add test for prealloc_lru_pop bug")

[...]

Here is the summary with links:
- [bpf] selftests/bpf: Add lru_bug to s390x deny list

    https://git.kernel.org/bpf/bpf/c/27e23836ce22

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html