Skip to contentSkip to conversation

net: dsa: microchip: ksz9477: fix fdb_dump last invalid entry

PATCH Applied Arun Ramadoss 3 participants 3 messages Aug 16, 2022 – Aug 17, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 net: dsa: microchip: ksz9477: fix fdb_dump last invalid entry

In the ksz9477_fdb_dump function it reads the ALU control register and exit from the timeout loop if there is valid entry or search is complete. After exiting the loop, it reads the alu entry and report to the user space irrespective of entry is valid. It works till the valid entry. If the loop exited when search is complete, it reads the alu table. The table returns all ones and it is reported to user space. So bridge fdb show gives ff:ff:ff:ff:ff:ff as last entry for every port. To fix it, after exiting the loop the entry is reported only if it is valid one.

Fixes b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")

---
changes in v3
- changed the subject from net-next to net

changes in v2
- changed the fixes commit id
- reduced the indentation level by using ! and continue statement

 drivers/net/dsa/microchip/ksz9477.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/dsa/microchip/ksz9477.c +3 -0
index 4b14d80d27ed..e4f446db0ca1 100644
@@ -613,6 +613,9 @@ int ksz9477_fdb_dump(struct ksz_device *dev, int port,
 			goto exit;
 		}
 
+		if (!(ksz_data & ALU_VALID))
+			continue;
+
 		/* read ALU table */
 		ksz9477_read_table(dev, alu_table);
 

base-commit: 7ebfc85e2cd7b08f518b526173e9a33b56b3913b

Signature · 1 line
2.36.1
maintainer Reviewed-by on v3 1/1
#1 lore raw
Quoted 10 lines · Arun Ramadoss

In the ksz9477_fdb_dump function it reads the ALU control register and exit from the timeout loop if there is valid entry or search is complete. After exiting the loop, it reads the alu entry and report to the user space irrespective of entry is valid. It works till the valid entry. If the loop exited when search is complete, it reads the alu table. The table returns all ones and it is reported to user space. So bridge fdb show gives ff:ff:ff:ff:ff:ff as last entry for every port. To fix it, after exiting the loop the entry is reported only if it is valid one.

Quoted 3 lines
Fixes b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")

---

#2 lore raw
In reply to Arun Ramadoss
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Tue, 16 Aug 2022 16:25:16 +0530 you wrote:

In the ksz9477_fdb_dump function it reads the ALU control register and exit from the timeout loop if there is valid entry or search is complete. After exiting the loop, it reads the alu entry and report to the user space irrespective of entry is valid. It works till the valid entry. If the loop exited when search is complete, it reads the alu table. The table returns all ones and it is reported to user space. So bridge fdb show gives ff:ff:ff:ff:ff:ff as last entry for every port. To fix it, after exiting the loop the entry is reported only if it is valid one.

[...]

Here is the summary with links:
- [net,v3] net: dsa: microchip: ksz9477: fix fdb_dump last invalid entry

    https://git.kernel.org/netdev/net/c/36c0d9350157

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html