Remove DECnet support from kernel
Subsystems (6)
PATCH 1/1 Remove DECnet support from kernel
DECnet is an obsolete network protocol that receives more attention from kernel janitors than users. It belongs in computer protocol history museum not in Linux kernel.
It has been "Orphaned" in kernel since 2010. The iproute2 support for DECnet was dropped in 5.0 release. The documentation link on Sourceforge says it is abandoned there as well.
Leave the UAPI alone to keep userspace programs compiling. This means that there is still an empty neighbour table for AF_DECNET.
The table of /proc/sys/net entries was updated to match current directories and reformatted to be alphabetical.
---
Incorporates feedback from the initial RFC. The MPLS neighbour table to family table is left alone.
.../admin-guide/kernel-parameters.txt | 4 - Documentation/admin-guide/sysctl/net.rst | 15 +- Documentation/networking/decnet.rst | 243 -- Documentation/networking/index.rst | 1 - .../userspace-api/ioctl/ioctl-number.rst | 1 - MAINTAINERS | 7 - arch/mips/configs/decstation_64_defconfig | 2 - arch/mips/configs/decstation_defconfig | 2 - arch/mips/configs/decstation_r4k_defconfig | 2 - arch/mips/configs/gpr_defconfig | 2 - arch/mips/configs/mtx1_defconfig | 2 - arch/mips/configs/rm200_defconfig | 2 - arch/powerpc/configs/ppc6xx_defconfig | 2 - include/linux/netdevice.h | 4 - include/linux/netfilter.h | 5 - include/linux/netfilter_defs.h | 8 - include/net/dn.h | 231 -- include/net/dn_dev.h | 200 -- include/net/dn_fib.h | 169 -- include/net/dn_neigh.h | 32 - include/net/dn_nsp.h | 201 -- include/net/dn_route.h | 118 - include/net/netns/netfilter.h | 3 - include/uapi/linux/dn.h | 149 - include/uapi/linux/netfilter_decnet.h | 72 - include/uapi/linux/netlink.h | 2 +- net/Kconfig | 2 - net/Makefile | 1 - net/core/dev.c | 4 +- net/core/neighbour.c | 3 - net/decnet/Kconfig | 43 - net/decnet/Makefile | 10 - net/decnet/README | 8 - net/decnet/af_decnet.c | 2404 ----------------- net/decnet/dn_dev.c | 1433 ---------- net/decnet/dn_fib.c | 798 ------ net/decnet/dn_neigh.c | 607 ----- net/decnet/dn_nsp_in.c | 907 ------- net/decnet/dn_nsp_out.c | 696 ----- net/decnet/dn_route.c | 1922 ------------- net/decnet/dn_rules.c | 253 -- net/decnet/dn_table.c | 929 ------- net/decnet/dn_timer.c | 104 - net/decnet/netfilter/Kconfig | 17 - net/decnet/netfilter/Makefile | 6 - net/decnet/netfilter/dn_rtmsg.c | 158 -- net/decnet/sysctl_net_decnet.c | 362 --- net/netfilter/core.c | 10 - net/netfilter/nfnetlink_hook.c | 7 - 49 files changed, 10 insertions(+), 12153 deletions(-) delete mode 100644 Documentation/networking/decnet.rst delete mode 100644 include/net/dn.h delete mode 100644 include/net/dn_dev.h delete mode 100644 include/net/dn_fib.h delete mode 100644 include/net/dn_neigh.h delete mode 100644 include/net/dn_nsp.h delete mode 100644 include/net/dn_route.h delete mode 100644 include/uapi/linux/dn.h delete mode 100644 include/uapi/linux/netfilter_decnet.h delete mode 100644 net/decnet/Kconfig delete mode 100644 net/decnet/Makefile delete mode 100644 net/decnet/README delete mode 100644 net/decnet/af_decnet.c delete mode 100644 net/decnet/dn_dev.c delete mode 100644 net/decnet/dn_fib.c delete mode 100644 net/decnet/dn_neigh.c delete mode 100644 net/decnet/dn_nsp_in.c delete mode 100644 net/decnet/dn_nsp_out.c delete mode 100644 net/decnet/dn_route.c delete mode 100644 net/decnet/dn_rules.c delete mode 100644 net/decnet/dn_table.c delete mode 100644 net/decnet/dn_timer.c delete mode 100644 net/decnet/netfilter/Kconfig delete mode 100644 net/decnet/netfilter/Makefile delete mode 100644 net/decnet/netfilter/dn_rtmsg.c delete mode 100644 net/decnet/sysctl_net_decnet.c
Documentation/admin-guide/kernel-parameters.txt +0 -4
@@ -966,10 +966,6 @@ debugpat [X86] Enable PAT debugging - decnet.addr= [HW,NET] - Format: <area>[,<node>] - See also Documentation/networking/decnet.rst. - default_hugepagesz= [HW] The size of the default HugeTLB page. This is the size represented by the legacy /proc/ hugepages
Documentation/admin-guide/sysctl/net.rst +8 -7
@@ -34,13 +34,14 @@ Table : Subdirectories in /proc/sys/net ========= =================== = ========== ================== Directory Content Directory Content ========= =================== = ========== ================== - core General parameter appletalk Appletalk protocol - unix Unix domain sockets netrom NET/ROM - 802 E802 protocol ax25 AX25 - ethernet Ethernet protocol rose X.25 PLP layer - ipv4 IP version 4 x25 X.25 protocol - bridge Bridging decnet DEC net - ipv6 IP version 6 tipc TIPC + 802 E802 protocol mptcp Multipath TCP + appletalk Appletalk protocol netfilter Network Filter + ax25 AX25 netrom NET/ROM + bridge Bridging rose X.25 PLP layer + core General parameter tipc TIPC + ethernet Ethernet protocol unix Unix domain sockets + ipv4 IP version 4 x25 X.25 protocol + ipv6 IP version 6 ========= =================== = ========== ================== 1. /proc/sys/net/core - Network core options
Documentation/networking/decnet.rst deleted +0 -243
243 lines not on this page · raw message
Documentation/networking/index.rst +0 -1
@@ -47,7 +47,6 @@ Contents: cdc_mbim dccp dctcp - decnet dns_resolver driver eql
Documentation/userspace-api/ioctl/ioctl-number.rst +0 -1
@@ -308,7 +308,6 @@ Code Seq# Include File Comments 0x89 00-06 arch/x86/include/asm/sockios.h 0x89 0B-DF linux/sockios.h 0x89 E0-EF linux/sockios.h SIOCPROTOPRIVATE range -0x89 E0-EF linux/dn.h PROTOPRIVATE range 0x89 F0-FF linux/sockios.h SIOCDEVPRIVATE range 0x8B all linux/wireless.h 0x8C 00-3F WiNRADiO driver
MAINTAINERS +0 -7
@@ -5712,13 +5712,6 @@ F: include/linux/tfrc.h F: include/uapi/linux/dccp.h F: net/dccp/ -DECnet NETWORK LAYER -L: [email protected] -S: Orphan -W: http://linux-decnet.sourceforge.net -F: Documentation/networking/decnet.rst -F: net/decnet/ - DECSTATION PLATFORM SUPPORT M: "Maciej W. Rozycki" <[email protected]> L: [email protected]
arch/mips/configs/decstation_64_defconfig +0 -2
@@ -53,8 +53,6 @@ CONFIG_IPV6_SUBTREES=y CONFIG_NETWORK_SECMARK=y CONFIG_IP_SCTP=m CONFIG_VLAN_8021Q=m -CONFIG_DECNET=m -CONFIG_DECNET_ROUTER=y # CONFIG_WIRELESS is not set # CONFIG_UEVENT_HELPER is not set # CONFIG_FW_LOADER is not set
arch/mips/configs/decstation_defconfig +0 -2
@@ -49,8 +49,6 @@ CONFIG_IPV6_SUBTREES=y CONFIG_NETWORK_SECMARK=y CONFIG_IP_SCTP=m CONFIG_VLAN_8021Q=m -CONFIG_DECNET=m -CONFIG_DECNET_ROUTER=y # CONFIG_WIRELESS is not set # CONFIG_UEVENT_HELPER is not set # CONFIG_FW_LOADER is not set
arch/mips/configs/decstation_r4k_defconfig +0 -2
@@ -48,8 +48,6 @@ CONFIG_IPV6_SUBTREES=y CONFIG_NETWORK_SECMARK=y CONFIG_IP_SCTP=m CONFIG_VLAN_8021Q=m -CONFIG_DECNET=m -CONFIG_DECNET_ROUTER=y # CONFIG_WIRELESS is not set # CONFIG_UEVENT_HELPER is not set # CONFIG_FW_LOADER is not set
arch/mips/configs/gpr_defconfig +0 -2
@@ -69,7 +69,6 @@ CONFIG_IP_NF_RAW=m CONFIG_IP_NF_ARPTABLES=m CONFIG_IP_NF_ARPFILTER=m CONFIG_IP_NF_ARP_MANGLE=m -CONFIG_DECNET_NF_GRABULATOR=m CONFIG_BRIDGE_NF_EBTABLES=m CONFIG_BRIDGE_EBT_BROUTE=m CONFIG_BRIDGE_EBT_T_FILTER=m
@@ -99,7 +98,6 @@ CONFIG_ATM_MPOA=m CONFIG_ATM_BR2684=m CONFIG_BRIDGE=m CONFIG_VLAN_8021Q=m -CONFIG_DECNET=m CONFIG_LLC2=m CONFIG_ATALK=m CONFIG_DEV_APPLETALK=m
arch/mips/configs/mtx1_defconfig +0 -2
@@ -116,7 +116,6 @@ CONFIG_IP6_NF_FILTER=m CONFIG_IP6_NF_TARGET_REJECT=m CONFIG_IP6_NF_MANGLE=m CONFIG_IP6_NF_RAW=m -CONFIG_DECNET_NF_GRABULATOR=m CONFIG_BRIDGE_NF_EBTABLES=m CONFIG_BRIDGE_EBT_BROUTE=m CONFIG_BRIDGE_EBT_T_FILTER=m
@@ -146,7 +145,6 @@ CONFIG_ATM_MPOA=m CONFIG_ATM_BR2684=m CONFIG_BRIDGE=m CONFIG_VLAN_8021Q=m -CONFIG_DECNET=m CONFIG_LLC2=m CONFIG_ATALK=m CONFIG_DEV_APPLETALK=m
arch/mips/configs/rm200_defconfig +0 -2
@@ -116,7 +116,6 @@ CONFIG_IP6_NF_FILTER=m CONFIG_IP6_NF_TARGET_REJECT=m CONFIG_IP6_NF_MANGLE=m CONFIG_IP6_NF_RAW=m -CONFIG_DECNET_NF_GRABULATOR=m CONFIG_BRIDGE_NF_EBTABLES=m CONFIG_BRIDGE_EBT_BROUTE=m CONFIG_BRIDGE_EBT_T_FILTER=m
@@ -137,7 +136,6 @@ CONFIG_BRIDGE_EBT_REDIRECT=m CONFIG_BRIDGE_EBT_SNAT=m CONFIG_BRIDGE_EBT_LOG=m CONFIG_BRIDGE=m -CONFIG_DECNET=m CONFIG_NET_SCHED=y CONFIG_NET_SCH_CBQ=m CONFIG_NET_SCH_HTB=m
arch/powerpc/configs/ppc6xx_defconfig +0 -2
@@ -243,8 +243,6 @@ CONFIG_ATM_LANE=m CONFIG_ATM_BR2684=m CONFIG_BRIDGE=m CONFIG_VLAN_8021Q=m -CONFIG_DECNET=m -CONFIG_DECNET_ROUTER=y CONFIG_ATALK=m CONFIG_DEV_APPLETALK=m CONFIG_IPDDP=m
include/linux/netdevice.h +0 -4
@@ -1837,7 +1837,6 @@ enum netdev_ml_priv_type {* @tipc_ptr: TIPC specific data * @atalk_ptr: AppleTalk link * @ip_ptr: IPv4 specific data -* @dn_ptr: DECnet specific data * @ip6_ptr: IPv6 specific data * @ax25_ptr: AX.25 specific data * @ieee80211_ptr: IEEE 802.11 specific data, assign before registering
@@ -2133,9 +2132,6 @@ struct net_device {#if IS_ENABLED (CONFIG_ATALK )void *atalk_ptr;#endif -#if IS_ENABLED (CONFIG_DECNET ) -struct dn_dev __rcu *dn_ptr; -#endif #if IS_ENABLED (CONFIG_AX25 )void *ax25_ptr;#endif
include/linux/netfilter.h +0 -5
@@ -243,11 +243,6 @@ static inline int nf_hook(u_int8_t pf, unsigned int hook, struct net *net, hook_head =rcu_dereference (net->nf.hooks_bridge[hook]);#endif break ; -#if IS_ENABLED (CONFIG_DECNET ) -case NFPROTO_DECNET : - hook_head =rcu_dereference (net->nf.hooks_decnet[hook]); -break ; -#endif default :WARN_ON_ONCE (1 );break ;
include/linux/netfilter_defs.h +0 -8
@@ -7,14 +7,6 @@/* in/out/forward only */ #define NF_ARP_NUMHOOKS 3 -/* max hook is NF_DN_ROUTE (6), also see uapi/linux/netfilter_decnet.h */ -#define NF_DN_NUMHOOKS 7 - -#if IS_ENABLED (CONFIG_DECNET ) -/* Largest hook number + 1, see uapi/linux/netfilter_decnet.h */ -#define NF_MAX_HOOKS NF_DN_NUMHOOKS -#else #define NF_MAX_HOOKS NF_INET_NUMHOOKS -#endif #endif
include/net/dn.h deleted +0 -231
231 lines not on this page · raw message
include/net/dn_dev.h deleted +0 -200
200 lines not on this page · raw message
include/net/dn_fib.h deleted +0 -169
169 lines not on this page · raw message
include/net/dn_neigh.h deleted +0 -32
@@ -1,32 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef _NET_DN_NEIGH_H -#define _NET_DN_NEIGH_H - -#include <net/neighbour.h> - -/* -* The position of the first two fields of -* this structure are critical - SJW -*/ -struct dn_neigh { -struct neighbour n; -__le16 addr; -unsigned long flags; -#define DN_NDFLAG_R1 0x0001/* Router L1 */ -#define DN_NDFLAG_R2 0x0002/* Router L2 */ -#define DN_NDFLAG_P3 0x0004/* Phase III Node */ -unsigned long blksize; -__u8 priority; -}; - -void dn_neigh_init (void ); -void dn_neigh_cleanup (void ); -int dn_neigh_router_hello (struct net *net,struct sock *sk,struct sk_buff *skb); -int dn_neigh_endnode_hello (struct net *net,struct sock *sk,struct sk_buff *skb); -void dn_neigh_pointopoint_hello (struct sk_buff *skb); -int dn_neigh_elist (struct net_device *dev,unsigned char *ptr,int n); -int dn_to_neigh_output (struct net *net,struct sock *sk,struct sk_buff *skb); - -extern struct neigh_table dn_neigh_table; - -#endif /* _NET_DN_NEIGH_H */
include/net/dn_nsp.h deleted +0 -201
201 lines not on this page · raw message
include/net/dn_route.h deleted +0 -118
118 lines not on this page · raw message
include/net/netns/netfilter.h +0 -3
@@ -24,9 +24,6 @@ struct netns_nf {#ifdef CONFIG_NETFILTER_FAMILY_BRIDGE struct nf_hook_entries __rcu *hooks_bridge[NF_INET_NUMHOOKS ];#endif -#if IS_ENABLED (CONFIG_DECNET ) -struct nf_hook_entries __rcu *hooks_decnet[NF_DN_NUMHOOKS ]; -#endif #if IS_ENABLED (CONFIG_NF_DEFRAG_IPV4 )unsigned int defrag_ipv4_users;#endif
include/uapi/linux/dn.h deleted +0 -149
149 lines not on this page · raw message
include/uapi/linux/netfilter_decnet.h deleted +0 -72
72 lines not on this page · raw message
include/uapi/linux/netlink.h +1 -1
@@ -20,7 +20,7 @@#define NETLINK_CONNECTOR 11#define NETLINK_NETFILTER 12/* netfilter subsystem */ #define NETLINK_IP6_FW 13 -#define NETLINK_DNRTMSG 14/* DECnet routing messages */ +#define NETLINK_DNRTMSG 14/* DECnet routing messages (obsolete) */ #define NETLINK_KOBJECT_UEVENT 15/* Kernel messages to userspace */ #define NETLINK_GENERIC 16/* leave room for NETLINK_DM (DM Events) */
net/Kconfig +0 -2
@@ -204,7 +204,6 @@ config BRIDGE_NETFILTER source "net/netfilter/Kconfig" source "net/ipv4/netfilter/Kconfig" source "net/ipv6/netfilter/Kconfig" -source "net/decnet/netfilter/Kconfig" source "net/bridge/netfilter/Kconfig" endif
@@ -221,7 +220,6 @@ source "net/802/Kconfig" source "net/bridge/Kconfig" source "net/dsa/Kconfig" source "net/8021q/Kconfig" -source "net/decnet/Kconfig" source "net/llc/Kconfig" source "drivers/net/appletalk/Kconfig" source "net/x25/Kconfig"
net/Makefile +0 -1
@@ -38,7 +38,6 @@ obj-$(CONFIG_AF_KCM) += kcm/ obj-$(CONFIG_STREAM_PARSER) += strparser/ obj-$(CONFIG_ATM) += atm/ obj-$(CONFIG_L2TP) += l2tp/ -obj-$(CONFIG_DECNET) += decnet/ obj-$(CONFIG_PHONET) += phonet/ ifneq ($(CONFIG_VLAN_8021Q),) obj-y += 8021q/
net/core/dev.c +1 -3
@@ -10370,9 +10370,7 @@ void netdev_run_todo(void)BUG_ON (!list_empty (&dev->ptype_specific));WARN_ON (rcu_access_pointer (dev->ip_ptr));WARN_ON (rcu_access_pointer (dev->ip6_ptr)); -#if IS_ENABLED (CONFIG_DECNET ) -WARN_ON (dev->dn_ptr); -#endif +if (dev->priv_destructor) dev->priv_destructor (dev);if (dev->needs_free_netdev)
net/core/neighbour.c +0 -3
@@ -1819,9 +1819,6 @@ static struct neigh_table *neigh_find_table(int family)case AF_INET6 : tbl = neigh_tables[NEIGH_ND_TABLE ];break ; -case AF_DECnet: - tbl = neigh_tables[NEIGH_DN_TABLE ]; -break ; }return tbl;
net/decnet/Kconfig deleted +0 -43
43 lines not on this page · raw message
net/decnet/Makefile deleted +0 -10
@@ -1,10 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 - -obj-$(CONFIG_DECNET) += decnet.o - -decnet-y := af_decnet.o dn_nsp_in.o dn_nsp_out.o \ - dn_route.o dn_dev.o dn_neigh.o dn_timer.o -decnet-$(CONFIG_DECNET_ROUTER) += dn_fib.o dn_rules.o dn_table.o -decnet-y += sysctl_net_decnet.o - -obj-$(CONFIG_NETFILTER) += netfilter/
net/decnet/README deleted +0 -8
@@ -1,8 +0,0 @@ - Linux DECnet Project - ====================== - -The documentation for this kernel subsystem is available in the -Documentation/networking subdirectory of this distribution and also -on line at http://www.chygwyn.com/DECnet/ - -Steve Whitehouse <[email protected]>
net/decnet/af_decnet.c deleted +0 -2404
1,294 lines not on this page · raw message
net/decnet/dn_dev.c deleted +0 -1433
1,433 lines not on this page · raw message
net/decnet/dn_fib.c deleted +0 -798
798 lines not on this page · raw message
net/decnet/dn_neigh.c deleted +0 -607
607 lines not on this page · raw message
net/decnet/dn_nsp_in.c deleted +0 -907
907 lines not on this page · raw message
net/decnet/dn_nsp_out.c deleted +0 -696
696 lines not on this page · raw message
net/decnet/dn_route.c deleted +0 -1922
1,922 lines not on this page · raw message
net/decnet/dn_rules.c deleted +0 -253
253 lines not on this page · raw message
net/decnet/dn_table.c deleted +0 -929
929 lines not on this page · raw message
net/decnet/dn_timer.c deleted +0 -104
104 lines not on this page · raw message
net/decnet/netfilter/dn_rtmsg.c deleted +0 -158
158 lines not on this page · raw message
net/decnet/sysctl_net_decnet.c deleted +0 -362
362 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.35.1
Part of the diff is not shown here. View the raw message.
Quoted 15 lines · Stephen Hemminger
DECnet is an obsolete network protocol that receives more attention from kernel janitors than users. It belongs in computer protocol history museum not in Linux kernel.
It has been "Orphaned" in kernel since 2010. The iproute2 support for DECnet was dropped in 5.0 release. The documentation link on Sourceforge says it is abandoned there as well.
Leave the UAPI alone to keep userspace programs compiling. This means that there is still an empty neighbour table for
AF_DECNET.The table of
/proc/sys/netentries was updated to match current directories and reformatted to be alphabetical.
Quoted 7 lines
Signed-off-by Stephen Hemminger <[email protected]>Acked-by David Ahern <[email protected]>---
Incorporates feedback from the initial RFC. The MPLS neighbour table to family table is left alone.
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Quoted 9 lines · On Wed, 17 Aug 2022 17:43:21 -0700 you wrote:
DECnet is an obsolete network protocol that receives more attention from kernel janitors than users. It belongs in computer protocol history museum not in Linux kernel.
It has been "Orphaned" in kernel since 2010. The iproute2 support for DECnet was dropped in 5.0 release. The documentation link on Sourceforge says it is abandoned there as well.
[...]
Here is the summary with links:
- [net-next] Remove DECnet support from kernel
https://git.kernel.org/netdev/net-next/c/1202cdd66531
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Quoted 17 lines · Stephen Hemminger
DECnet is an obsolete network protocol that receives more attention from kernel janitors than users. It belongs in computer protocol history museum not in Linux kernel.
It has been "Orphaned" in kernel since 2010. The iproute2 support for DECnet was dropped in 5.0 release. The documentation link on Sourceforge says it is abandoned there as well.
Leave the UAPI alone to keep userspace programs compiling. This means that there is still an empty neighbour table for
AF_DECNET.The table of
/proc/sys/netentries was updated to match current directories and reformatted to be alphabetical.Signed-off-by Stephen Hemminger <[email protected]>Acked-by David Ahern <[email protected]>
...
Quoted 2 lines
include/uapi/linux/dn.h | 149 - include/uapi/linux/netfilter_decnet.h | 72 -
Hi,
this breaks userspace. Some projects include linux/dn.h:
https://codesearch.debian.net/search?q=include.*linux%2Fdn.h&literal=0
I found Trinity fails to build:
net/proto-decnet.c:5:10: fatal error: linux/dn.h: No such file or
directory
5 | #include <linux/dn.h>
Should we provide the above as empty files?
thanks,
Signature · 2 lines
js suse labs
Quoted 5 lines · Jiri Slaby
Quoted 1 line · Stephen Hemminger
DECnet is an obsolete network protocol
this breaks userspace. Some projects include
linux/dn.h:
Quoted 7 lines
https://codesearch.debian.net/search?q=include.*linux%2Fdn.h&literal=0
I found Trinity fails to build:
net/proto-decnet.c:5:10: fatal error:linux/dn.h: No such file or directory5 | #include <linux/dn.h>Should we provide the above as empty files?
Not a good idea. There may be configure tests / code that merely checks for dn.h existence without checking for specific contents/defines. If you provide empty files, this would fail to build:
#include "config.h"
#ifdef HAVE_LINUX_DN_H
# include <linux/dn.h>
#endif
int main() {
#ifdef HAVE_LINUX_DN_H
socket(AF_DECNET, 0, DNPROTO_NSP); // or whatever
#else ...
#endif
}
So, with my distro hat on, outright removing header files feels like the slightly lesser of two evils. Given the task to port $arbitrary software between operating systems, absent header files is something more or less "regularly" encountered, so one could argue we are "trained" to deal with it. But missing individual defines is a much deeper dive into the APIs and software to patch it out.
Quoted 31 lines · Jan Engelhardt
Quoted 5 lines · Jiri Slaby
Quoted 1 line · Stephen Hemminger
DECnet is an obsolete network protocol
this breaks userspace. Some projects include
linux/dn.h:Quoted 7 lines
https://codesearch.debian.net/search?q=include.*linux%2Fdn.h&literal=0
I found Trinity fails to build:
net/proto-decnet.c:5:10: fatal error:linux/dn.h: No such file or directory5 | #include <linux/dn.h>Should we provide the above as empty files?
Not a good idea. There may be configure tests / code that merely checks for
dn.hexistence without checking for specific contents/defines. If you provide empty files, this would fail to build:#include "
config.h"
#ifdefHAVE_LINUX_DN_H
# include <linux/dn.h>
#endif
intmain(){
#ifdefHAVE_LINUX_DN_H
socket(AF_DECNET, 0, DNPROTO_NSP); // or whatever#else ...#endif
}
Quoted 6 lines
So, with my distro hat on, outright removing header files feels like the slightly lesser of two evils. Given the task to port $arbitrary software between operating systems, absent header files is something more or less "regularly" encountered, so one could argue we are "trained" to deal with it. But missing individual defines is a much deeper dive into the APIs and software to patch it out.
Right, we used to keep providing also defines and structs in uapi headers of removed functionality. So that the above socket would compile, but fail during runtime.
I am not biased to any solution. In fact, I found out trinity was fixed already. So either path networking takes, it's fine by me. I'm not sure about the chromium users, though (and I don't care).
thanks,
Signature · 2 lines
js suse labs
Quoted 10 lines · Jiri Slaby
Quoted 1 line · Jan Engelhardt
On Monday 2023-01-09 08:04, Jiri Slaby wrote:
Right, we used to keep providing also defines and structs in uapi headers of removed functionality. So that the above socket would compile, but fail during runtime.
I am not biased to any solution. In fact, I found out trinity was fixed already. So either path networking takes, it's fine by me. I'm not sure about the chromium users, though (and I don't care).
Chromium and some of the others look like automatically generated lists of files and the rest seem to have compile-time checks.
From a brief look at all the packages in the debian codesearch link you provided, I don't see any that are likely to cause problems aside from trinity.
Arnd