net: dsa: mv88e6xxx: Allow external SMI if serial
Subsystems (4)
PATCH 1/1 net: dsa: mv88e6xxx: Allow external SMI if serial
p0_mode set to one of the supported serial mode should not prevent configuring the external SMI interface in mv88e6xxx_g2_scratch_gpio_set_smi. The current masking of the p0_mode only checks the first 2 bits. This results in switches supporting serial mode cannot setup external SMI on certain serial modes (Ex: 1000BASE-X and SGMII).
Extend the mask of the p0_mode to include the reduced modes and serial modes as allowed modes for the external SMI interface.
--- drivers/net/dsa/mv88e6xxx/global2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/mv88e6xxx/global2.h +1 -1
@@ -298,7 +298,7 @@#define MV88E6352_G2_SCRATCH_CONFIG_DATA1 0x71#define MV88E6352_G2_SCRATCH_CONFIG_DATA1_NO_CPU BIT(2)#define MV88E6352_G2_SCRATCH_CONFIG_DATA2 0x72 -#define MV88E6352_G2_SCRATCH_CONFIG_DATA2_P0_MODE_MASK 0x3 +#define MV88E6352_G2_SCRATCH_CONFIG_DATA2_P0_MODE_MASK 0xf#define MV88E6352_G2_SCRATCH_CONFIG_DATA3 0x73#define MV88E6352_G2_SCRATCH_CONFIG_DATA3_S_SEL BIT(1)
Signature · 1 line
2.20.1
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 24 Aug 2022 11:37:06 +0200 you wrote:
p0_modeset to one of the supported serial mode should not prevent configuring the external SMI interface inmv88e6xxx_g2_scratch_gpio_set_smi. The current masking of thep0_modeonly checks the first 2 bits. This results in switches supporting serial mode cannot setup external SMI on certain serial modes (Ex: 1000BASE-X and SGMII).[...]
Here is the summary with links:
- net: dsa: mv88e6xxx: Allow external SMI if serial
https://git.kernel.org/netdev/net-next/c/8532c60efcc5
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html