net/mlx5e: Do not use err uninitialized in mlx5e_rep_add_meta_tunnel_rule()
Subsystems (5)
PATCH 1/1 net/mlx5e: Do not use err uninitialized in mlx5e_rep_add_meta_tunnel_rule()
Clang warns:
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:6: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
if (IS_ERR(flow_rule)) {
^~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:489:9: note: uninitialized use occurs here
return err;
^~~
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:2: note: remove the 'if' if its condition is always true
if (IS_ERR(flow_rule)) {
^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:474:9: note: initialize the variable 'err' to silence this warning
int err;
^
= 01 error generated.
There is little reason to have the 'goto + error variable' construct in this function. Get rid of it and just return the PTR_ERR value in the if statement and 0 at the end.
--- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +3 -7
@@ -471,22 +471,18 @@ mlx5e_rep_add_meta_tunnel_rule(struct mlx5e_priv *priv)struct mlx5_eswitch_rep *rep = rpriv->rep;struct mlx5_flow_handle *flow_rule;struct mlx5_flow_group *g; -int err; g = esw->fdb_table.offloads.send_to_vport_meta_grp;if (!g)return 0 ; flow_rule =mlx5_eswitch_add_send_to_vport_meta_rule (esw, rep->vport); -if (IS_ERR (flow_rule)) { - err =PTR_ERR (flow_rule); - goto out; - } +if (IS_ERR (flow_rule)) +return PTR_ERR (flow_rule); rpriv->send_to_vport_meta_rule = flow_rule; -out: -return err; +return 0 ; } static void
base-commit: c19d893fbf3f2f8fa864ae39652c7fee939edde2
Signature · 1 line
2.37.2
Quoted 18 lines · Nathan Chancellor
Clang warns:
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:6: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]if (IS_ERR(flow_rule)) { ^~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:489:9: note: uninitialized use occurs here return err; ^~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:2: note: remove the 'if' if its condition is always true if (IS_ERR(flow_rule)) { ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:474:9: note: initialize the variable 'err' to silence this warning int err; ^ = 01 error generated.
Quoted 7 lines
There is little reason to have the 'goto + error variable' construct in this function. Get rid of it and just return the
PTR_ERRvalue in the if statement and 0 at the end.Fixes 430e2d5e2a98 ("net/mlx5: E-Switch, Move send to vport meta rule creation")Signed-off-by Nathan Chancellor <[email protected]>
Thanks for the fix!
Quoted 39 lines
--- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +3
-7@@ -471,22 +471,18 @@ mlx5e_rep_add_meta_tunnel_rule(struct mlx5e_priv *priv)struct mlx5_eswitch_rep *rep = rpriv->rep;struct mlx5_flow_handle *flow_rule;struct mlx5_flow_group *g; -int err; g = esw->fdb_table.offloads.send_to_vport_meta_grp;if (!g)return 0 ; flow_rule =mlx5_eswitch_add_send_to_vport_meta_rule (esw, rep->vport); -if (IS_ERR (flow_rule)) { - err =PTR_ERR (flow_rule); - goto out; - } +if (IS_ERR (flow_rule)) +return PTR_ERR (flow_rule); rpriv->send_to_vport_meta_rule = flow_rule; -out: -return err; +return 0 ; } static voidbase-commit:
c19d893fbf3f2f8fa864ae39652c7fee939edde2--
2.37.2
Signature · 2 lines
Thanks, ~Nick Desaulniers
Quoted 21 lines · Nathan Chancellor
Clang warns:
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:6: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]if (IS_ERR(flow_rule)) { ^~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:489:9: note: uninitialized use occurs here return err; ^~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:2: note: remove the 'if' if its condition is always true if (IS_ERR(flow_rule)) { ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:474:9: note: initialize the variable 'err' to silence this warning int err; ^ = 01 error generated.
There is little reason to have the 'goto + error variable' construct in this function. Get rid of it and just return the
PTR_ERRvalue in the if statement and 0 at the end.
Quoted 7 lines
Fixes 430e2d5e2a98 ("net/mlx5: E-Switch, Move send to vport meta rule creation")Signed-off-by Nathan Chancellor <[email protected]>--- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
Thanks,
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 15 lines · On Thu, 25 Aug 2022 11:06:07 -0700 you wrote:
Clang warns:
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:6: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]if (IS_ERR(flow_rule)) { ^~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:489:9: note: uninitialized use occurs here return err; ^~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:2: note: remove the 'if' if its condition is always true if (IS_ERR(flow_rule)) { ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:474:9: note: initialize the variable 'err' to silence this warning int err; ^ = 0
Quoted 3 lines
1 error generated.
[...]
Here is the summary with links:
- [net-next] net/mlx5e: Do not use err uninitialized in mlx5e_rep_add_meta_tunnel_rule()
https://git.kernel.org/netdev/net-next/c/92f97c00f0ca
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html