Skip to contentSkip to conversation

Bluetooth: btintel: Mark Intel controller to support LE_STATES quirk

PATCH Applied Kiran K 4 participants 4 messages Sep 7, 2022 – Sep 9, 2022 Bluetooth drivers

lore
Share & tools
lore

Kiran K

author
#0 lore raw

PATCH 1/1 Bluetooth: btintel: Mark Intel controller to support LE_STATES quirk

HarrrisonPeak, CyclonePeak, SnowFieldPeak and SandyPeak controllers are marked to support HCI_QUIRK_LE_STATES.

---
 drivers/bluetooth/btintel.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)
drivers/bluetooth/btintel.c +8 -9
index 818681c89db8..d44a96667517 100644
@@ -2439,15 +2439,20 @@ static int btintel_setup_combined(struct hci_dev *hdev)
 					       INTEL_ROM_LEGACY_NO_WBS_SUPPORT))
 				set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED,
 					&hdev->quirks);
+			if (ver.hw_variant == 0x08 && ver.fw_variant == 0x22)
+				set_bit(HCI_QUIRK_VALID_LE_STATES,
+					&hdev->quirks);
 
 			err = btintel_legacy_rom_setup(hdev, &ver);
 			break;
 		case 0x0b:      /* SfP */
-		case 0x0c:      /* WsP */
 		case 0x11:      /* JfP */
 		case 0x12:      /* ThP */
 		case 0x13:      /* HrP */
 		case 0x14:      /* CcP */
+			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
+			fallthrough;
+		case 0x0c:	/* WsP */
 			/* Apply the device specific HCI quirks
 			 *
 			 * All Legacy bootloader devices support WBS
@@ -2455,11 +2460,6 @@ static int btintel_setup_combined(struct hci_dev *hdev)
 			set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED,
 				&hdev->quirks);
 
-			/* Valid LE States quirk for JfP/ThP familiy */
-			if (ver.hw_variant == 0x11 || ver.hw_variant == 0x12)
-				set_bit(HCI_QUIRK_VALID_LE_STATES,
-					&hdev->quirks);
-
 			/* Setup MSFT Extension support */
 			btintel_set_msft_opcode(hdev, ver.hw_variant);
 
@@ -2530,9 +2530,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
 		 */
 		set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
 
-		/* Valid LE States quirk for JfP/ThP familiy */
-		if (ver.hw_variant == 0x11 || ver.hw_variant == 0x12)
-			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
+		/* Set Valid LE States quirk */
+		set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
 
 		/* Setup MSFT Extension support */
 		btintel_set_msft_opcode(hdev, ver.hw_variant);
Signature · 1 line
2.17.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=674745

---Test result---

Test Summary:

CheckPatch                    PASS      1.91 seconds
GitLint                       PASS      1.02 seconds
SubjectPrefix                 PASS      0.85 seconds
BuildKernel                   PASS      36.62 seconds
BuildKernel32                 PASS      30.13 seconds
Incremental Build with patchesPASS      44.68 seconds
TestRunner: Setup             PASS      500.11 seconds
TestRunner: l2cap-tester      PASS      16.90 seconds
TestRunner: iso-tester        PASS      15.85 seconds
TestRunner: bnep-tester       PASS      6.28 seconds
TestRunner: mgmt-tester       PASS      100.95 seconds
TestRunner: rfcomm-tester     PASS      9.91 seconds
TestRunner: sco-tester        PASS      9.36 seconds
TestRunner: smp-tester        PASS      9.32 seconds
TestRunner: userchan-tester   PASS      6.46 seconds

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Kiran K

Dear Kiran,

Thank you for the patch.

Am 07.09.22 um 09:19 schrieb Kiran K:

Quoted 1 line

HarrrisonPeak, CyclonePeak, SnowFieldPeak and SandyPeak controllers

Harrison

Quoted 1 line

are marked to support HCI_QUIRK_LE_STATES.

“Supporting” a quirk sounds strange. Maybe better use “need”?

If new platforms need the quirk, do you know if the hardware folks are aware of this?

Kind regards,

Paul

Quoted 56 lines
---
  drivers/bluetooth/btintel.c | 17 ++++++++---------
  1 file changed, 8 insertions(+), 9 deletions(-)
drivers/bluetooth/btintel.c +8 -9
index 818681c89db8..d44a96667517 100644
@@ -2439,15 +2439,20 @@ static int btintel_setup_combined(struct hci_dev *hdev)
  					       INTEL_ROM_LEGACY_NO_WBS_SUPPORT))
  				set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED,
  					&hdev->quirks);
+			if (ver.hw_variant == 0x08 && ver.fw_variant == 0x22)
+				set_bit(HCI_QUIRK_VALID_LE_STATES,
+					&hdev->quirks);
 
  			err = btintel_legacy_rom_setup(hdev, &ver);
  			break;
  		case 0x0b:      /* SfP */
-		case 0x0c:      /* WsP */
  		case 0x11:      /* JfP */
  		case 0x12:      /* ThP */
  		case 0x13:      /* HrP */
  		case 0x14:      /* CcP */
+			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
+			fallthrough;
+		case 0x0c:	/* WsP */
  			/* Apply the device specific HCI quirks
  			 *
  			 * All Legacy bootloader devices support WBS
@@ -2455,11 +2460,6 @@ static int btintel_setup_combined(struct hci_dev *hdev)
  			set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED,
  				&hdev->quirks);
 
-			/* Valid LE States quirk for JfP/ThP familiy */
-			if (ver.hw_variant == 0x11 || ver.hw_variant == 0x12)
-				set_bit(HCI_QUIRK_VALID_LE_STATES,
-					&hdev->quirks);
-
  			/* Setup MSFT Extension support */
  			btintel_set_msft_opcode(hdev, ver.hw_variant);
 
@@ -2530,9 +2530,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
  		 */
  		set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
 
-		/* Valid LE States quirk for JfP/ThP familiy */
-		if (ver.hw_variant == 0x11 || ver.hw_variant == 0x12)
-			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
+		/* Set Valid LE States quirk */
+		set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
 
  		/* Setup MSFT Extension support */
  		btintel_set_msft_opcode(hdev, ver.hw_variant);
#3 lore raw
In reply to Kiran K
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 8 lines · On Wed, 7 Sep 2022 12:49:45 +0530 you wrote:

HarrrisonPeak, CyclonePeak, SnowFieldPeak and SandyPeak controllers are marked to support HCI_QUIRK_LE_STATES.

---
 drivers/bluetooth/btintel.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

Here is the summary with links:
- [v1] Bluetooth: btintel: Mark Intel controller to support LE_STATES quirk

    https://git.kernel.org/bluetooth/bluetooth-next/c/dd0a1794f433

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html