mmc: sunxi: change controller error info to debug level
Subsystems (2)
PATCH 1/1 mmc: sunxi: change controller error info to debug level
The controller's errors are usually normal (for example, for MMC or SDIO cards, some errors are expected to happen; and for boards without a dedicated card detect pin the error info will even flood console and hide other normal messages) and hard to understand.
Change their print level to debug, thus it won't be shown to generic users.
--- drivers/mmc/host/sunxi-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sunxi-mmc.c +1 -1
@@ -489,7 +489,7 @@ static void sunxi_mmc_dump_errinfo(struct sunxi_mmc_host *host) cmd->opcode == SD_IO_RW_DIRECT))return ; - dev_err(mmc_dev(host->mmc), + dev_dbg(mmc_dev(host->mmc), "smc %d err, cmd %d,%s%s%s%s%s%s%s%s%s%s !!\n", host->mmc->index, cmd->opcode, data ? (data->flags & MMC_DATA_WRITE ? " WR" : " RD") : "",
Signature · 1 line
2.12.0
Quoted 9 lines · Icenowy Zheng
The controller's errors are usually normal (for example, for MMC or SDIO cards, some errors are expected to happen; and for boards without a dedicated card detect pin the error info will even flood console and hide other normal messages) and hard to understand.
Change their print level to debug, thus it won't be shown to generic users.
Signed-off-by Icenowy Zheng <[email protected]>
Thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170320/c10080f5/attachment.sig>
Quoted 9 lines · Icenowy Zheng
The controller's errors are usually normal (for example, for MMC or SDIO cards, some errors are expected to happen; and for boards without a dedicated card detect pin the error info will even flood console and hide other normal messages) and hard to understand.
Change their print level to debug, thus it won't be shown to generic users.
Signed-off-by Icenowy Zheng <[email protected]>
For some reason this change didn't enter the mmc patchtracker. However I have picked it up for next anyway.
Thanks!
Kind regards
Uffe
Quoted 20 lines
--- drivers/mmc/host/sunxi-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/sunxi-mmc.c +1
-2@@ -489,7 +489,7 @@ static void sunxi_mmc_dump_errinfo(struct sunxi_mmc_host *host) cmd->opcode == SD_IO_RW_DIRECT))return ; - dev_err(mmc_dev(host->mmc), + dev_dbg(mmc_dev(host->mmc), "smc %d err, cmd %d,%s%s%s%s%s%s%s%s%s%s !!\n", host->mmc->index, cmd->opcode, data ? (data->flags & MMC_DATA_WRITE ? " WR" : " RD") : "", --2.12.0
PATCH 1/1 mmc: sunxi: change controller error info to debug level
24.03.2017, 15:46, "Ulf Hansson" <[email protected]>:
Quoted 6 lines · Icenowy Zheng
Quoted 5 lines
?The controller's errors are usually normal (for example, for MMC or SDIO ?cards, some errors are expected to happen; and for boards without a ?dedicated card detect pin the error info will even flood console and ?hide other normal messages) and hard to understand.
Quoted 7 lines
Quoted 4 lines
?Change their print level to debug, thus it won't be shown to generic ?users.
?Signed-off-by: Icenowy Zheng <[email protected]>
For some reason this change didn't enter the mmc patchtracker. However I have picked it up for next anyway.
Thanks!
Maybe it's because of the e-mail provider chosen by AOSC (Yandex.Mail).
Sorry. I will try to ask for a migration to other e-mail provider.
Quoted 25 lines
Thanks!
Kind regards
UffeQuoted 19 lines
?---
??drivers/mmc/host/sunxi-mmc.c | 2 +-
??1 file changed, 1 insertion(+), 1 deletion(-)?diff --git
a/drivers/mmc/host/sunxi-mmc.cb/drivers/mmc/host/sunxi-mmc.c?index6ffcd2838272..0391c62cc99f100644
?---a/drivers/mmc/host/sunxi-mmc.c
?+++b/drivers/mmc/host/sunxi-mmc.c
?@@ -489,7 +489,7 @@ static voidsunxi_mmc_dump_errinfo(struct sunxi_mmc_host *host)???????????????????????????????????????cmd->opcode ==SD_IO_RW_DIRECT)) ?????????????????return;?- dev_err(mmc_dev(host->mmc),
?+ dev_dbg(mmc_dev(host->mmc),
?????????????????"smc %d err, cmd %d,%s%s%s%s%s%s%s%s%s%s !!\n", ?????????????????host->mmc->index,cmd->opcode, ?????????????????data ? (data->flags&MMC_DATA_WRITE? " WR" : " RD") : "", ?--
?2.12.0