mlxbf_gige: clear MDIO gateway lock after read
Subsystems (2)
PATCH 1/1 mlxbf_gige: clear MDIO gateway lock after read
The MDIO gateway (GW) lock in BlueField-2 GIGE logic is set after read. This patch adds logic to make sure the lock is always cleared at the end of each MDIO transaction.
Fixes f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
Reviewed-by Asmaa Mnebhi <[email protected]>
Signed-off-by David Thompson <[email protected]>
--- drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c +6 -0
@@ -179,6 +179,9 @@ static int mlxbf_gige_mdio_read(struct mii_bus *bus, int phy_add, int phy_reg)/* Only return ad bits of the gw register */ ret &=MLXBF_GIGE_MDIO_GW_AD_MASK ; +/* The MDIO lock is set on read. To release it, clear gw register */ +writel (0 , priv->mdio_io +MLXBF_GIGE_MDIO_GW_OFFSET ); +return ret; }
@@ -203,6 +206,9 @@ static int mlxbf_gige_mdio_write(struct mii_bus *bus, int phy_add, temp, !(temp &MLXBF_GIGE_MDIO_GW_BUSY_MASK ), 5, 1000000); +/* The MDIO lock is set on read. To release it, clear gw register */ +writel (0 , priv->mdio_io +MLXBF_GIGE_MDIO_GW_OFFSET ); +return ret; }
Signature · 1 line
2.30.1
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Fri, 2 Sep 2022 12:42:47 -0400 you wrote:
The MDIO gateway (GW) lock in BlueField-2 GIGE logic is set after read. This patch adds logic to make sure the lock is always cleared at the end of each MDIO transaction.
Fixes f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")Reviewed-by Asmaa Mnebhi <[email protected]>Signed-off-by David Thompson <[email protected]>[...]
Here is the summary with links:
- [net,v1] mlxbf_gige: clear MDIO gateway lock after read
https://git.kernel.org/netdev/net/c/182447b12144
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html