scsi: core: Add io timeout count for scsi device
PATCH v2 1/1 scsi: core: Add io timeout count for scsi device
From: Wu Bo <[email protected]>
Current the scsi device has iorequest count, iodone count and ioerr count, but lack of io timeout count.
For better tracking of scsi io, So add it now.
Signed-off-by Wu Bo <[email protected]>
---v1->v2
Rebase this patch on top of Martin's for-next branch.
--- drivers/scsi/scsi_error.c | 1 + drivers/scsi/scsi_sysfs.c | 2 ++ include/scsi/scsi_device.h | 1 + 3 files changed, 4 insertions(+)
drivers/scsi/scsi_error.c +1 -0
@@ -334,6 +334,7 @@ enum blk_eh_timer_return scsi_timeout(struct request *req)trace_scsi_dispatch_cmd_timeout (scmd);scsi_log_completion (scmd,TIMEOUT_ERROR ); +atomic_inc (&scmd->device->iotmo_cnt);if (host->eh_deadline !=-1 && !host->last_reset) host->last_reset = jiffies;
drivers/scsi/scsi_sysfs.c +2 -0
@@ -976,6 +976,7 @@ static DEVICE_ATTR(field, S_IRUGO, show_iostat_##field, NULL)show_sdev_iostat (iorequest_cnt);show_sdev_iostat (iodone_cnt);show_sdev_iostat (ioerr_cnt); +show_sdev_iostat (iotmo_cnt);static ssize_t sdev_show_modalias (struct device *dev,struct device_attribute *attr,char *buf)
@@ -1295,6 +1296,7 @@ static umode_t scsi_sdev_bin_attr_is_visible(struct kobject *kobj, &dev_attr_iorequest_cnt.attr, &dev_attr_iodone_cnt.attr, &dev_attr_ioerr_cnt.attr, + &dev_attr_iotmo_cnt.attr, &dev_attr_modalias.attr, &dev_attr_queue_depth.attr, &dev_attr_queue_type.attr,
include/scsi/scsi_device.h +1 -0
@@ -231,6 +231,7 @@ struct scsi_device {atomic_t iorequest_cnt;atomic_t iodone_cnt;atomic_t ioerr_cnt; +atomic_t iotmo_cnt;struct device sdev_gendev, sdev_dev;
Signature · 1 line
1.8.3.1
Quoted 4 lines · Wu Bo
Current the scsi device has iorequest count, iodone count and ioerr count, but lack of io timeout count.
For better tracking of scsi io, So add it now.
Reviewed-by Bart Van Assche <[email protected]>
Martin K. Petersen
AppliedWu,
Quoted 2 lines
Current the scsi device has iorequest count, iodone count and ioerr count, but lack of io timeout count.
Applied to 6.1/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering